From: Sudeep Holla <sudeep.holla@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Igor Skalkin <igor.skalkin@opensynergy.com>,
Peter Hilber <peter.hilber@opensynergy.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation
Date: Mon, 20 Sep 2021 12:06:32 +0100 [thread overview]
Message-ID: <163213566221.1958937.10094633298863951666.b4-ty@arm.com> (raw)
In-Reply-To: <20210920100301.1466486-2-arnd@kernel.org>
On Mon, Sep 20, 2021 at 12:02:52PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> virtio_scmi_exit() is only called from __exit function, so the annotation
> is correct, but when the driver is built-in, the section gets discarded
> and the reference from a callback pointer causes a link-time error:
>
> `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o
>
> I could not figure out a better workaround, so let's just remove that
> annotation even if it wastes a couple of bytes in .text.
>
[...]
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[2/2] firmware: arm_scmi: remove __exit annotation
https://git.kernel.org/sudeep.holla/c/1cd73200da
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Igor Skalkin <igor.skalkin@opensynergy.com>,
Peter Hilber <peter.hilber@opensynergy.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation
Date: Mon, 20 Sep 2021 12:06:32 +0100 [thread overview]
Message-ID: <163213566221.1958937.10094633298863951666.b4-ty@arm.com> (raw)
In-Reply-To: <20210920100301.1466486-2-arnd@kernel.org>
On Mon, Sep 20, 2021 at 12:02:52PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> virtio_scmi_exit() is only called from __exit function, so the annotation
> is correct, but when the driver is built-in, the section gets discarded
> and the reference from a callback pointer causes a link-time error:
>
> `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o
>
> I could not figure out a better workaround, so let's just remove that
> annotation even if it wastes a couple of bytes in .text.
>
[...]
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[2/2] firmware: arm_scmi: remove __exit annotation
https://git.kernel.org/sudeep.holla/c/1cd73200da
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-20 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 10:02 [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Arnd Bergmann
2021-09-20 10:02 ` Arnd Bergmann
2021-09-20 10:02 ` [PATCH 2/2] firmware: arm_scmi: remove __exit annotation Arnd Bergmann
2021-09-20 10:02 ` Arnd Bergmann
2021-09-20 11:06 ` Sudeep Holla [this message]
2021-09-20 11:06 ` Sudeep Holla
2021-09-20 10:48 ` [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Sudeep Holla
2021-09-20 10:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163213566221.1958937.10094633298863951666.b4-ty@arm.com \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=igor.skalkin@opensynergy.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peter.hilber@opensynergy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.