All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
@ 2021-09-07  5:21 ` Zenghui Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Zenghui Yu @ 2021-09-07  5:21 UTC (permalink / raw)
  To: linux-arm-kernel, kvmarm, linux-kernel
  Cc: maz, james.morse, alexandru.elisei, suzuki.poulose,
	wanghaibin.wang, Zenghui Yu, David Brazdil, Masahiro Yamada

Add FORCE so that if_changed can detect the command line change.

We'll otherwise see a compilation warning since commit e1f86d7b4b2a
("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
filechk").

arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Cc: David Brazdil <dbrazdil@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 arch/arm64/kvm/hyp/nvhe/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
index 5df6193fc430..8d741f71377f 100644
--- a/arch/arm64/kvm/hyp/nvhe/Makefile
+++ b/arch/arm64/kvm/hyp/nvhe/Makefile
@@ -54,7 +54,7 @@ $(obj)/kvm_nvhe.tmp.o: $(obj)/hyp.lds $(addprefix $(obj)/,$(hyp-obj)) FORCE
 #    runtime. Because the hypervisor is part of the kernel binary, relocations
 #    produce a kernel VA. We enumerate relocations targeting hyp at build time
 #    and convert the kernel VAs at those positions to hyp VAs.
-$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel
+$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel FORCE
 	$(call if_changed,hyprel)
 
 # 5) Compile hyp-reloc.S and link it into the existing partially linked object.
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
@ 2021-09-07  5:21 ` Zenghui Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Zenghui Yu @ 2021-09-07  5:21 UTC (permalink / raw)
  To: linux-arm-kernel, kvmarm, linux-kernel; +Cc: maz, Masahiro Yamada

Add FORCE so that if_changed can detect the command line change.

We'll otherwise see a compilation warning since commit e1f86d7b4b2a
("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
filechk").

arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Cc: David Brazdil <dbrazdil@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 arch/arm64/kvm/hyp/nvhe/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
index 5df6193fc430..8d741f71377f 100644
--- a/arch/arm64/kvm/hyp/nvhe/Makefile
+++ b/arch/arm64/kvm/hyp/nvhe/Makefile
@@ -54,7 +54,7 @@ $(obj)/kvm_nvhe.tmp.o: $(obj)/hyp.lds $(addprefix $(obj)/,$(hyp-obj)) FORCE
 #    runtime. Because the hypervisor is part of the kernel binary, relocations
 #    produce a kernel VA. We enumerate relocations targeting hyp at build time
 #    and convert the kernel VAs at those positions to hyp VAs.
-$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel
+$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel FORCE
 	$(call if_changed,hyprel)
 
 # 5) Compile hyp-reloc.S and link it into the existing partially linked object.
-- 
2.19.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
@ 2021-09-07  5:21 ` Zenghui Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Zenghui Yu @ 2021-09-07  5:21 UTC (permalink / raw)
  To: linux-arm-kernel, kvmarm, linux-kernel
  Cc: maz, james.morse, alexandru.elisei, suzuki.poulose,
	wanghaibin.wang, Zenghui Yu, David Brazdil, Masahiro Yamada

Add FORCE so that if_changed can detect the command line change.

We'll otherwise see a compilation warning since commit e1f86d7b4b2a
("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
filechk").

arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Cc: David Brazdil <dbrazdil@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 arch/arm64/kvm/hyp/nvhe/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
index 5df6193fc430..8d741f71377f 100644
--- a/arch/arm64/kvm/hyp/nvhe/Makefile
+++ b/arch/arm64/kvm/hyp/nvhe/Makefile
@@ -54,7 +54,7 @@ $(obj)/kvm_nvhe.tmp.o: $(obj)/hyp.lds $(addprefix $(obj)/,$(hyp-obj)) FORCE
 #    runtime. Because the hypervisor is part of the kernel binary, relocations
 #    produce a kernel VA. We enumerate relocations targeting hyp at build time
 #    and convert the kernel VAs at those positions to hyp VAs.
-$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel
+$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel FORCE
 	$(call if_changed,hyprel)
 
 # 5) Compile hyp-reloc.S and link it into the existing partially linked object.
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
  2021-09-07  5:21 ` Zenghui Yu
  (?)
@ 2021-09-20 11:44   ` Marc Zyngier
  -1 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-09-20 11:44 UTC (permalink / raw)
  To: kvmarm, linux-arm-kernel, linux-kernel, Zenghui Yu
  Cc: Masahiro Yamada, David Brazdil, suzuki.poulose, james.morse,
	alexandru.elisei, wanghaibin.wang

On Tue, 7 Sep 2021 13:21:37 +0800, Zenghui Yu wrote:
> Add FORCE so that if_changed can detect the command line change.
> 
> We'll otherwise see a compilation warning since commit e1f86d7b4b2a
> ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
> filechk").
> 
> arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Applied to fixes, thanks!

[1/1] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
      commit: a49b50a3c1c3226d26e1dd11e8b763f27e477623

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
@ 2021-09-20 11:44   ` Marc Zyngier
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-09-20 11:44 UTC (permalink / raw)
  To: kvmarm, linux-arm-kernel, linux-kernel, Zenghui Yu; +Cc: Masahiro Yamada

On Tue, 7 Sep 2021 13:21:37 +0800, Zenghui Yu wrote:
> Add FORCE so that if_changed can detect the command line change.
> 
> We'll otherwise see a compilation warning since commit e1f86d7b4b2a
> ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
> filechk").
> 
> arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Applied to fixes, thanks!

[1/1] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
      commit: a49b50a3c1c3226d26e1dd11e8b763f27e477623

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
@ 2021-09-20 11:44   ` Marc Zyngier
  0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-09-20 11:44 UTC (permalink / raw)
  To: kvmarm, linux-arm-kernel, linux-kernel, Zenghui Yu
  Cc: Masahiro Yamada, David Brazdil, suzuki.poulose, james.morse,
	alexandru.elisei, wanghaibin.wang

On Tue, 7 Sep 2021 13:21:37 +0800, Zenghui Yu wrote:
> Add FORCE so that if_changed can detect the command line change.
> 
> We'll otherwise see a compilation warning since commit e1f86d7b4b2a
> ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and
> filechk").
> 
> arch/arm64/kvm/hyp/nvhe/Makefile:58: FORCE prerequisite is missing

Applied to fixes, thanks!

[1/1] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule
      commit: a49b50a3c1c3226d26e1dd11e8b763f27e477623

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-20 11:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07  5:21 [PATCH] KVM: arm64: nvhe: Fix missing FORCE for hyp-reloc.S build rule Zenghui Yu
2021-09-07  5:21 ` Zenghui Yu
2021-09-07  5:21 ` Zenghui Yu
2021-09-20 11:44 ` Marc Zyngier
2021-09-20 11:44   ` Marc Zyngier
2021-09-20 11:44   ` Marc Zyngier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.