* [PATCH] drm/i915/gt: return NULL rather than a plain 0 integer
@ 2021-09-25 22:12 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2021-09-25 22:12 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, David Airlie, Chris Wilson,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Function gen7_ctx_vma returns a pointer to struct i915_vma, so
returning a plain 0 integer isn't good practice. Fix this by
returning a NULL instead.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 2958e2fae380..3c65efcb7bed 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -1265,7 +1265,7 @@ static struct i915_vma *gen7_ctx_vma(struct intel_engine_cs *engine)
int size, err;
if (GRAPHICS_VER(engine->i915) != 7 || engine->class != RENDER_CLASS)
- return 0;
+ return NULL;
err = gen7_ctx_switch_bb_setup(engine, NULL /* probe size */);
if (err < 0)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: return NULL rather than a plain 0 integer
@ 2021-09-25 22:12 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2021-09-25 22:12 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, David Airlie, Chris Wilson,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Function gen7_ctx_vma returns a pointer to struct i915_vma, so
returning a plain 0 integer isn't good practice. Fix this by
returning a NULL instead.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 2958e2fae380..3c65efcb7bed 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -1265,7 +1265,7 @@ static struct i915_vma *gen7_ctx_vma(struct intel_engine_cs *engine)
int size, err;
if (GRAPHICS_VER(engine->i915) != 7 || engine->class != RENDER_CLASS)
- return 0;
+ return NULL;
err = gen7_ctx_switch_bb_setup(engine, NULL /* probe size */);
if (err < 0)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: return NULL rather than a plain 0 integer
2021-09-25 22:12 ` [Intel-gfx] " Colin King
(?)
@ 2021-09-25 22:37 ` Patchwork
-1 siblings, 0 replies; 3+ messages in thread
From: Patchwork @ 2021-09-25 22:37 UTC (permalink / raw)
To: Colin King; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
== Series Details ==
Series: drm/i915/gt: return NULL rather than a plain 0 integer
URL : https://patchwork.freedesktop.org/series/95062/
State : failure
== Summary ==
Applying: drm/i915/gt: return NULL rather than a plain 0 integer
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/intel_ring_submission.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/gt/intel_ring_submission.c
No changes -- Patch already applied.
[-- Attachment #2: Type: text/html, Size: 984 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-25 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25 22:12 [PATCH] drm/i915/gt: return NULL rather than a plain 0 integer Colin King
2021-09-25 22:12 ` [Intel-gfx] " Colin King
2021-09-25 22:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.