* [PATCH] qed: Fix missing error code in qed_slowpath_start()
@ 2021-10-09 8:09 Jiapeng Chong
2021-10-09 12:50 ` patchwork-bot+netdevbpf
2021-10-11 5:17 ` [EXT] " Alok Prasad
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-10-09 8:09 UTC (permalink / raw)
To: aelior
Cc: GR-everest-linux-l2, davem, kuba, linux, ast, daniel, hawk,
john.fastabend, netdev, linux-kernel, bpf, chongjiapeng
From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'rc'.
Eliminate the follow smatch warning:
drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
warn: missing error code 'rc'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
---
drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index 5e7242304ee2..359ad859ae18 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
} else {
DP_NOTICE(cdev,
"Failed to acquire PTT for aRFS\n");
+ rc = -EINVAL;
goto err;
}
}
--
2.19.1.6.gb485710b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: Fix missing error code in qed_slowpath_start()
2021-10-09 8:09 [PATCH] qed: Fix missing error code in qed_slowpath_start() Jiapeng Chong
@ 2021-10-09 12:50 ` patchwork-bot+netdevbpf
2021-10-11 5:17 ` [EXT] " Alok Prasad
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-09 12:50 UTC (permalink / raw)
To: Jiapeng Chong
Cc: aelior, GR-everest-linux-l2, davem, kuba, linux, ast, daniel,
hawk, john.fastabend, netdev, linux-kernel, bpf
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 9 Oct 2021 16:09:26 +0800 you wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
>
> Eliminate the follow smatch warning:
>
> [...]
Here is the summary with links:
- qed: Fix missing error code in qed_slowpath_start()
https://git.kernel.org/netdev/net/c/a5a14ea7b4e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
2021-10-09 8:09 [PATCH] qed: Fix missing error code in qed_slowpath_start() Jiapeng Chong
2021-10-09 12:50 ` patchwork-bot+netdevbpf
@ 2021-10-11 5:17 ` Alok Prasad
1 sibling, 0 replies; 3+ messages in thread
From: Alok Prasad @ 2021-10-11 5:17 UTC (permalink / raw)
To: Jiapeng Chong, Ariel Elior
Cc: GR-everest-linux-l2, davem, kuba, linux, ast, daniel, hawk,
john.fastabend, netdev, linux-kernel, bpf
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: 09 October 2021 13:39
> To: Ariel Elior <aelior@marvell.com>
> Cc: GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>; davem@davemloft.net;
> kuba@kernel.org; linux@armlinux.org.uk; ast@kernel.org; daniel@iogearbox.net;
> hawk@kernel.org; john.fastabend@gmail.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bpf@vger.kernel.org; chongjiapeng
> <jiapeng.chong@linux.alibaba.com>
> Subject: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
>
> External Email
>
> ----------------------------------------------------------------------
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
> warn: missing error code 'rc'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
> b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 5e7242304ee2..359ad859ae18 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
> } else {
> DP_NOTICE(cdev,
> "Failed to acquire PTT for aRFS\n");
> + rc = -EINVAL;
> goto err;
> }
> }
> --
> 2.19.1.6.gb485710b
Thanks!
Acked-by: Alok Prasad <palok@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-11 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-09 8:09 [PATCH] qed: Fix missing error code in qed_slowpath_start() Jiapeng Chong
2021-10-09 12:50 ` patchwork-bot+netdevbpf
2021-10-11 5:17 ` [EXT] " Alok Prasad
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.