All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Dinghao Liu <dinghao.liu@zju.edu.cn>,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org
Cc: Aditya Pakki <pakki001@umn.edu>,
	Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Qiushi Wu <wu000273@umn.edu>,
	linux-kernel@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Biggers <ebiggers@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
Date: Tue, 23 Jun 2020 17:00:32 +0200	[thread overview]
Message-ID: <16341716-aeb6-febc-441c-c1826da8c4d3@web.de> (raw)
In-Reply-To: <20200623134442.wj4i3r3dlp6rtpaq@gilmour.lan>

>>> Fix this by …
>>
>> Please replace the beginning of this sentence with the tag “Fixes”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>
> No, not really. The comment you (partially) quoted explains how the
> issue is fixed, your suggestion explains what commit introduced the fix
> in the first place. They are both beneficial, but there's strictly no
> reason to remove the former for the latter.

Do you care to improve this change description another bit?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Dinghao Liu <dinghao.liu@zju.edu.cn>,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Biggers <ebiggers@google.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Kangjie Lu <kjlu@umn.edu>, YueHaibing <yuehaibing@huawei.com>,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Navid Emamdoost <emamd001@umn.edu>,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	Qiushi Wu <wu000273@umn.edu>, Aditya Pakki <pakki001@umn.edu>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
Date: Tue, 23 Jun 2020 17:00:32 +0200	[thread overview]
Message-ID: <16341716-aeb6-febc-441c-c1826da8c4d3@web.de> (raw)
In-Reply-To: <20200623134442.wj4i3r3dlp6rtpaq@gilmour.lan>

>>> Fix this by …
>>
>> Please replace the beginning of this sentence with the tag “Fixes”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>
> No, not really. The comment you (partially) quoted explains how the
> issue is fixed, your suggestion explains what commit introduced the fix
> in the first place. They are both beneficial, but there's strictly no
> reason to remove the former for the latter.

Do you care to improve this change description another bit?

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-23 15:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 17:50 [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init Markus Elfring
2020-06-23 13:44 ` Maxime Ripard
2020-06-23 15:00   ` Markus Elfring [this message]
2020-06-23 15:00     ` Markus Elfring
2020-06-23 16:56     ` Maxime Ripard
2020-06-23 16:56       ` Maxime Ripard
2020-06-23 18:12       ` Markus Elfring
2020-06-23 18:12         ` Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-06-22  2:40 Dinghao Liu
2020-07-03  4:47 ` Herbert Xu
2020-07-03  4:47   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16341716-aeb6-febc-441c-c1826da8c4d3@web.de \
    --to=markus.elfring@web.de \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=ebiggers@google.com \
    --cc=emamd001@umn.edu \
    --cc=herbert@gondor.apana.org.au \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=mchehab+huawei@kernel.org \
    --cc=pakki001@umn.edu \
    --cc=wens@csie.org \
    --cc=wu000273@umn.edu \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.