* [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain @ 2021-12-09 12:01 Tejas Upadhyay 2021-12-10 0:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 6+ messages in thread From: Tejas Upadhyay @ 2021-12-09 12:01 UTC (permalink / raw) To: intel-gfx Most code paths does full reset with preparing all engines for reset except below two : 1. Single engine reset needs to prepare engines for reset based on its reset domain. In __intel_engine _reset_bh is a place needs loop over to do engine prepare for all engines which are in same reset domain before triggering reset. 2. enable_error_interrupt() in drivers/gpu/drm/i915/ gt/intel_execlists_submission.c needs similar change. whenever there is full reset done, engine prepare for all engines are already being called right now before actual reset triggered, except above two scenario seeking single engine reset. Note: Requirement of this change is occurred recently because whenever engine does reset, all engines in same reset domain gets reset and in case engine goes for reset before stopping CS or applying required W/A, there are high chances of hang/crash. reset_prepare_ engine takes care of it. Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 +++++++++ drivers/gpu/drm/i915/gt/intel_reset.c | 12 ++++++++++-- drivers/gpu/drm/i915/gt/intel_reset.h | 1 + 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c index a69df5e9e77a..668e7ba5b254 100644 --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c @@ -2806,6 +2806,15 @@ static void enable_error_interrupt(struct intel_engine_cs *engine) drm_err(&engine->i915->drm, "engine '%s' resumed still in error: %08x\n", engine->name, status); + if (engine->reset_domain) { + struct intel_engine_cs *nengine; + enum intel_engine_id id; + + for_each_engine(nengine, engine->gt, id) + if (nengine->reset_domain == + engine->reset_domain) + reset_prepare_engine(nengine); + } __intel_gt_reset(engine->gt, engine->mask); } diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index 63199f0550e6..454d6ab1d9f4 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -705,7 +705,7 @@ int intel_reset_guc(struct intel_gt *gt) * Ensure irq handler finishes, and not run again. * Also return the active request so that we only search for it once. */ -static void reset_prepare_engine(struct intel_engine_cs *engine) +void reset_prepare_engine(struct intel_engine_cs *engine) { /* * During the reset sequence, we must prevent the engine from @@ -1167,7 +1167,15 @@ int __intel_engine_reset_bh(struct intel_engine_cs *engine, const char *msg) if (!intel_engine_pm_get_if_awake(engine)) return 0; - reset_prepare_engine(engine); + if (engine->reset_domain) { + struct intel_engine_cs *nengine; + enum intel_engine_id id; + + for_each_engine(nengine, gt, id) + if (nengine->reset_domain == + engine->reset_domain) + reset_prepare_engine(nengine); + } if (msg) drm_notice(&engine->i915->drm, diff --git a/drivers/gpu/drm/i915/gt/intel_reset.h b/drivers/gpu/drm/i915/gt/intel_reset.h index adc734e67387..7abd5d49f0e5 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.h +++ b/drivers/gpu/drm/i915/gt/intel_reset.h @@ -28,6 +28,7 @@ void intel_gt_handle_error(struct intel_gt *gt, const char *fmt, ...); #define I915_ERROR_CAPTURE BIT(0) +void reset_prepare_engine(struct intel_engine_cs *engine); void intel_gt_reset(struct intel_gt *gt, intel_engine_mask_t stalled_mask, const char *reason); -- 2.31.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: prepare reset based on reset domain 2021-12-09 12:01 [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain Tejas Upadhyay @ 2021-12-10 0:36 ` Patchwork 2021-12-10 1:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-12-10 0:36 UTC (permalink / raw) To: Tejas Upadhyay; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: prepare reset based on reset domain URL : https://patchwork.freedesktop.org/series/97786/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prepare reset based on reset domain 2021-12-09 12:01 [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain Tejas Upadhyay 2021-12-10 0:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork @ 2021-12-10 1:04 ` Patchwork 2021-12-10 11:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-12-16 9:52 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-12-10 1:04 UTC (permalink / raw) To: Tejas Upadhyay; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6818 bytes --] == Series Details == Series: drm/i915/gt: prepare reset based on reset domain URL : https://patchwork.freedesktop.org/series/97786/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984 -> Patchwork_21799 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/index.html Participating hosts (44 -> 36) ------------------------------ Additional (2): fi-kbl-soraka fi-tgl-u2 Missing (10): fi-ilk-m540 bat-dg1-6 fi-hsw-4200u fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 fi-pnv-d510 bat-jsl-2 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_21799 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fence@basic-busy@bcs0: - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html * igt@gem_huc_copy@huc-copy: - fi-tgl-u2: NOTRUN -> [SKIP][2] ([i915#2190]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@verify-random: - fi-tgl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@gem_lmem_swapping@verify-random.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886] / [i915#2291]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-hpd-fast: - fi-tgl-u2: NOTRUN -> [SKIP][8] ([fdo#109284] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-tgl-u2: NOTRUN -> [SKIP][9] ([i915#4103]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-u2: NOTRUN -> [SKIP][10] ([fdo#109285]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_psr@primary_page_flip: - fi-skl-6600u: [PASS][12] -> [FAIL][13] ([i915#4547]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/fi-skl-6600u/igt@kms_psr@primary_page_flip.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-skl-6600u/igt@kms_psr@primary_page_flip.html * igt@prime_vgem@basic-userptr: - fi-tgl-u2: NOTRUN -> [SKIP][14] ([i915#3301]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-tgl-u2/igt@prime_vgem@basic-userptr.html * igt@runner@aborted: - fi-skl-6600u: NOTRUN -> [FAIL][15] ([i915#3363] / [i915#4312]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-skl-6600u/igt@runner@aborted.html - fi-bdw-5557u: NOTRUN -> [FAIL][16] ([i915#2426] / [i915#4312]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-bdw-5557u/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-glk-dsi: [DMESG-WARN][17] ([i915#2943]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [DMESG-WARN][19] ([i915#4269]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2943]: https://gitlab.freedesktop.org/drm/intel/issues/2943 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Build changes ------------- * Linux: CI_DRM_10984 -> Patchwork_21799 CI-20190529: 20190529 CI_DRM_10984: d7b5243a6417de5fc244d7dc45109f6835aa7c88 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6304: ef0df2fbe5847fe5c4426b8a86a0b101588d0586 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21799: 28556fcbf0125294220fd670c07a1881abacfd27 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 28556fcbf012 drm/i915/gt: prepare reset based on reset domain == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/index.html [-- Attachment #2: Type: text/html, Size: 8360 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: prepare reset based on reset domain 2021-12-09 12:01 [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain Tejas Upadhyay 2021-12-10 0:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork 2021-12-10 1:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-12-10 11:29 ` Patchwork 2021-12-16 9:52 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-12-10 11:29 UTC (permalink / raw) To: Surendrakumar Upadhyay, TejaskumarX; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30271 bytes --] == Series Details == Series: drm/i915/gt: prepare reset based on reset domain URL : https://patchwork.freedesktop.org/series/97786/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21799_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_21799_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][1] ([i915#3002]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@gem_create@create-massive.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][2] -> [TIMEOUT][3] ([i915#3063] / [i915#3648]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-tglb1/igt@gem_eio@unwedge-stress.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-tglb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-none@vcs1: - shard-iclb: NOTRUN -> [FAIL][6] ([i915#2842]) +4 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_params@no-vebox: - shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271]) +31 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl9/igt@gem_exec_params@no-vebox.html * igt@gem_lmem_swapping@parallel-random-verify: - shard-skl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@gem_lmem_swapping@parallel-random-verify.html - shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl6/igt@gem_lmem_swapping@parallel-random-verify.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][12] ([i915#768]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@gen7_exec_parse@load-register-reg: - shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109289]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@gen7_exec_parse@load-register-reg.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#658]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][15] -> [FAIL][16] ([i915#454]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb2/igt@i915_pm_dc@dc6-psr.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb4/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [PASS][17] -> [SKIP][18] ([i915#4281]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-tglb: NOTRUN -> [SKIP][19] ([fdo#109506] / [i915#2411]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-tglb2/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_pm_sseu@full-enable: - shard-skl: [PASS][20] -> [FAIL][21] ([i915#3524]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl6/igt@i915_pm_sseu@full-enable.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl1/igt@i915_pm_sseu@full-enable.html * igt@i915_suspend@forcewake: - shard-skl: [PASS][22] -> [INCOMPLETE][23] ([i915#636]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl7/igt@i915_suspend@forcewake.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl10/igt@i915_suspend@forcewake.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][24] -> [FAIL][25] ([i915#2521]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-glk: [PASS][26] -> [DMESG-WARN][27] ([i915#118]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3777]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3886]) +4 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs: - shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109278]) +7 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109278] / [i915#3886]) +1 similar issue [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl9/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_cdclk@mode-transition: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271]) +100 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@kms_cdclk@mode-transition.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +6 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_chamelium@vga-edid-read: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109284] / [fdo#111827]) +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_chamelium@vga-edid-read.html * igt@kms_color_chamelium@pipe-b-ctm-0-25: - shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +2 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@kms_color_chamelium@pipe-b-ctm-0-25.html * igt@kms_content_protection@lic: - shard-apl: NOTRUN -> [TIMEOUT][37] ([i915#1319]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl6/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen: - shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [fdo#109279]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][39] -> [INCOMPLETE][40] ([i915#180] / [i915#636]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-nonexisting-fb: - shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109274]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_flip@2x-nonexisting-fb.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2: - shard-glk: [PASS][42] -> [FAIL][43] ([i915#2122]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([i915#180]) +7 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-apl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-apl1/igt@kms_flip@flip-vs-suspend@c-dp1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-msflip-blt: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109280]) +5 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-msflip-blt.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu: - shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +4 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [PASS][50] -> [FAIL][51] ([i915#1188]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence: - shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl9/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html - shard-apl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][55] ([i915#265]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][56] -> [FAIL][57] ([fdo#108145] / [i915#265]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_su@page_flip-p010: - shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@kms_psr2_su@page_flip-p010.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109441]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [PASS][60] -> [SKIP][61] ([fdo#109441]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_selftest@all@check_plane_state: - shard-kbl: NOTRUN -> [INCOMPLETE][62] ([i915#4663]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@kms_selftest@all@check_plane_state.html * igt@nouveau_crc@pipe-c-ctx-flip-detection: - shard-iclb: NOTRUN -> [SKIP][63] ([i915#2530]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@nouveau_crc@pipe-c-ctx-flip-detection.html * igt@perf_pmu@rc6-suspend: - shard-skl: [PASS][64] -> [INCOMPLETE][65] ([i915#198]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl8/igt@perf_pmu@rc6-suspend.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl10/igt@perf_pmu@rc6-suspend.html * igt@prime_vgem@fence-write-hang: - shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109295]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb1/igt@prime_vgem@fence-write-hang.html * igt@sysfs_clients@fair-0: - shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2994]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl7/igt@sysfs_clients@fair-0.html #### Possible fixes #### * igt@gem_eio@in-flight-contexts-10ms: - shard-tglb: [TIMEOUT][68] ([i915#3063]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-tglb2/igt@gem_eio@in-flight-contexts-10ms.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-tglb1/igt@gem_eio@in-flight-contexts-10ms.html * igt@gem_exec_fair@basic-none-solo@rcs0: - {shard-rkl}: ([FAIL][70], [FAIL][71]) ([i915#2842]) -> [PASS][72] [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-2/igt@gem_exec_fair@basic-none-solo@rcs0.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-4/igt@gem_exec_fair@basic-none-solo@rcs0.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-1/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-none@vecs0: - shard-apl: [FAIL][73] ([i915#2842]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: [FAIL][75] ([i915#2842]) -> [PASS][76] +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-tglb6/igt@gem_exec_fair@basic-pace@bcs0.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-tglb7/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][77] ([i915#2842]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - {shard-rkl}: [FAIL][79] ([i915#2842]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [INCOMPLETE][81] ([i915#151]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl4/igt@i915_pm_rpm@system-suspend-execbuf.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl4/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-random: - {shard-rkl}: [SKIP][83] ([fdo#112022]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-128x42-random.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-128x42-random.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-iclb: [FAIL][85] ([i915#2346]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][87] ([i915#2346] / [i915#533]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][89] ([i915#79]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-expired-vblank@c-edp1: - shard-skl: [FAIL][91] ([i915#79]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94] +4 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@flip-vs-suspend@c-edp1: - shard-skl: [INCOMPLETE][95] ([i915#198]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl4/igt@kms_flip@flip-vs-suspend@c-edp1.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl9/igt@kms_flip@flip-vs-suspend@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: - shard-iclb: [SKIP][97] ([i915#3701]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render: - {shard-rkl}: [SKIP][99] ([i915#4098]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw: - {shard-rkl}: ([PASS][101], [SKIP][102]) ([i915#4098]) -> [PASS][103] +2 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][104] ([fdo#108145] / [i915#265]) -> [PASS][105] +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_rotation_crc@primary-rotation-90: - {shard-rkl}: ([PASS][106], [SKIP][107]) ([i915#1845]) -> [PASS][108] +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-rkl-4/igt@kms_rotation_crc@primary-rotation-90.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-kbl: [INCOMPLETE][109] ([i915#2828] / [i915#794]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@perf@polling: - shard-skl: [FAIL][111] ([i915#1542]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-skl9/igt@perf@polling.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-skl8/igt@perf@polling.html #### Warnings #### * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-iclb: [FAIL][113] ([i915#2842]) -> [FAIL][114] ([i915#2852]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb5/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][115] ([i915#2684]) -> [WARN][116] ([i915#1804] / [i915#2684]) +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-kbl: [INCOMPLETE][117] ([i915#636]) -> [DMESG-WARN][118] ([i915#180]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt: - shard-glk: [SKIP][119] ([fdo#109271] / [i915#1888]) -> [SKIP][120] ([fdo#109271]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-glk3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][121] ([i915#2920]) -> [SKIP][122] ([i915#658]) +3 similar issues [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-iclb: [SKIP][123] ([i915#658]) -> [FAIL][124] ([i915#4688]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-iclb7/igt@kms_psr2_su@frontbuffer-xrgb8888.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@runner@aborted: - shard-kbl: ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#602]) -> ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#4312] / [i915#602] / [i915#92]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl1/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl4/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl1/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl6/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl1/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl1/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl4/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10984/shard-kbl1/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl1/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl4/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl7/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl4/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl6/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/shard-kbl4/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21799/index.html [-- Attachment #2: Type: text/html, Size: 33847 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain 2021-12-09 12:01 [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain Tejas Upadhyay ` (2 preceding siblings ...) 2021-12-10 11:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-12-16 9:52 ` Tvrtko Ursulin 2022-02-11 23:00 ` Rodrigo Vivi 3 siblings, 1 reply; 6+ messages in thread From: Tvrtko Ursulin @ 2021-12-16 9:52 UTC (permalink / raw) To: Tejas Upadhyay, intel-gfx On 09/12/2021 12:01, Tejas Upadhyay wrote: > Most code paths does full reset with preparing all > engines for reset except below two : > > 1. Single engine reset needs to prepare engines for > reset based on its reset domain. In __intel_engine > _reset_bh is a place needs loop over to do engine > prepare for all engines which are in same reset > domain before triggering reset. > > 2. enable_error_interrupt() in drivers/gpu/drm/i915/ > gt/intel_execlists_submission.c needs similar change. > > whenever there is full reset done, engine prepare for > all engines are already being called right now before > actual reset triggered, except above two scenario > seeking single engine reset. > > Note: Requirement of this change is occurred recently > because whenever engine does reset, all engines in > same reset domain gets reset and in case engine goes > for reset before stopping CS or applying required W/A, > there are high chances of hang/crash. reset_prepare_ > engine takes care of it. On the trivial level, please wrap your commit messages to standard 75 wide. See Documentation/process/submitting-patches.rst. > > Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 +++++++++ > drivers/gpu/drm/i915/gt/intel_reset.c | 12 ++++++++++-- > drivers/gpu/drm/i915/gt/intel_reset.h | 1 + > 3 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > index a69df5e9e77a..668e7ba5b254 100644 > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > @@ -2806,6 +2806,15 @@ static void enable_error_interrupt(struct intel_engine_cs *engine) > drm_err(&engine->i915->drm, > "engine '%s' resumed still in error: %08x\n", > engine->name, status); > + if (engine->reset_domain) { > + struct intel_engine_cs *nengine; > + enum intel_engine_id id; > + > + for_each_engine(nengine, engine->gt, id) > + if (nengine->reset_domain == > + engine->reset_domain) > + reset_prepare_engine(nengine); > + } > __intel_gt_reset(engine->gt, engine->mask); > } > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > index 63199f0550e6..454d6ab1d9f4 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > @@ -705,7 +705,7 @@ int intel_reset_guc(struct intel_gt *gt) > * Ensure irq handler finishes, and not run again. > * Also return the active request so that we only search for it once. > */ > -static void reset_prepare_engine(struct intel_engine_cs *engine) > +void reset_prepare_engine(struct intel_engine_cs *engine) > { > /* > * During the reset sequence, we must prevent the engine from > @@ -1167,7 +1167,15 @@ int __intel_engine_reset_bh(struct intel_engine_cs *engine, const char *msg) > if (!intel_engine_pm_get_if_awake(engine)) > return 0; > > - reset_prepare_engine(engine); > + if (engine->reset_domain) { Can it be zero? > + struct intel_engine_cs *nengine; > + enum intel_engine_id id; > + > + for_each_engine(nengine, gt, id) > + if (nengine->reset_domain == > + engine->reset_domain) > + reset_prepare_engine(nengine); Having glanced over the discussion about the workaround you are trying to implement a few times, this is what I think. First of all I think you are definitely missing the engine resume side of things. Consider this entry point: execlists_submission_tasklet execlists_reset intel_engine_reset __intel_engine_reset_bh AFAICT you can halt more than one engine but you will not resume them all. What I mean here is that __intel_engine_reset, intel_engine_resume, reset_finish_engine and even the engine pm management end up being called for only one engine. Also absence of locking via I915_RESET_ENGINE in gt reset flags. Secondly, the question on whether it is acceptable to corrupt the state for the other engine seems not to have a 100% clear answer. Can this be confirmed? Because in the ideal world you would really need to preempt to idle the other engines from the engine group and only then would be able to proceed. If that is considered a problem for later, with the first step being adding of a simpler workaround to prevent a more serious lockup, then it may be acceptable with some tweaks. I suspect there isn't a proper IGT for this otherwise you would have noticed the failure to resume the coupled engines? So I think next step is to write that IGT and then make sure code is robust. Sufficient testing will probably drive the implementation. You may for instance need to lock all engines for reset starting from execlists_reset() and you may end up uncovering locking/ordering challenges as you go. Regards, Tvrtko > + } > > if (msg) > drm_notice(&engine->i915->drm, > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.h b/drivers/gpu/drm/i915/gt/intel_reset.h > index adc734e67387..7abd5d49f0e5 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.h > +++ b/drivers/gpu/drm/i915/gt/intel_reset.h > @@ -28,6 +28,7 @@ void intel_gt_handle_error(struct intel_gt *gt, > const char *fmt, ...); > #define I915_ERROR_CAPTURE BIT(0) > > +void reset_prepare_engine(struct intel_engine_cs *engine); > void intel_gt_reset(struct intel_gt *gt, > intel_engine_mask_t stalled_mask, > const char *reason); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain 2021-12-16 9:52 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2022-02-11 23:00 ` Rodrigo Vivi 0 siblings, 0 replies; 6+ messages in thread From: Rodrigo Vivi @ 2022-02-11 23:00 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: intel-gfx, Tejas Upadhyay On Thu, Dec 16, 2021 at 09:52:26AM +0000, Tvrtko Ursulin wrote: > > > On 09/12/2021 12:01, Tejas Upadhyay wrote: > > Most code paths does full reset with preparing all > > engines for reset except below two : > > > > 1. Single engine reset needs to prepare engines for > > reset based on its reset domain. In __intel_engine > > _reset_bh is a place needs loop over to do engine > > prepare for all engines which are in same reset > > domain before triggering reset. > > > > 2. enable_error_interrupt() in drivers/gpu/drm/i915/ > > gt/intel_execlists_submission.c needs similar change. > > > > whenever there is full reset done, engine prepare for > > all engines are already being called right now before > > actual reset triggered, except above two scenario > > seeking single engine reset. > > > > Note: Requirement of this change is occurred recently > > because whenever engine does reset, all engines in > > same reset domain gets reset and in case engine goes > > for reset before stopping CS or applying required W/A, > > there are high chances of hang/crash. reset_prepare_ > > engine takes care of it. > > On the trivial level, please wrap your commit messages to standard 75 wide. > See Documentation/process/submitting-patches.rst. > > > > > Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 +++++++++ > > drivers/gpu/drm/i915/gt/intel_reset.c | 12 ++++++++++-- > > drivers/gpu/drm/i915/gt/intel_reset.h | 1 + > > 3 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > index a69df5e9e77a..668e7ba5b254 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > @@ -2806,6 +2806,15 @@ static void enable_error_interrupt(struct intel_engine_cs *engine) > > drm_err(&engine->i915->drm, > > "engine '%s' resumed still in error: %08x\n", > > engine->name, status); > > + if (engine->reset_domain) { > > + struct intel_engine_cs *nengine; > > + enum intel_engine_id id; > > + > > + for_each_engine(nengine, engine->gt, id) > > + if (nengine->reset_domain == > > + engine->reset_domain) > > + reset_prepare_engine(nengine); > > + } > > __intel_gt_reset(engine->gt, engine->mask); > > } > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > > index 63199f0550e6..454d6ab1d9f4 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > > @@ -705,7 +705,7 @@ int intel_reset_guc(struct intel_gt *gt) > > * Ensure irq handler finishes, and not run again. > > * Also return the active request so that we only search for it once. > > */ > > -static void reset_prepare_engine(struct intel_engine_cs *engine) > > +void reset_prepare_engine(struct intel_engine_cs *engine) > > { > > /* > > * During the reset sequence, we must prevent the engine from > > @@ -1167,7 +1167,15 @@ int __intel_engine_reset_bh(struct intel_engine_cs *engine, const char *msg) > > if (!intel_engine_pm_get_if_awake(engine)) > > return 0; > > - reset_prepare_engine(engine); > > + if (engine->reset_domain) { > > Can it be zero? > > > + struct intel_engine_cs *nengine; > > + enum intel_engine_id id; > > + > > + for_each_engine(nengine, gt, id) > > + if (nengine->reset_domain == > > + engine->reset_domain) > > + reset_prepare_engine(nengine); > > Having glanced over the discussion about the workaround you are trying to > implement a few times, this is what I think. > > First of all I think you are definitely missing the engine resume side of > things. Consider this entry point: > > execlists_submission_tasklet > execlists_reset > intel_engine_reset > __intel_engine_reset_bh > > AFAICT you can halt more than one engine but you will not resume them all. > What I mean here is that __intel_engine_reset, intel_engine_resume, > reset_finish_engine and even the engine pm management end up being called > for only one engine. Also absence of locking via I915_RESET_ENGINE in gt > reset flags. > > Secondly, the question on whether it is acceptable to corrupt the state for > the other engine seems not to have a 100% clear answer. Can this be > confirmed? Because in the ideal world you would really need to preempt to > idle the other engines from the engine group and only then would be able to > proceed. we shouldn't do the reset without checking if it is idle or preempting to idle. and handle the FORCE_WAKE case as well... > > If that is considered a problem for later, with the first step being adding > of a simpler workaround to prevent a more serious lockup, then it may be > acceptable with some tweaks. > > I suspect there isn't a proper IGT for this otherwise you would have noticed > the failure to resume the coupled engines? So I think next step is to write > that IGT and then make sure code is robust. > > Sufficient testing will probably drive the implementation. > > You may for instance need to lock all engines for reset starting from > execlists_reset() and you may end up uncovering locking/ordering challenges > as you go. and everything else that Tvrtko said... we cannot go with this as is without ensuring that we have a good flow with the scheduler. > > Regards, > > Tvrtko > > > + } > > if (msg) > > drm_notice(&engine->i915->drm, > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.h b/drivers/gpu/drm/i915/gt/intel_reset.h > > index adc734e67387..7abd5d49f0e5 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_reset.h > > +++ b/drivers/gpu/drm/i915/gt/intel_reset.h > > @@ -28,6 +28,7 @@ void intel_gt_handle_error(struct intel_gt *gt, > > const char *fmt, ...); > > #define I915_ERROR_CAPTURE BIT(0) > > +void reset_prepare_engine(struct intel_engine_cs *engine); > > void intel_gt_reset(struct intel_gt *gt, > > intel_engine_mask_t stalled_mask, > > const char *reason); > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-11 23:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-09 12:01 [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain Tejas Upadhyay 2021-12-10 0:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork 2021-12-10 1:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-12-10 11:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-12-16 9:52 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2022-02-11 23:00 ` Rodrigo Vivi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.