All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] io_uring: remove duplicate cqe skip check
@ 2022-06-13 11:22 Hao Xu
  2022-06-13 21:23 ` Jens Axboe
  2022-06-14 17:02 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Hao Xu @ 2022-06-13 11:22 UTC (permalink / raw)
  To: io-uring; +Cc: Jens Axboe, Pavel Begunkov

From: Hao Xu <howeyxu@tencent.com>

Remove duplicate cqe skip check in __io_fill_cqe32_req()

Signed-off-by: Hao Xu <howeyxu@tencent.com>
---
 io_uring/io_uring.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 1572ebe3cff1..6a94d1682aaf 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1194,8 +1194,6 @@ static inline void __io_fill_cqe32_req(struct io_kiocb *req, u64 extra1,
 
 	if (WARN_ON_ONCE(!(ctx->flags & IORING_SETUP_CQE32)))
 		return;
-	if (req->flags & REQ_F_CQE_SKIP)
-		return;
 
 	trace_io_uring_complete(ctx, req, req->cqe.user_data, req->cqe.res,
 				req->cqe.flags, extra1, extra2);

base-commit: d8271bf021438f468dab3cd84fe5279b5bbcead8
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] io_uring: remove duplicate cqe skip check
  2022-06-13 11:22 [PATCH] io_uring: remove duplicate cqe skip check Hao Xu
@ 2022-06-13 21:23 ` Jens Axboe
  2022-06-14 17:02 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-06-13 21:23 UTC (permalink / raw)
  To: io-uring, hao.xu; +Cc: asml.silence

On Mon, 13 Jun 2022 19:22:31 +0800, Hao Xu wrote:
> From: Hao Xu <howeyxu@tencent.com>
> 
> Remove duplicate cqe skip check in __io_fill_cqe32_req()
> 
> 

Applied, thanks!

[1/1] io_uring: remove duplicate cqe skip check
      commit: 5703449632a7f565d71ebbf5393b284074939814

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] io_uring: remove duplicate cqe skip check
  2022-06-13 11:22 [PATCH] io_uring: remove duplicate cqe skip check Hao Xu
  2022-06-13 21:23 ` Jens Axboe
@ 2022-06-14 17:02 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-06-14 17:02 UTC (permalink / raw)
  To: io-uring, hao.xu; +Cc: asml.silence

On Mon, 13 Jun 2022 19:22:31 +0800, Hao Xu wrote:
> From: Hao Xu <howeyxu@tencent.com>
> 
> Remove duplicate cqe skip check in __io_fill_cqe32_req()
> 
> 

Applied, thanks!

[1/1] io_uring: remove duplicate cqe skip check
      (no commit info)

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-14 17:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 11:22 [PATCH] io_uring: remove duplicate cqe skip check Hao Xu
2022-06-13 21:23 ` Jens Axboe
2022-06-14 17:02 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.