* [PATCH] staging: wfx: check the return value of devm_kmalloc()
@ 2022-02-16 11:29 xkernel.wang
2022-02-16 11:56 ` Jérôme Pouiller
0 siblings, 1 reply; 2+ messages in thread
From: xkernel.wang @ 2022-02-16 11:29 UTC (permalink / raw)
To: jerome.pouiller, gregkh; +Cc: linux-staging, linux-kernel, Xiaoke Wang
From: Xiaoke Wang <xkernel.wang@foxmail.com>
devm_kmalloc() returns a pointer to allocated memory on success, NULL
on failure. While there is a memory allocation of devm_kmalloc()
without proper check. It is better to check the return value of it to
prevent wrong memory access.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
drivers/staging/wfx/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 4b9fdf9..0ef9225 100644
--- a/drivers/staging/wfx/main.c
+++ b/drivers/staging/wfx/main.c
@@ -294,6 +294,8 @@ struct wfx_dev *wfx_init_common(struct device *dev,
hw->wiphy->n_iface_combinations = ARRAY_SIZE(wfx_iface_combinations);
hw->wiphy->iface_combinations = wfx_iface_combinations;
hw->wiphy->bands[NL80211_BAND_2GHZ] = devm_kmalloc(dev, sizeof(wfx_band_2ghz), GFP_KERNEL);
+ if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
+ return NULL;
// FIXME: also copy wfx_rates and wfx_2ghz_chantable
memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz,
sizeof(wfx_band_2ghz));
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wfx: check the return value of devm_kmalloc()
2022-02-16 11:29 [PATCH] staging: wfx: check the return value of devm_kmalloc() xkernel.wang
@ 2022-02-16 11:56 ` Jérôme Pouiller
0 siblings, 0 replies; 2+ messages in thread
From: Jérôme Pouiller @ 2022-02-16 11:56 UTC (permalink / raw)
To: gregkh, linux-staging, Xiaoke Wang; +Cc: linux-kernel
On Wednesday 16 February 2022 12:29:50 CET xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> devm_kmalloc() returns a pointer to allocated memory on success, NULL
> on failure. While there is a memory allocation of devm_kmalloc()
> without proper check. It is better to check the return value of it to
> prevent wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> drivers/staging/wfx/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index 4b9fdf9..0ef9225 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -294,6 +294,8 @@ struct wfx_dev *wfx_init_common(struct device *dev,
> hw->wiphy->n_iface_combinations = ARRAY_SIZE(wfx_iface_combinations);
> hw->wiphy->iface_combinations = wfx_iface_combinations;
> hw->wiphy->bands[NL80211_BAND_2GHZ] = devm_kmalloc(dev, sizeof(wfx_band_2ghz), GFP_KERNEL);
> + if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
> + return NULL;
> // FIXME: also copy wfx_rates and wfx_2ghz_chantable
> memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz,
> sizeof(wfx_band_2ghz));
> --
>
Good catch! However, I think you should call ieee80211_free_hw(hw)
before to return.
While reviewing your code, I have noticed that all the error handlers
of this function return without calling ieee80211_free_hw(hw).
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-16 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 11:29 [PATCH] staging: wfx: check the return value of devm_kmalloc() xkernel.wang
2022-02-16 11:56 ` Jérôme Pouiller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.