All of lore.kernel.org
 help / color / mirror / Atom feed
* [PULL 0/1] VFIO fix for v7.2-rc0
@ 2022-11-04 16:12 Alex Williamson
  2022-11-04 16:12 ` [PULL 1/1] vfio/migration: Fix wrong enum usage Alex Williamson
  2022-11-06 22:34 ` [PULL 0/1] VFIO fix for v7.2-rc0 Stefan Hajnoczi
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2022-11-04 16:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.williamson

The following changes since commit ece5f8374d0416a339f0c0a9399faa2c42d4ad6f:

  Merge tag 'linux-user-for-7.2-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-11-03 10:55:05 -0400)

are available in the Git repository at:

  https://gitlab.com/alex.williamson/qemu.git tags/vfio-fixes-v7.2-rc0.0

for you to fetch changes up to 2461e752199ca457bf0973b6c8a77dc30585809c:

  vfio/migration: Fix wrong enum usage (2022-11-03 15:57:31 -0600)

----------------------------------------------------------------
VFIO fixes for v7.2-rc0

 * Correct initial migration device state using correct v1
   protocol enum (Avihai Horon)

----------------------------------------------------------------
Avihai Horon (1):
      vfio/migration: Fix wrong enum usage

 hw/vfio/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] vfio/migration: Fix wrong enum usage
  2022-11-04 16:12 [PULL 0/1] VFIO fix for v7.2-rc0 Alex Williamson
@ 2022-11-04 16:12 ` Alex Williamson
  2022-11-06 22:34 ` [PULL 0/1] VFIO fix for v7.2-rc0 Stefan Hajnoczi
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2022-11-04 16:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.williamson

From: Avihai Horon <avihaih@nvidia.com>

vfio_migration_init() initializes VFIOMigration->device_state using enum
of VFIO migration protocol v2. Current implemented protocol is v1 so v1
enum should be used. Fix it.

Fixes: 429c72800654 ("vfio/migration: Fix incorrect initialization value for parameters in VFIOMigration")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Link: https://lore.kernel.org/r/20221016085752.32740-1-avihaih@nvidia.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/migration.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 3de4252111ee..c74453e0b5e0 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -806,7 +806,7 @@ static int vfio_migration_init(VFIODevice *vbasedev,
     }
 
     vbasedev->migration = g_new0(VFIOMigration, 1);
-    vbasedev->migration->device_state = VFIO_DEVICE_STATE_RUNNING;
+    vbasedev->migration->device_state = VFIO_DEVICE_STATE_V1_RUNNING;
     vbasedev->migration->vm_running = runstate_is_running();
 
     ret = vfio_region_setup(obj, vbasedev, &vbasedev->migration->region,




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] VFIO fix for v7.2-rc0
  2022-11-04 16:12 [PULL 0/1] VFIO fix for v7.2-rc0 Alex Williamson
  2022-11-04 16:12 ` [PULL 1/1] vfio/migration: Fix wrong enum usage Alex Williamson
@ 2022-11-06 22:34 ` Stefan Hajnoczi
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2022-11-06 22:34 UTC (permalink / raw)
  To: Alex Williamson; +Cc: qemu-devel, alex.williamson

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-07 14:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 16:12 [PULL 0/1] VFIO fix for v7.2-rc0 Alex Williamson
2022-11-04 16:12 ` [PULL 1/1] vfio/migration: Fix wrong enum usage Alex Williamson
2022-11-06 22:34 ` [PULL 0/1] VFIO fix for v7.2-rc0 Stefan Hajnoczi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.