* [PATCH] Kbuild: fix mismatched if/endif pairs
@ 2018-06-17 10:16 ` Xi Ruoyao
0 siblings, 0 replies; 4+ messages in thread
From: Xi Ruoyao @ 2018-06-17 10:16 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek; +Cc: linux-kbuild, linux-kernel, Xi Ruoyao
In scripts/Makefile.build, there are two mismatched if/endif pairs.
They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
is not set. dmesg complains:
WARNING: WARNING: Bad or missing .orc_unwind table. Disabling unwinder.
This comment moves an endif to match the if/endif pairs.
Signed-off-by: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
---
scripts/Makefile.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 34d9e9ce97c2..16509a038d77 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -239,6 +239,7 @@ cmd_record_mcount = \
"$(CC_FLAGS_FTRACE)" ]; then \
$(sub_cmd_record_mcount) \
fi;
+endif # cc-option(-mrecord-mcount)
endif # CONFIG_FTRACE_MCOUNT_RECORD
ifdef CONFIG_STACK_VALIDATION
@@ -263,7 +264,6 @@ ifneq ($(RETPOLINE_CFLAGS),)
objtool_args += --retpoline
endif
endif
-endif
ifdef CONFIG_MODVERSIONS
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Kbuild: fix mismatched if/endif pairs
@ 2018-06-17 10:16 ` Xi Ruoyao
0 siblings, 0 replies; 4+ messages in thread
From: Xi Ruoyao @ 2018-06-17 10:16 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek; +Cc: linux-kbuild, linux-kernel, Xi Ruoyao
In scripts/Makefile.build, there are two mismatched if/endif pairs.
They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
is not set. dmesg complains:
WARNING: WARNING: Bad or missing .orc_unwind table. Disabling unwinder.
This comment moves an endif to match the if/endif pairs.
Signed-off-by: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
---
scripts/Makefile.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 34d9e9ce97c2..16509a038d77 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -239,6 +239,7 @@ cmd_record_mcount = \
"$(CC_FLAGS_FTRACE)" ]; then \
$(sub_cmd_record_mcount) \
fi;
+endif # cc-option(-mrecord-mcount)
endif # CONFIG_FTRACE_MCOUNT_RECORD
ifdef CONFIG_STACK_VALIDATION
@@ -263,7 +264,6 @@ ifneq ($(RETPOLINE_CFLAGS),)
objtool_args += --retpoline
endif
endif
-endif
ifdef CONFIG_MODVERSIONS
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Kbuild: fix mismatched if/endif pairs
2018-06-17 10:16 ` Xi Ruoyao
(?)
@ 2018-06-20 15:35 ` Josh Poimboeuf
-1 siblings, 0 replies; 4+ messages in thread
From: Josh Poimboeuf @ 2018-06-20 15:35 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: Masahiro Yamada, Michal Marek, linux-kbuild, linux-kernel
On Sun, Jun 17, 2018 at 06:16:07PM +0800, Xi Ruoyao wrote:
> In scripts/Makefile.build, there are two mismatched if/endif pairs.
> They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
> is not set. dmesg complains:
>
> WARNING: WARNING: Bad or missing .orc_unwind table. Disabling unwinder.
>
> This comment moves an endif to match the if/endif pairs.
>
> Signed-off-by: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Kbuild: fix mismatched if/endif pairs
[not found] <18061719212289a3d6de53ebc1ba6c4a188e1b0779da@stu.xidian.edu.cn>
@ 2018-06-17 11:36 ` Xi Ruoyao
0 siblings, 0 replies; 4+ messages in thread
From: Xi Ruoyao @ 2018-06-17 11:36 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek; +Cc: ryxi, linux-kbuild, linux-kernel
On 2018-06-17 18:16 +0800, Xi Ruoyao wrote:
> In scripts/Makefile.build, there are two mismatched if/endif pairs.
> They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
> is not set. dmesg complains:
Duplication of patch 10455267 in patchwork. Sorry for noise :(.
But let's fix this quickly, since the issue breaks ORC unwinder completely
(at least with my configuration).
--
Xi Ruoyao <ryxi@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-20 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-17 10:16 [PATCH] Kbuild: fix mismatched if/endif pairs Xi Ruoyao
2018-06-17 10:16 ` Xi Ruoyao
2018-06-20 15:35 ` Josh Poimboeuf
[not found] <18061719212289a3d6de53ebc1ba6c4a188e1b0779da@stu.xidian.edu.cn>
2018-06-17 11:36 ` Xi Ruoyao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.