All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael Welling" <mwelling@ieee.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Igor Grinberg" <grinberg@compulab.co.il>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Andrew F. Davis" <afd@ti.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Linux OMAP Mailing List" <linux-omap@vger.kernel.org>,
	"Discussions about the Letux Kernel"
	<letux-kernel@openphoenux.org>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values
Date: Sat, 24 Sep 2016 19:51:01 +0200	[thread overview]
Message-ID: <1D1171A5-21D2-4D5D-8182-02CB8DE06564@goldelico.com> (raw)
In-Reply-To: <CAKdAkRS3OhUp=WXtrLxQSJAvtgt24jo2W8Nw_NwR4O=R9jboaA@mail.gmail.com>

Hi Dmitry,

> Am 24.09.2016 um 19:44 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> 
> On Sat, Sep 24, 2016 at 10:07 AM, H. Nikolaus Schaller
> <hns@goldelico.com> wrote:
>> Hi Jonathan,
>> 
>>> Am 24.09.2016 um 18:07 schrieb Jonathan Cameron <jic23@kernel.org>:
>>> 
>>> On 23/09/16 13:41, H. Nikolaus Schaller wrote:
>>>> The tsc2007 chip not only has a resistive touch screen controller but
>>>> also an external AUX adc imput which can be used for an ambient
>>>> light sensor, battery voltage monitoring or any general purpose.
>>>> 
>>>> Additionally it can measure the chip temperature.
>>>> 
>>>> This extension provides an iio interface for these adc channels
>>>> in addition to the raw x, y, z values and the estimated touch
>>>> screen resistance. This can be used for debugging or special
>>>> applications.
>>> I'm unconvinced that exposing the touch related channels is terribly
>>> useful.
>> 
>> Mostly for debugging of if someone wants to do a (better) touch detection

s/of/or/

>> in user space.
> 
> For that we should probably export data as a heat map via V4L2
> interface, similarly to what Nick Dyer did for Synaptics and Atmel
> drivers (albeit their heatmap functions are too slow for real
> processing and only suitable for debug/validation).

Sorry for my ignorance, but what is a heat map?
Does it allow to cat /sys/bus/something the raw values?

And why introduce another interface if we already get the iio that
easily reports such values by just adding more channels and some
lines of code?

BR,
Nikolaus

WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Jonathan Cameron"
	<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
	"Michael Welling" <mwelling-EkmVulN54Sk@public.gmane.org>,
	"Mika Penttilä"
	<mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org>,
	"Javier Martinez Canillas"
	<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	"Igor Grinberg"
	<grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>,
	"Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>,
	"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Linux OMAP Mailing List"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values
Date: Sat, 24 Sep 2016 19:51:01 +0200	[thread overview]
Message-ID: <1D1171A5-21D2-4D5D-8182-02CB8DE06564@goldelico.com> (raw)
In-Reply-To: <CAKdAkRS3OhUp=WXtrLxQSJAvtgt24jo2W8Nw_NwR4O=R9jboaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Dmitry,

> Am 24.09.2016 um 19:44 schrieb Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> 
> On Sat, Sep 24, 2016 at 10:07 AM, H. Nikolaus Schaller
> <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> wrote:
>> Hi Jonathan,
>> 
>>> Am 24.09.2016 um 18:07 schrieb Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
>>> 
>>> On 23/09/16 13:41, H. Nikolaus Schaller wrote:
>>>> The tsc2007 chip not only has a resistive touch screen controller but
>>>> also an external AUX adc imput which can be used for an ambient
>>>> light sensor, battery voltage monitoring or any general purpose.
>>>> 
>>>> Additionally it can measure the chip temperature.
>>>> 
>>>> This extension provides an iio interface for these adc channels
>>>> in addition to the raw x, y, z values and the estimated touch
>>>> screen resistance. This can be used for debugging or special
>>>> applications.
>>> I'm unconvinced that exposing the touch related channels is terribly
>>> useful.
>> 
>> Mostly for debugging of if someone wants to do a (better) touch detection

s/of/or/

>> in user space.
> 
> For that we should probably export data as a heat map via V4L2
> interface, similarly to what Nick Dyer did for Synaptics and Atmel
> drivers (albeit their heatmap functions are too slow for real
> processing and only suitable for debug/validation).

Sorry for my ignorance, but what is a heat map?
Does it allow to cat /sys/bus/something the raw values?

And why introduce another interface if we already get the iio that
easily reports such values by just adding more channels and some
lines of code?

BR,
Nikolaus

  reply	other threads:[~2016-09-24 17:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 12:41 [PATCH v3 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2016-09-23 22:47   ` Rob Herring
2016-09-23 22:47     ` Rob Herring
2016-09-24  0:31     ` Sebastian Reichel
2016-09-24  5:55       ` H. Nikolaus Schaller
2016-09-30 14:16         ` Sebastian Reichel
2016-09-30 14:16           ` Sebastian Reichel
2016-09-30 14:40           ` H. Nikolaus Schaller
2016-09-30 14:40             ` H. Nikolaus Schaller
2016-10-17 13:57             ` H. Nikolaus Schaller
2016-10-17 13:57               ` H. Nikolaus Schaller
2016-09-24  5:28     ` H. Nikolaus Schaller
2016-09-24  5:28       ` H. Nikolaus Schaller
2016-09-24  5:28       ` H. Nikolaus Schaller
2016-09-30 16:23   ` [Letux-kernel] " Christ van Willegen
2016-09-30 16:23     ` Christ van Willegen
2016-09-30 16:36     ` H. Nikolaus Schaller
2016-09-30 16:36       ` H. Nikolaus Schaller
2016-09-30 16:36       ` H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 2/8] drivers:input:tsc2007: send pendown and penup only once like ads7846(+tsc2046) driver does H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values H. Nikolaus Schaller
2016-09-23 12:41   ` H. Nikolaus Schaller
2016-09-24 16:07   ` Jonathan Cameron
2016-09-24 16:07     ` Jonathan Cameron
2016-09-24 17:07     ` H. Nikolaus Schaller
2016-09-24 17:07       ` H. Nikolaus Schaller
2016-09-24 17:26       ` Jonathan Cameron
2016-09-24 17:26         ` Jonathan Cameron
2016-09-24 17:42         ` H. Nikolaus Schaller
2016-09-24 17:42           ` H. Nikolaus Schaller
2016-09-24 17:44       ` Dmitry Torokhov
2016-09-24 17:44         ` Dmitry Torokhov
2016-09-24 17:51         ` H. Nikolaus Schaller [this message]
2016-09-24 17:51           ` H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 4/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 5/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-09-23 12:41   ` H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 6/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-09-23 22:50   ` Rob Herring
2016-09-23 12:41 ` [PATCH v3 7/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2016-09-23 12:41 ` [PATCH v3 8/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1D1171A5-21D2-4D5D-8182-02CB8DE06564@goldelico.com \
    --to=hns@goldelico.com \
    --cc=afd@ti.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grinberg@compulab.co.il \
    --cc=javier@osg.samsung.com \
    --cc=jic23@kernel.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mika.penttila@nextfour.com \
    --cc=mwelling@ieee.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.