[Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd

[Arnout Vandecappelle <arnout@mind.be>]

On 28/05/2021 17:48, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> 
> Hi,
> 
>  >  I'm thinking (adding Peter in Cc) that we should maybe do better on the release
>  > notes. Yocto (ever our example) puts a (now very long) "Migrating to a Newer
>  > Yocto Project Release" [1] directly in their documentation with a description of
>  > every release. We do have an upgrading section, but maybe we should put any
>  > caveats directly in there instead of trying to compile them at release time in
>  > the CHANGES file.
> 
> Yes, I agree. We already have a section in the manual for it:
> 
> https://github.com/nginxinc/docker-nginx/blob/master/Dockerfile-debian.template#L106

 I think you meant

https://buildroot.org/downloads/manual/manual.html#migrating-from-ol-versions

:-)


> But very little content :/ Patches accepted!

 What I meant is: we should require an update of that section whenever there's a
potentially breaking change. From 2021.05-rc1, for example:

        FORTIFY_SOURCE, PIC/PIE, RELRO and SSP security hardening
        options are now enabled by default.

The change of the default could have updated that section in the same patch.


 Regards,
 Arnout