[Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd

[Arnout Vandecappelle <arnout@mind.be>]

On 28/05/2021 13:39, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2021-05-27 22:49 +0200, Arnout Vandecappelle spake thusly:
>> On 26/05/2021 22:48, Yann E. MORIN wrote:
>>> On 2021-05-21 09:41 -0500, Matthew Weber via buildroot spake thusly:
>>>> Upstream bug: (deferred fix)
>>>> https://trac.nginx.org/nginx/ticket/1897?cversion=0&cnum_hist=2
>>> So, basically, upstream refused to fix that bug [...]
> [--SNIP--]
>>> If so, maybe we could then tweak the unit to make use of it, instead of
>>> the sleep workaround?
>>  I think there was one useful comment on the Ubuntu bug [1]:
>>>>>
>> As far as I can tell, this daemonization is not needed for the systemd service
>> use-case. The service should be Type=simple, and 'daemon off'. The standard file
>> handles get redirected by systemd anyway, and non-stop upgrade cannot be used in
>> this case either. (See:
>> http://nginx.org/en/docs/faq/daemon_master_process_off.html )
>> <<<
>>  So I rather think we should go for that solution.
> 
> Indeed, that seems an even better solution, and probably an actual fix.

 Unfortunately, not so easy in practice. "daemon off" means a change in the
configuration file, which is typically going to be modified by the user. Also,
it's something that comes from nginx itself, so we'd have to patch the one that
gets installed by nginx (and that one will probably be overwritten anyway in an
overlay).

 Also, daemon off should only be done in systemd; sysvinit still wants nginx to
daemonize! So it's conditional patching, and we don't like that... Well, I guess
it can be done post-install with a sed script that inserts an aditional line at
the beginning of the file.


 Regards,
 Arnout