[PATCH] can: add explicit copyright to header can/netlink.h

[PATCH] can: add explicit copyright to header can/netlink.h

[Marc Kleine-Budde]

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

This file is copied to the source code of user space applications (in
this case can-utils) and so it makes sense to mention explicitly its
copyright. I added the terms of C code that was introduced in the same
commit as this header.

Cc: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Hello Wolfgang,

this is the remaining hunk from Uwe's patch that has not been Acked. Continuing
with Uwe's words (adopted):

I think it is necessary to get the Ack of the people mentioned in
the Cc: commit footers. @Wolfgang: I added a statement

    The provided data structures and external interfaces from this code
    are not restricted to be used by software with a GPL compatible license.

similar to the other can headers. Does that suit you?

Best regards
Uwe

 include/uapi/linux/can/netlink.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netlink.h
index 14966dd..8bbb885 100644
--- a/include/uapi/linux/can/netlink.h
+++ b/include/uapi/linux/can/netlink.h
@@ -5,6 +5,17 @@
  *
  * Copyright (c) 2009 Wolfgang Grandegger <wg@grandegger.com>
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the version 2 of the GNU General Public License
+ * as published by the Free Software Foundation
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * The provided data structures and external interfaces from this code
+ * are not restricted to be used by software with a GPL compatible license.
  */
 
 #ifndef CAN_NETLINK_H
-- 
1.8.4.rc3

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

Hi Marc and Uwe,

On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde <mkl@pengutronix.de>
wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> This file is copied to the source code of user space applications (in
> this case can-utils) and so it makes sense to mention explicitly its
> copyright. I added the terms of C code that was introduced in the same
> commit as this header.
> 
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Hello Wolfgang,
> 
> this is the remaining hunk from Uwe's patch that has not been Acked.
> Continuing
> with Uwe's words (adopted):
> 
> I think it is necessary to get the Ack of the people mentioned in
> the Cc: commit footers. @Wolfgang: I added a statement
> 
>     The provided data structures and external interfaces from this code
>     are not restricted to be used by software with a GPL compatible
>     license.
> 
> similar to the other can headers. Does that suit you?

Is this the common phrase other public header files use as well?
What's the motivation for that addition. Likely I might
have missed some related discussion. 

Thanks,

Wolfgang.

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Uwe Kleine-König]

Hello Wolfgang,

On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote:
> Hi Marc and Uwe,
> 
> On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde <mkl@pengutronix.de>
> wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > This file is copied to the source code of user space applications (in
> > this case can-utils) and so it makes sense to mention explicitly its
> > copyright. I added the terms of C code that was introduced in the same
> > commit as this header.
> > 
> > Cc: Wolfgang Grandegger <wg@grandegger.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > ---
> > Hello Wolfgang,
> > 
> > this is the remaining hunk from Uwe's patch that has not been Acked.
> > Continuing
> > with Uwe's words (adopted):
> > 
> > I think it is necessary to get the Ack of the people mentioned in
> > the Cc: commit footers. @Wolfgang: I added a statement
> > 
> >     The provided data structures and external interfaces from this code
> >     are not restricted to be used by software with a GPL compatible
> >     license.
> > 
> > similar to the other can headers. Does that suit you?
> 
> Is this the common phrase other public header files use as well?
> What's the motivation for that addition. Likely I might
> have missed some related discussion. 
This is what the headers by Volkswagen are using, but it's only a
suggestion. So it's up to you.

Best regards
Uwe
> 
> 
> 
> Thanks,
> 
> 
> 
> Wolfgang.
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On Fri, 6 Sep 2013 21:37:44 +0200, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Wolfgang,
> 
> On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote:
>> Hi Marc and Uwe,
>> 
>> On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde
>> <mkl@pengutronix.de>
>> wrote:
>> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> > 
>> > This file is copied to the source code of user space applications (in
>> > this case can-utils) and so it makes sense to mention explicitly its
>> > copyright. I added the terms of C code that was introduced in the
same
>> > commit as this header.
>> > 
>> > Cc: Wolfgang Grandegger <wg@grandegger.com>
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> > ---
>> > Hello Wolfgang,
>> > 
>> > this is the remaining hunk from Uwe's patch that has not been Acked.
>> > Continuing
>> > with Uwe's words (adopted):
>> > 
>> > I think it is necessary to get the Ack of the people mentioned in
>> > the Cc: commit footers. @Wolfgang: I added a statement
>> > 
>> >     The provided data structures and external interfaces from this
code
>> >     are not restricted to be used by software with a GPL compatible
>> >     license.
>> > 
>> > similar to the other can headers. Does that suit you?
>> 
>> Is this the common phrase other public header files use as well?
>> What's the motivation for that addition. Likely I might
>> have missed some related discussion. 
> This is what the headers by Volkswagen are using, but it's only a
> suggestion. So it's up to you.

Which headers. In net-next's "include/uapi/linux/can.h" I read:

/*
 * linux/can.h
 *
 * Definitions for CAN network layer (socket addr / CAN frame / CAN
filter)
 *
 * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
 *          Urs Thuermann   <urs.thuermann@volkswagen.de>
 * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
 * All rights reserved.
 *
 */

Wolfgang.

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Uwe Kleine-König]

Hello Wolfgang,

On Fri, Sep 06, 2013 at 10:35:54PM +0200, Wolfgang Grandegger wrote:
> On Fri, 6 Sep 2013 21:37:44 +0200, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Hello Wolfgang,
> > 
> > On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote:
> >> Hi Marc and Uwe,
> >> 
> >> On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde
> >> <mkl@pengutronix.de>
> >> wrote:
> >> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> > 
> >> > This file is copied to the source code of user space applications (in
> >> > this case can-utils) and so it makes sense to mention explicitly its
> >> > copyright. I added the terms of C code that was introduced in the
> same
> >> > commit as this header.
> >> > 
> >> > Cc: Wolfgang Grandegger <wg@grandegger.com>
> >> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >> > ---
> >> > Hello Wolfgang,
> >> > 
> >> > this is the remaining hunk from Uwe's patch that has not been Acked.
> >> > Continuing
> >> > with Uwe's words (adopted):
> >> > 
> >> > I think it is necessary to get the Ack of the people mentioned in
> >> > the Cc: commit footers. @Wolfgang: I added a statement
> >> > 
> >> >     The provided data structures and external interfaces from this
> code
> >> >     are not restricted to be used by software with a GPL compatible
> >> >     license.
> >> > 
> 
> >> > similar to the other can headers. Does that suit you?
> 
> >> 
> 
> >> Is this the common phrase other public header files use as well?
> 
> >> What's the motivation for that addition. Likely I might
> 
> >> have missed some related discussion. 
> 
> > This is what the headers by Volkswagen are using, but it's only a
> 
> > suggestion. So it's up to you.
> 
> 
> 
> Which headers. In net-next's "include/uapi/linux/can.h" I read:
> 
> 
> 
> /*
>  * linux/can.h
>  *
>  * Definitions for CAN network layer (socket addr / CAN frame / CAN filter)
>  *
>  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
>  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
>  * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
>  * All rights reserved.
>  *
>  */
Yeah, in net-next the license is still missing, see
http://thread.gmane.org/gmane.linux.can/3757 for my suggestion. The
sentence is taken from the corresponding .c files.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On Fri, 6 Sep 2013 22:45:03 +0200, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Wolfgang,
> 
> On Fri, Sep 06, 2013 at 10:35:54PM +0200, Wolfgang Grandegger wrote:
>> On Fri, 6 Sep 2013 21:37:44 +0200, Uwe Kleine-König
>> <u.kleine-koenig@pengutronix.de> wrote:
>> > Hello Wolfgang,
>> > 
>> > On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote:
>> >> Hi Marc and Uwe,
>> >> 
>> >> On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde
>> >> <mkl@pengutronix.de>
>> >> wrote:
>> >> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> >> > 
>> >> > This file is copied to the source code of user space applications
>> >> > (in
>> >> > this case can-utils) and so it makes sense to mention explicitly
its
>> >> > copyright. I added the terms of C code that was introduced in the
>> same
>> >> > commit as this header.
>> >> > 
>> >> > Cc: Wolfgang Grandegger <wg@grandegger.com>
>> >> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> >> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> >> > ---
>> >> > Hello Wolfgang,
>> >> > 
>> >> > this is the remaining hunk from Uwe's patch that has not been
Acked.
>> >> > Continuing
>> >> > with Uwe's words (adopted):
>> >> > 
>> >> > I think it is necessary to get the Ack of the people mentioned in
>> >> > the Cc: commit footers. @Wolfgang: I added a statement
>> >> > 
>> >> >     The provided data structures and external interfaces from this
>> code
>> >> >     are not restricted to be used by software with a GPL
compatible
>> >> >     license.
>> >> > 
>> 
>> >> > similar to the other can headers. Does that suit you?
>> 
>> >> 
>> 
>> >> Is this the common phrase other public header files use as well?
>> 
>> >> What's the motivation for that addition. Likely I might
>> 
>> >> have missed some related discussion. 
>> 
>> > This is what the headers by Volkswagen are using, but it's only a
>> 
>> > suggestion. So it's up to you.
>> 
>> 
>> 
>> Which headers. In net-next's "include/uapi/linux/can.h" I read:
>> 
>> 
>> 
>> /*
>>  * linux/can.h
>>  *
>>  * Definitions for CAN network layer (socket addr / CAN frame / CAN
>>  filter)
>>  *
>>  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
>>  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
>>  * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
>>  * All rights reserved.
>>  *
>>  */
> Yeah, in net-next the license is still missing, see
> http://thread.gmane.org/gmane.linux.can/3757 for my suggestion. The
> sentence is taken from the corresponding .c files.

Ah, you mean your modifications. I have browsed other uapi header files
and have not found similar statements. Well, I do not see a need for
such an addition. The GPL v2 text is fine, though, because I published
the device interface under that license.

Thanks,

Wolfgang.

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Oliver Hartkopp]

On 06.09.2013 21:37, Uwe Kleine-König wrote:

>>> I think it is necessary to get the Ack of the people mentioned in
>>> the Cc: commit footers. @Wolfgang: I added a statement
>>>
>>>     The provided data structures and external interfaces from this code
>>>     are not restricted to be used by software with a GPL compatible
>>>     license.
>>>
>>> similar to the other can headers. Does that suit you?
>>
>> Is this the common phrase other public header files use as well?
>> What's the motivation for that addition. Likely I might
>> have missed some related discussion. 
> This is what the headers by Volkswagen are using, but it's only a
> suggestion. So it's up to you.
> 

Yep.

To make clear that the CAN data structures should not be limited to be used in
GPL code, this sentence has been added.

E.g. to allow to implement a similar programming API for BSD, QNX or whatever
which are obviously not GPL ...

Don't know if this it suitable for the netlink stuff anyway.

Best regards,
Oliver

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

On 09/07/2013 12:23 PM, Oliver Hartkopp wrote:
> On 06.09.2013 21:37, Uwe Kleine-König wrote:
> 
>>>> I think it is necessary to get the Ack of the people mentioned in
>>>> the Cc: commit footers. @Wolfgang: I added a statement
>>>>
>>>>     The provided data structures and external interfaces from this code
>>>>     are not restricted to be used by software with a GPL compatible
>>>>     license.
>>>>
>>>> similar to the other can headers. Does that suit you?
>>>
>>> Is this the common phrase other public header files use as well?
>>> What's the motivation for that addition. Likely I might
>>> have missed some related discussion. 
>> This is what the headers by Volkswagen are using, but it's only a
>> suggestion. So it's up to you.
>>
> 
> Yep.
> 
> To make clear that the CAN data structures should not be limited to be used in
> GPL code, this sentence has been added.
> 
> E.g. to allow to implement a similar programming API for BSD, QNX or whatever
> which are obviously not GPL ...
> 
> Don't know if this it suitable for the netlink stuff anyway.

The usage of netlink.h in a closed source app might be a nother usecase.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On Sat, 07 Sep 2013 12:25:36 +0200, Marc Kleine-Budde <mkl@pengutronix.de>
wrote:
> On 09/07/2013 12:23 PM, Oliver Hartkopp wrote:
>> On 06.09.2013 21:37, Uwe Kleine-König wrote:
>> 
>>>>> I think it is necessary to get the Ack of the people mentioned in
>>>>> the Cc: commit footers. @Wolfgang: I added a statement
>>>>>
>>>>>     The provided data structures and external interfaces from this
>>>>>     code
>>>>>     are not restricted to be used by software with a GPL compatible
>>>>>     license.
>>>>>
>>>>> similar to the other can headers. Does that suit you?
>>>>
>>>> Is this the common phrase other public header files use as well?
>>>> What's the motivation for that addition. Likely I might
>>>> have missed some related discussion. 
>>> This is what the headers by Volkswagen are using, but it's only a
>>> suggestion. So it's up to you.
>>>
>> 
>> Yep.
>> 
>> To make clear that the CAN data structures should not be limited to be
>> used in
>> GPL code, this sentence has been added.
>> 
>> E.g. to allow to implement a similar programming API for BSD, QNX or
>> whatever
>> which are obviously not GPL ...
>> 
>> Don't know if this it suitable for the netlink stuff anyway.
> 
> The usage of netlink.h in a closed source app might be a nother usecase.

The intention is clear. But many other uapi include files are used in
closed source as well without such a clause.

Are you/we sure that this addition is even compatible with the
GPL (v2) license. GPL does usually not allow exceptions.

Wolfgang.

[PATCH] uapi/linux/can: add explicit copyrights to can's netlink header

[Uwe Kleine-König]

This file is copied to the source code of user space applications (in
this case can-utils) and so it makes sense to mention explicitly their
copyright.

Cc: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

compared to the previous post the headers covered by VM copyright were
dropped as Marc already fixed them and the GPL exception was skipped as
this is what Wolfgang seems to prefer.

Best regards
Uwe

 include/uapi/linux/can/netlink.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netlink.h
index 14966dd..df944ed 100644
--- a/include/uapi/linux/can/netlink.h
+++ b/include/uapi/linux/can/netlink.h
@@ -5,6 +5,14 @@
  *
  * Copyright (c) 2009 Wolfgang Grandegger <wg@grandegger.com>
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the version 2 of the GNU General Public License
+ * as published by the Free Software Foundation
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
  */
 
 #ifndef CAN_NETLINK_H
-- 
1.8.4.rc3

Re: [PATCH] uapi/linux/can: add explicit copyrights to can's netlink header

[Wolfgang Grandegger]

On Sat,  7 Sep 2013 21:34:38 +0200, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> This file is copied to the source code of user space applications (in
> this case can-utils) and so it makes sense to mention explicitly their
> copyright.
> 
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> compared to the previous post the headers covered by VM copyright were
> dropped as Marc already fixed them and the GPL exception was skipped as
> this is what Wolfgang seems to prefer.
> 
> Best regards
> Uwe
> 
>  include/uapi/linux/can/netlink.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/uapi/linux/can/netlink.h
> b/include/uapi/linux/can/netlink.h
> index 14966dd..df944ed 100644
> --- a/include/uapi/linux/can/netlink.h
> +++ b/include/uapi/linux/can/netlink.h
> @@ -5,6 +5,14 @@
>   *
>   * Copyright (c) 2009 Wolfgang Grandegger <wg@grandegger.com>
>   *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the version 2 of the GNU General Public
License
> + * as published by the Free Software Foundation
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
>   */
>  
>  #ifndef CAN_NETLINK_H

Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Thanks.

Wolfgang.

Re: [PATCH] uapi/linux/can: add explicit copyrights to can's netlink header

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On 09/07/2013 09:57 PM, Wolfgang Grandegger wrote:
[...]
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Tnx,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Oliver Hartkopp]

On 07.09.2013 21:15, Wolfgang Grandegger wrote:
> On Sat, 07 Sep 2013 12:25:36 +0200, Marc Kleine-Budde <mkl@pengutronix.de>


>> The usage of netlink.h in a closed source app might be a nother usecase.
> 
> 
> 
> The intention is clear. But many other uapi include files are used in
> 
> closed source as well without such a clause.
> 
> 
> 
> Are you/we sure that this addition is even compatible with the
> 
> GPL (v2) license. GPL does usually not allow exceptions.

As original author you may chose the license as you like.

That's why our license header intends to be like a BSD license and when used
inside the Linux kernel the GPL comes into action:

 * Alternatively, provided that this notice is retained in full, this
 * software may be distributed under the terms of the GNU General
 * Public License ("GPL") version 2, in which case the provisions of the
 * GPL apply INSTEAD OF those given above.

And then - just to make it really sure - this additional sentence is written:

 * The provided data structures and external interfaces from this code
 * are not restricted to be used by modules with a GPL compatible license.

Originally there was (intentionally) no license information in the CAN header
files - as there were _many_ header files in the Linux kernel that did not
contain any license information.

When Debian needs this information to be sure about the GPL status duplicating
that license information from e.g. net/can/bcm.c is fine.

Best regards,
Oliver

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:
> On 07.09.2013 21:15, Wolfgang Grandegger wrote:
>> On Sat, 07 Sep 2013 12:25:36 +0200, Marc Kleine-Budde <mkl@pengutronix.de>
> 
> 
>>> The usage of netlink.h in a closed source app might be a nother usecase.
>>
>>
>>
>> The intention is clear. But many other uapi include files are used in
>>
>> closed source as well without such a clause.
>>
>>
>>
>> Are you/we sure that this addition is even compatible with the
>>
>> GPL (v2) license. GPL does usually not allow exceptions.
> 
> As original author you may chose the license as you like.
> 
> That's why our license header intends to be like a BSD license and when used
> inside the Linux kernel the GPL comes into action:
> 
>  * Alternatively, provided that this notice is retained in full, this
>  * software may be distributed under the terms of the GNU General
>  * Public License ("GPL") version 2, in which case the provisions of the
>  * GPL apply INSTEAD OF those given above.
> 
> And then - just to make it really sure - this additional sentence is written:
> 
>  * The provided data structures and external interfaces from this code
>  * are not restricted to be used by modules with a GPL compatible license.

The question is if this sentence is a legal addition to the GPL license.
I personally doubt but I'm not a lawyer.

Wolfgang.

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Oliver Hartkopp]

On 08.09.2013 21:46, Wolfgang Grandegger wrote:
> On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:


>>
>>  * The provided data structures and external interfaces from this code
>>  * are not restricted to be used by modules with a GPL compatible license.
> 
> The question is if this sentence is a legal addition to the GPL license.
> I personally doubt but I'm not a lawyer.

This is for the guys that like to put EXPORT_SYMBOL_GPL() anywhere to NOT do
this here ;-)

BR,
Oliver

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On 09/09/2013 08:06 PM, Oliver Hartkopp wrote:
> On 08.09.2013 21:46, Wolfgang Grandegger wrote:
>> On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:
> 
> 
>>>
>>>  * The provided data structures and external interfaces from this code
>>>  * are not restricted to be used by modules with a GPL compatible license.
>>
>> The question is if this sentence is a legal addition to the GPL license.
>> I personally doubt but I'm not a lawyer.
> 
> This is for the guys that like to put EXPORT_SYMBOL_GPL() anywhere to NOT do
> this here ;-)

But this is something different. EXPORT_SYMBOLS is for kernel modules
which are covered by the GPL license, even with the Volkswagen
license... or have I missed something. My favorite would be the GPL v3
license ;).

Wolfgang.

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Oliver Hartkopp]

On 09.09.2013 22:01, Wolfgang Grandegger wrote:
> On 09/09/2013 08:06 PM, Oliver Hartkopp wrote:
>> On 08.09.2013 21:46, Wolfgang Grandegger wrote:
>>> On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:
>>
>>
>>>>
>>>>  * The provided data structures and external interfaces from this code
>>>>  * are not restricted to be used by modules with a GPL compatible license.
>>>
>>> The question is if this sentence is a legal addition to the GPL license.
>>> I personally doubt but I'm not a lawyer.
>>
>> This is for the guys that like to put EXPORT_SYMBOL_GPL() anywhere to NOT do
>> this here ;-)
> 
> But this is something different. EXPORT_SYMBOLS is for kernel modules
> which are covered by the GPL license, even with the Volkswagen
> license... or have I missed something. My favorite would be the GPL v3
> license ;).

Well yes. The text was originally retrieved from the kernel module.

I'm still in doubt if it's a good idea to have the GPL license for the header
files. It makes more problems than clarifications.

IMHO the headers are no "program" in the terms of the GPL.

If you go into linux/include/uapi/linux and say 'head *.h' you will not see
that much GPL licensing as you would imagine.

E.g. look at the wimax.h header file from Intel. Nice text but no GPL.

Looks like that everyone is doing his own stuff here ...

BR,
Oliver

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Uwe Kleine-König]

Hello Wolfgang,

On Sun, Sep 08, 2013 at 09:46:56PM +0200, Wolfgang Grandegger wrote:
> On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:
> > And then - just to make it really sure - this additional sentence is written:
> > 
> >  * The provided data structures and external interfaces from this code
> >  * are not restricted to be used by modules with a GPL compatible license.
> 
> The question is if this sentence is a legal addition to the GPL license.
> I personally doubt but I'm not a lawyer.
INAL, too, but I think it's at least quite usual, even Linux' COPYING
does something like that:

   NOTE! This copyright does *not* cover user programs that use kernel
 services by normal system calls - this is merely considered normal use
 of the kernel, and does *not* fall under the heading of "derived work".

One of the main issues of the GPL is the definition of "derived work".
There are discussions about kernel modules, extensions to userspace
programs, output generated by a program etc. pp. So I think it's fine to
explicitly note if you consider a certain usage of your code to be a
derived work or not. So I'd say such a statement is not a restriction
and so should be fine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] can: add explicit copyright to header can/netlink.h

[Wolfgang Grandegger]

On Tue, 10 Sep 2013 09:59:07 +0200, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Wolfgang,
> 
> On Sun, Sep 08, 2013 at 09:46:56PM +0200, Wolfgang Grandegger wrote:
>> On 09/08/2013 09:09 PM, Oliver Hartkopp wrote:
>> > And then - just to make it really sure - this additional sentence is
>> > written:
>> > 
>> >  * The provided data structures and external interfaces from this
code
>> >  * are not restricted to be used by modules with a GPL compatible
>> >  license.
>> 
>> The question is if this sentence is a legal addition to the GPL
license.
>> I personally doubt but I'm not a lawyer.
> INAL, too, but I think it's at least quite usual, even Linux' COPYING
> does something like that:
> 
>    NOTE! This copyright does *not* cover user programs that use kernel
>  services by normal system calls - this is merely considered normal use
>  of the kernel, and does *not* fall under the heading of "derived work".
> 
> One of the main issues of the GPL is the definition of "derived work".
> There are discussions about kernel modules, extensions to userspace
> programs, output generated by a program etc. pp. So I think it's fine to
> explicitly note if you consider a certain usage of your code to be a
> derived work or not. So I'd say such a statement is not a restriction
> and so should be fine.

The GPL is clear in that respect and therefore I do not see any reason to
add somehow arbitrary statements. Just my 0.02 EUR.

Wolfgang.

> Best regards
> Uwe