From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Anchal Agarwal <anchalag@amazon.com>, Stefano Stabellini <sstabellini@kernel.org> Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, jgross@suse.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, kamatam@amazon.com, konrad.wilk@oracle.com, roger.pau@citrix.com, axboe@kernel.dk, davem@davemloft.net, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, peterz@infradead.org, eduval@amazon.com, sblbir@amazon.com, xen-devel@lists.xenproject.org, vkuznets@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@kernel.crashing.org Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Date: Wed, 22 Jul 2020 18:45:47 -0400 [thread overview] Message-ID: <1e1f947e-ae16-33f4-435b-13d69c829029@oracle.com> (raw) In-Reply-To: <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> On 7/22/20 2:02 PM, Anchal Agarwal wrote: > On Tue, Jul 21, 2020 at 05:18:34PM -0700, Stefano Stabellini wrote: >> >> >>> If you are not sure what the effects are (or sure that it won't work) on >>> ARM then I'd add IS_ENABLED(CONFIG_X86) check, i.e. >>> >>> >>> if (!IS_ENABLED(CONFIG_X86) || !xen_hvm_domain()) >>> return -ENODEV; >> That is a good principle to have and thanks for suggesting it. However, >> in this specific case there is nothing in this patch that doesn't work >> on ARM. From an ARM perspective I think we should enable it and >> &xen_pm_notifier_block should be registered. >> > This question is for Boris, I think you we decided to get rid of the notifier > in V3 as all we need to check is SHUTDOWN_SUSPEND state which sounds plausible > to me. So this check may go away. It may still be needed for sycore_ops > callbacks registration. If this check is going away then I guess there is nothing to do here. My concern isn't about this particular notifier but rather whether this feature may affect existing functionality (ARM and PVH dom0). If Stefano feels this should be fine for ARM then so be it. -boris >> Given that all guests are HVM guests on ARM, it should work fine as is. >> >> >> I gave a quick look at the rest of the series and everything looks fine >> to me from an ARM perspective. I cannot imaging that the new freeze, >> thaw, and restore callbacks for net and block are going to cause any >> trouble on ARM. The two main x86-specific functions are >> xen_syscore_suspend/resume and they look trivial to implement on ARM (in >> the sense that they are likely going to look exactly the same.) >> > Yes but for now since things are not tested I will put this > !IS_ENABLED(CONFIG_X86) on syscore_ops calls registration part just to be safe > and not break anything. >> One question for Anchal: what's going to happen if you trigger a >> hibernation, you have the new callbacks, but you are missing >> xen_syscore_suspend/resume? >> >> Is it any worse than not having the new freeze, thaw and restore >> callbacks at all and try to do a hibernation? > If callbacks are not there, I don't expect hibernation to work correctly. > These callbacks takes care of xen primitives like shared_info_page, > grant table, sched clock, runstate time which are important to save the correct > state of the guest and bring it back up. Other patches in the series, adds all > the logic to these syscore callbacks. Freeze/thaw/restore are just there for at driver > level. > > Thanks, > Anchal
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Anchal Agarwal <anchalag@amazon.com>, Stefano Stabellini <sstabellini@kernel.org> Cc: eduval@amazon.com, len.brown@intel.com, peterz@infradead.org, benh@kernel.crashing.org, x86@kernel.org, linux-mm@kvack.org, pavel@ucw.cz, hpa@zytor.com, kamatam@amazon.com, mingo@redhat.com, xen-devel@lists.xenproject.org, sblbir@amazon.com, axboe@kernel.dk, konrad.wilk@oracle.com, bp@alien8.de, tglx@linutronix.de, jgross@suse.com, netdev@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Date: Wed, 22 Jul 2020 18:45:47 -0400 [thread overview] Message-ID: <1e1f947e-ae16-33f4-435b-13d69c829029@oracle.com> (raw) In-Reply-To: <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> On 7/22/20 2:02 PM, Anchal Agarwal wrote: > On Tue, Jul 21, 2020 at 05:18:34PM -0700, Stefano Stabellini wrote: >> >> >>> If you are not sure what the effects are (or sure that it won't work) on >>> ARM then I'd add IS_ENABLED(CONFIG_X86) check, i.e. >>> >>> >>> if (!IS_ENABLED(CONFIG_X86) || !xen_hvm_domain()) >>> return -ENODEV; >> That is a good principle to have and thanks for suggesting it. However, >> in this specific case there is nothing in this patch that doesn't work >> on ARM. From an ARM perspective I think we should enable it and >> &xen_pm_notifier_block should be registered. >> > This question is for Boris, I think you we decided to get rid of the notifier > in V3 as all we need to check is SHUTDOWN_SUSPEND state which sounds plausible > to me. So this check may go away. It may still be needed for sycore_ops > callbacks registration. If this check is going away then I guess there is nothing to do here. My concern isn't about this particular notifier but rather whether this feature may affect existing functionality (ARM and PVH dom0). If Stefano feels this should be fine for ARM then so be it. -boris >> Given that all guests are HVM guests on ARM, it should work fine as is. >> >> >> I gave a quick look at the rest of the series and everything looks fine >> to me from an ARM perspective. I cannot imaging that the new freeze, >> thaw, and restore callbacks for net and block are going to cause any >> trouble on ARM. The two main x86-specific functions are >> xen_syscore_suspend/resume and they look trivial to implement on ARM (in >> the sense that they are likely going to look exactly the same.) >> > Yes but for now since things are not tested I will put this > !IS_ENABLED(CONFIG_X86) on syscore_ops calls registration part just to be safe > and not break anything. >> One question for Anchal: what's going to happen if you trigger a >> hibernation, you have the new callbacks, but you are missing >> xen_syscore_suspend/resume? >> >> Is it any worse than not having the new freeze, thaw and restore >> callbacks at all and try to do a hibernation? > If callbacks are not there, I don't expect hibernation to work correctly. > These callbacks takes care of xen primitives like shared_info_page, > grant table, sched clock, runstate time which are important to save the correct > state of the guest and bring it back up. Other patches in the series, adds all > the logic to these syscore callbacks. Freeze/thaw/restore are just there for at driver > level. > > Thanks, > Anchal
next prev parent reply other threads:[~2020-07-22 22:47 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 18:21 [PATCH v2 00/11] Fix PM hibernation in Xen guests Anchal Agarwal 2020-07-02 18:21 ` Anchal Agarwal 2020-07-02 18:21 ` [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Anchal Agarwal 2020-07-02 18:21 ` Anchal Agarwal 2020-07-13 15:52 ` Boris Ostrovsky 2020-07-15 20:49 ` Anchal Agarwal 2020-07-15 20:49 ` Anchal Agarwal 2020-07-15 21:18 ` Boris Ostrovsky 2020-07-15 21:18 ` Boris Ostrovsky 2020-07-17 19:10 ` Anchal Agarwal 2020-07-17 19:10 ` Anchal Agarwal 2020-07-19 1:47 ` Boris Ostrovsky 2020-07-19 1:47 ` Boris Ostrovsky 2020-07-20 9:37 ` Roger Pau Monné 2020-07-20 9:37 ` Roger Pau Monné 2020-07-21 0:17 ` Anchal Agarwal 2020-07-21 0:17 ` Anchal Agarwal 2020-07-21 8:30 ` Roger Pau Monné 2020-07-21 8:30 ` Roger Pau Monné 2020-07-21 19:55 ` Anchal Agarwal 2020-07-21 19:55 ` Anchal Agarwal 2020-07-22 8:27 ` Roger Pau Monné 2020-07-22 8:27 ` Roger Pau Monné 2020-07-21 0:03 ` Anchal Agarwal 2020-07-21 0:03 ` Anchal Agarwal 2020-07-21 21:48 ` Boris Ostrovsky 2020-07-21 21:48 ` Boris Ostrovsky 2020-07-22 0:18 ` Stefano Stabellini 2020-07-22 0:18 ` Stefano Stabellini 2020-07-22 0:18 ` Stefano Stabellini 2020-07-22 18:02 ` Anchal Agarwal 2020-07-22 18:02 ` Anchal Agarwal 2020-07-22 22:45 ` Boris Ostrovsky [this message] 2020-07-22 22:45 ` Boris Ostrovsky 2020-07-22 23:49 ` Stefano Stabellini 2020-07-22 23:49 ` Stefano Stabellini 2020-07-22 23:49 ` Stefano Stabellini 2020-07-23 22:57 ` Anchal Agarwal 2020-07-23 22:57 ` Anchal Agarwal 2020-07-24 23:01 ` Stefano Stabellini 2020-07-24 23:01 ` Stefano Stabellini 2020-07-24 23:01 ` Stefano Stabellini 2020-07-27 22:08 ` Boris Ostrovsky 2020-07-27 22:08 ` Boris Ostrovsky 2020-07-30 23:06 ` Anchal Agarwal 2020-07-30 23:06 ` Anchal Agarwal 2020-07-31 14:13 ` Boris Ostrovsky 2020-07-31 14:13 ` Boris Ostrovsky 2020-07-31 14:25 ` Rafael J. Wysocki 2020-07-31 14:25 ` Rafael J. Wysocki 2020-07-31 14:25 ` Rafael J. Wysocki 2020-08-04 23:42 ` Anchal Agarwal 2020-08-04 23:42 ` Anchal Agarwal 2020-08-05 13:31 ` Boris Ostrovsky 2020-08-05 13:31 ` Boris Ostrovsky 2020-08-05 17:42 ` Anchal Agarwal 2020-08-05 17:42 ` Anchal Agarwal 2020-07-02 18:21 ` [PATCH v2 03/11] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume Anchal Agarwal 2020-07-02 18:21 ` Anchal Agarwal 2020-07-02 18:22 ` [PATCH v2 04/11] x86/xen: add system core suspend and resume callbacks Anchal Agarwal 2020-07-02 18:22 ` Anchal Agarwal 2020-07-05 17:22 ` kernel test robot 2020-07-05 17:22 ` kernel test robot 2020-07-22 9:08 ` Julien Grall 2020-07-02 18:22 ` [PATCH v2 05/11] genirq: Shutdown irq chips in suspend/resume during hibernation Anchal Agarwal 2020-07-02 18:22 ` Anchal Agarwal 2020-07-02 18:22 ` [PATCH v2 06/11] xen-blkfront: add callbacks for PM suspend and hibernation Anchal Agarwal 2020-07-02 18:22 ` Anchal Agarwal 2020-07-02 18:22 ` [PATCH v2 07/11] xen-netfront: " Anchal Agarwal 2020-07-02 18:22 ` Anchal Agarwal 2020-07-02 18:22 ` [PATCH v2 08/11] x86/xen: save and restore steal clock during PM hibernation Anchal Agarwal 2020-07-02 18:22 ` Anchal Agarwal 2020-07-02 18:23 ` [PATCH v2 09/11] xen: Introduce wrapper for save/restore sched clock offset Anchal Agarwal 2020-07-02 18:23 ` Anchal Agarwal 2020-07-02 18:23 ` [PATCH v2 10/11] xen: Update sched clock offset to avoid system instability in hibernation Anchal Agarwal 2020-07-02 18:23 ` Anchal Agarwal 2020-07-02 18:23 ` [PATCH v2 11/11] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA Anchal Agarwal 2020-07-02 18:23 ` Anchal Agarwal 2020-07-02 18:25 ` [PATCH v2 02/11] xenbus: add freeze/thaw/restore callbacks support Anchal Agarwal 2020-07-02 18:25 ` Anchal Agarwal 2020-07-10 18:17 ` [PATCH v2 00/11] Fix PM hibernation in Xen guests Agarwal, Anchal 2020-07-10 18:17 ` Agarwal, Anchal 2020-07-13 19:43 ` Boris Ostrovsky 2020-07-15 19:49 ` Anchal Agarwal 2020-07-15 19:49 ` Anchal Agarwal 2020-07-15 20:49 ` Boris Ostrovsky 2020-07-15 20:49 ` Boris Ostrovsky 2020-07-16 23:28 ` Anchal Agarwal 2020-07-16 23:28 ` Anchal Agarwal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1e1f947e-ae16-33f4-435b-13d69c829029@oracle.com \ --to=boris.ostrovsky@oracle.com \ --cc=anchalag@amazon.com \ --cc=axboe@kernel.dk \ --cc=benh@kernel.crashing.org \ --cc=bp@alien8.de \ --cc=davem@davemloft.net \ --cc=dwmw@amazon.co.uk \ --cc=eduval@amazon.com \ --cc=hpa@zytor.com \ --cc=jgross@suse.com \ --cc=kamatam@amazon.com \ --cc=konrad.wilk@oracle.com \ --cc=len.brown@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-pm@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=peterz@infradead.org \ --cc=rjw@rjwysocki.net \ --cc=roger.pau@citrix.com \ --cc=sblbir@amazon.com \ --cc=sstabellini@kernel.org \ --cc=tglx@linutronix.de \ --cc=vkuznets@redhat.com \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.