* [U-Boot] [PATCH v1] imx: remove SATA boot mode for i.MX 6UL and 6ULL
@ 2017-08-29 16:10 Stefan Agner
2017-08-29 16:46 ` Stefano Babic
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Agner @ 2017-08-29 16:10 UTC (permalink / raw)
To: u-boot
From: Stefan Agner <stefan.agner@toradex.com>
The NXP i.MX 6UL and 6ULL do not support SATA and have no SATA
boot mode, hence remove it from the boot device detecion. This
fixes a build error introduced with 3bd1642d4d50 ("imx: fix USB
boot mode detection for i.MX 6UL and 6ULL")
Fixes: 3bd1642d4d50 ("imx: fix USB boot mode detection for i.MX 6UL and 6ULL")
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
---
arch/arm/mach-imx/spl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c
index bcd1033fdb..3853e7739d 100644
--- a/arch/arm/mach-imx/spl.c
+++ b/arch/arm/mach-imx/spl.c
@@ -45,8 +45,10 @@ u32 spl_boot_device(void)
case IMX6_BMODE_RESERVED:
return BOOT_DEVICE_BOARD;
/* SATA: See 8.5.4, Table 8-20 */
+#if !defined(CONFIG_MX6UL) && !defined(CONFIG_MX6ULL)
case IMX6_BMODE_SATA:
return BOOT_DEVICE_SATA;
+#endif
/* Serial ROM: See 8.5.5.1, Table 8-22 */
case IMX6_BMODE_SERIAL_ROM:
/* BOOT_CFG4[2:0] */
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v1] imx: remove SATA boot mode for i.MX 6UL and 6ULL
2017-08-29 16:10 [U-Boot] [PATCH v1] imx: remove SATA boot mode for i.MX 6UL and 6ULL Stefan Agner
@ 2017-08-29 16:46 ` Stefano Babic
2017-08-29 17:17 ` Jagan Teki
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Babic @ 2017-08-29 16:46 UTC (permalink / raw)
To: u-boot
Hi Stefan,
On 29/08/2017 18:10, Stefan Agner wrote:
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The NXP i.MX 6UL and 6ULL do not support SATA and have no SATA
> boot mode, hence remove it from the boot device detecion. This
> fixes a build error introduced with 3bd1642d4d50 ("imx: fix USB
> boot mode detection for i.MX 6UL and 6ULL")
>
> Fixes: 3bd1642d4d50 ("imx: fix USB boot mode detection for i.MX 6UL and 6ULL")
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> ---
>
> arch/arm/mach-imx/spl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c
> index bcd1033fdb..3853e7739d 100644
> --- a/arch/arm/mach-imx/spl.c
> +++ b/arch/arm/mach-imx/spl.c
> @@ -45,8 +45,10 @@ u32 spl_boot_device(void)
> case IMX6_BMODE_RESERVED:
> return BOOT_DEVICE_BOARD;
> /* SATA: See 8.5.4, Table 8-20 */
> +#if !defined(CONFIG_MX6UL) && !defined(CONFIG_MX6ULL)
> case IMX6_BMODE_SATA:
> return BOOT_DEVICE_SATA;
> +#endif
> /* Serial ROM: See 8.5.5.1, Table 8-22 */
> case IMX6_BMODE_SERIAL_ROM:
> /* BOOT_CFG4[2:0] */
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v1] imx: remove SATA boot mode for i.MX 6UL and 6ULL
2017-08-29 16:46 ` Stefano Babic
@ 2017-08-29 17:17 ` Jagan Teki
0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2017-08-29 17:17 UTC (permalink / raw)
To: u-boot
On Tue, Aug 29, 2017 at 10:16 PM, Stefano Babic <sbabic@denx.de> wrote:
> Hi Stefan,
>
> On 29/08/2017 18:10, Stefan Agner wrote:
>> From: Stefan Agner <stefan.agner@toradex.com>
>>
>> The NXP i.MX 6UL and 6ULL do not support SATA and have no SATA
>> boot mode, hence remove it from the boot device detecion. This
>> fixes a build error introduced with 3bd1642d4d50 ("imx: fix USB
>> boot mode detection for i.MX 6UL and 6ULL")
>>
>> Fixes: 3bd1642d4d50 ("imx: fix USB boot mode detection for i.MX 6UL and 6ULL")
>> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
>> ---
>>
>> arch/arm/mach-imx/spl.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c
>> index bcd1033fdb..3853e7739d 100644
>> --- a/arch/arm/mach-imx/spl.c
>> +++ b/arch/arm/mach-imx/spl.c
>> @@ -45,8 +45,10 @@ u32 spl_boot_device(void)
>> case IMX6_BMODE_RESERVED:
>> return BOOT_DEVICE_BOARD;
>> /* SATA: See 8.5.4, Table 8-20 */
>> +#if !defined(CONFIG_MX6UL) && !defined(CONFIG_MX6ULL)
>> case IMX6_BMODE_SATA:
>> return BOOT_DEVICE_SATA;
>> +#endif
>> /* Serial ROM: See 8.5.5.1, Table 8-22 */
>> case IMX6_BMODE_SERIAL_ROM:
>> /* BOOT_CFG4[2:0] */
>>
>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
Reviewed-by: Jagan Teki <jagan@openedev.com>
thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-29 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 16:10 [U-Boot] [PATCH v1] imx: remove SATA boot mode for i.MX 6UL and 6ULL Stefan Agner
2017-08-29 16:46 ` Stefano Babic
2017-08-29 17:17 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.