All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Marcelo Penna Guerra <eu@marcelopenna.org>
Cc: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver changes 2.6.0-test1
Date: Thu, 24 Jul 2003 09:27:46 -0400	[thread overview]
Message-ID: <20030724132746.GD4565@kroah.com> (raw)
In-Reply-To: <200307231443.56168.eu@marcelopenna.org>

On Wed, Jul 23, 2003 at 02:43:55PM -0300, Marcelo Penna Guerra wrote:
> Hi,
> 
> This code doesn't work well. I was porting this code to 2.5 myself, so I did 
> some fixes to the code in 2.6.0-test1-ac3.
> 
> On Saturday 19 July 2003 12:54, Greg KH wrote:
> 
> > +	smbus->adapter.algo_data = smbus;
> > +*/
> 
> The problem is here. If you leave this line commented out, you'll have 
> problems when inserting the chip module.
> 
> >  	smbus->adapter = nforce2_adapter;
> 
> Also, I don't see the point in commenting out all this lines just to introduce 
> a nforce2_adapter struct. If this is the correct aprouch, just remove the 
> duplicate code instead of just commenting it out.
> 
> Attached is a patch to fix this problems. I can't test it very well as I can 
> only see the sensors in my board with i2c-isa, but everything loads fine.
> This patch also moves the PCI ids to the pci_ids.h file.

I'd like to see someone who has this hardware test these changes before
taking them.

Anyone want to verify that things still work properly with this patch?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: Marcelo Penna Guerra <eu@marcelopenna.org>
Cc: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] i2c driver changes 2.6.0-test1
Date: Thu, 19 May 2005 06:24:07 +0000	[thread overview]
Message-ID: <20030724132746.GD4565@kroah.com> (raw)
In-Reply-To: <200307231443.56168.eu@marcelopenna.org>

On Wed, Jul 23, 2003 at 02:43:55PM -0300, Marcelo Penna Guerra wrote:
> Hi,
> 
> This code doesn't work well. I was porting this code to 2.5 myself, so I did 
> some fixes to the code in 2.6.0-test1-ac3.
> 
> On Saturday 19 July 2003 12:54, Greg KH wrote:
> 
> > +	smbus->adapter.algo_data = smbus;
> > +*/
> 
> The problem is here. If you leave this line commented out, you'll have 
> problems when inserting the chip module.
> 
> >  	smbus->adapter = nforce2_adapter;
> 
> Also, I don't see the point in commenting out all this lines just to introduce 
> a nforce2_adapter struct. If this is the correct aprouch, just remove the 
> duplicate code instead of just commenting it out.
> 
> Attached is a patch to fix this problems. I can't test it very well as I can 
> only see the sensors in my board with i2c-isa, but everything loads fine.
> This patch also moves the PCI ids to the pci_ids.h file.

I'd like to see someone who has this hardware test these changes before
taking them.

Anyone want to verify that things still work properly with this patch?

thanks,

greg k-h

  reply	other threads:[~2003-07-24 13:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-19 15:52 [BK PATCH] i2c driver changes for 2.6.0-test1 Greg KH
2005-05-19  6:24 ` Greg KH
2003-07-19 15:54 ` [PATCH] i2c driver changes 2.6.0-test1 Greg KH
2005-05-19  6:24   ` Greg KH
2003-07-19 15:54   ` Greg KH
2005-05-19  6:24     ` Greg KH
2003-07-19 15:54     ` Greg KH
2005-05-19  6:24       ` Greg KH
2003-07-19 15:54       ` Greg KH
2005-05-19  6:24         ` Greg KH
2003-07-19 15:54         ` Greg KH
2005-05-19  6:24           ` Greg KH
2003-07-19 15:54           ` Greg KH
2005-05-19  6:24             ` Greg KH
2003-07-23 17:43           ` Marcelo Penna Guerra
2005-05-19  6:24             ` Marcelo Penna Guerra
2003-07-24 13:27             ` Greg KH [this message]
2005-05-19  6:24               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030724132746.GD4565@kroah.com \
    --to=greg@kroah.com \
    --cc=eu@marcelopenna.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.