Assembler error in arch/mips/kernel/entry.S

Assembler error in arch/mips/kernel/entry.S

[Jö Fahlke]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

[Please Cc me on replys]

Hi!

Trying to compile current cvs with CONFIG_PREEMT I get:

======================================================================
  AS      arch/mips/kernel/entry.o
arch/mips/kernel/entry.S: Assembler messages:
arch/mips/kernel/entry.S:55: Error: illegal operands `beqz restore_all'
arch/mips/kernel/entry.S:56: Error: unrecognized opcode `if (in_exception_path)'
arch/mips/kernel/entry.S:57: Error: unrecognized opcode `goto restore_all'
arch/mips/kernel/entry.S:58: Error: absolute expression required `li'
======================================================================

The corresponding code looks like this:

======================================================================
        beqz    restore_all
        if (in_exception_path)
                goto restore_all;
        li      t0, PREEMPT_ACTIVE
======================================================================

Can someone please fix this?  My very limitet assembler knowledge
gives me an idea whats wrong, but I don't know how to fix it.

Meanwhile I'll try compiling without CONFIG_PREEMT.

Thanks,
Jö.

-- 
Interpunktion, Orthographie und Grammatik der Email ist frei erfunden.
Eine �bereinstimmung mit aktuellen oder ehemaligen Regeln wäre rein
zufällig und ist nicht beabsichtigt.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Assembler error in arch/mips/kernel/entry.S

[Thiemo Seufer]

Jö Fahlke wrote:
[snip]
> ======================================================================
>         beqz    restore_all
>         if (in_exception_path)
>                 goto restore_all;
>         li      t0, PREEMPT_ACTIVE
> ======================================================================
> 
> Can someone please fix this?  My very limitet assembler knowledge
> gives me an idea whats wrong, but I don't know how to fix it.

The appended guesswork may help.


Thiemo


Index: entry.S
===================================================================
RCS file: /home/cvs/linux/arch/mips/kernel/entry.S,v
retrieving revision 1.58
diff -u -p -r1.58 entry.S
--- entry.S     30 Oct 2003 01:50:28 -0000      1.58
+++ entry.S     6 Jan 2004 18:11:23 -0000
@@ -52,9 +52,7 @@ ENTRY(resume_kernel)
 need_resched:
        LONG_L  t0, TI_FLAGS($28)
        andi    t1, t0, _TIF_NEED_RESCHED
-       beqz    restore_all
-       if (in_exception_path)
-               goto restore_all;
+       beqz    t1, restore_all
        li      t0, PREEMPT_ACTIVE
        sw      t0, TI_PRE_COUNT($28)
        local_irq_enable t0

Re: Assembler error in arch/mips/kernel/entry.S

[Jö Fahlke]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Am Di,  6. Jan 2004, 19:14:56 +0100 schrieb Thiemo Seufer:
> -       beqz    restore_all
> -       if (in_exception_path)
> -               goto restore_all;
> +       beqz    t1, restore_all
>         li      t0, PREEMPT_ACTIVE

Thanks, that helped a bit, but still I get:

======================================================================
  AS      arch/mips/kernel/entry.o
arch/mips/kernel/entry.S: Assembler messages:
arch/mips/kernel/entry.S:56: Error: absolute expression required `li'
======================================================================

Jö.

-- 
oil -- operation iraqi liberation
http://www.mo.tecsamples.de/mahnwache/index.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]