linux-next: input tree build warnings

linux-next: input tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi Dmitry,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/input/evdev.c: In function 'evdev_do_ioctl':
drivers/input/evdev.c:632: warning: comparison of distinct pointer types lacks a cast
drivers/input/evdev.c:660: warning: comparison of distinct pointer types lacks a cast

Introduced by commit 61c7bfcdf5acee06f58b246d6615989134719d19 ("Input:
synaptics - add support for reporting x/y resolution").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: input tree build warnings

[Tero Saarni]

On Fri, 2009-06-12 at 17:05 +1000, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/input/evdev.c: In function 'evdev_do_ioctl':
> drivers/input/evdev.c:632: warning: comparison of distinct pointer types lacks a cast
> drivers/input/evdev.c:660: warning: comparison of distinct pointer types lacks a cast
> 
> Introduced by commit 61c7bfcdf5acee06f58b246d6615989134719d19 ("Input:
> synaptics - add support for reporting x/y resolution").

My mistake, thanks for the heads up!


Input: fix warning: comparison of distinct pointer types

Signed-off-by: Tero Saarni <tero.saarni@gmail.com>
---
 drivers/input/evdev.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 7e46b96..7e8d218 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -628,8 +628,9 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
                                abs.flat = dev->absflat[t];
                                abs.resolution = dev->absres[t];
 
-                               if (copy_to_user(p, &abs,
-                                               min(_IOC_SIZE(cmd), sizeof(struct input_absinfo))))
+                               if (copy_to_user(p, &abs, min_t(size_t,
+                                                               _IOC_SIZE(cmd),
+                                                               sizeof(struct input_absinfo))))
                                        return -EFAULT;
 
                                return 0;
@@ -656,8 +657,9 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
 
                                t = _IOC_NR(cmd) & ABS_MAX;
 
-                               if (copy_from_user(&abs, p,
-                                               min(_IOC_SIZE(cmd), sizeof(struct input_absinfo))))
+                               if (copy_from_user(&abs, p, min_t(size_t,
+                                                               _IOC_SIZE(cmd),
+                                                               sizeof(struct input_absinfo))))
                                        return -EFAULT;
 
                                /*
-- 
1.6.0.4

Re: linux-next: input tree build warnings

[Dmitry Torokhov]

On Sat, Jun 13, 2009 at 12:54:50AM +0300, Tero Saarni wrote:
> On Fri, 2009-06-12 at 17:05 +1000, Stephen Rothwell wrote:
> > Hi Dmitry,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/input/evdev.c: In function 'evdev_do_ioctl':
> > drivers/input/evdev.c:632: warning: comparison of distinct pointer types lacks a cast
> > drivers/input/evdev.c:660: warning: comparison of distinct pointer types lacks a cast
> > 
> > Introduced by commit 61c7bfcdf5acee06f58b246d6615989134719d19 ("Input:
> > synaptics - add support for reporting x/y resolution").
> 
> My mistake, thanks for the heads up!
> 
> 
> Input: fix warning: comparison of distinct pointer types
> 

I folded it into the original patch.

Thanks.

-- 
Dmitry

Re: linux-next: input tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi Dmitry, Tero,

On Fri, 19 Jun 2009 23:06:09 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> On Sat, Jun 13, 2009 at 12:54:50AM +0300, Tero Saarni wrote:
> > On Fri, 2009-06-12 at 17:05 +1000, Stephen Rothwell wrote:
> > > Hi Dmitry,
> > > 
> > > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > > 
> > > drivers/input/evdev.c: In function 'evdev_do_ioctl':
> > > drivers/input/evdev.c:632: warning: comparison of distinct pointer types lacks a cast
> > > drivers/input/evdev.c:660: warning: comparison of distinct pointer types lacks a cast
> > > 
> > > Introduced by commit 61c7bfcdf5acee06f58b246d6615989134719d19 ("Input:
> > > synaptics - add support for reporting x/y resolution").
> > 
> > My mistake, thanks for the heads up!
> 
> I folded it into the original patch.

Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]