All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] getport: RPCB_GETADDR r_owner should be an empty string
@ 2009-06-22 18:21 Chuck Lever
  0 siblings, 0 replies; only message in thread
From: Chuck Lever @ 2009-06-22 18:21 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs

Some servers reject RPCB_GETADDR requests with a non-empty r_owner
field.  "RPC: Server can't decode arguments"

An empty string is already used by libtirpc and the kernel
for RPCB_GETADDR requests.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

Hi Steve-

Noticed this at Bake-a-thon last week.

 support/nfs/getport.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/support/nfs/getport.c b/support/nfs/getport.c
index cf1677e..926bab8 100644
--- a/support/nfs/getport.c
+++ b/support/nfs/getport.c
@@ -458,10 +458,6 @@ static int nfs_gp_ping(CLIENT *client, struct timeval timeout)
 /*
  * Initialize the rpcb argument for a GETADDR request.
  *
- * The rpcbind daemon ignores the parms.r_owner field in GETADDR
- * requests, but we plant an eye-catcher to help distinguish these
- * requests in network traces.
- *
  * Returns 1 if successful, and caller must free strings pointed
  * to by r_netid and r_addr; otherwise 0.
  */
@@ -489,7 +485,7 @@ static int nfs_gp_init_rpcb_parms(const struct sockaddr *sap,
 	parms->r_vers	= version;
 	parms->r_netid	= netid;
 	parms->r_addr	= addr;
-	parms->r_owner	= "nfs-utils";	/* eye-catcher */
+	parms->r_owner	= "";
 
 	return 1;
 }


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-22 18:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-22 18:21 [PATCH] getport: RPCB_GETADDR r_owner should be an empty string Chuck Lever

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.