* [Qemu-devel] [PATCH] Implement the trivial diagnose CU and RU abort commands. These are necessary to make the device work with OpenSolaris 0609 (111b).
@ 2009-09-12 13:50 Reimar Döffinger
2009-10-05 13:24 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Reimar Döffinger @ 2009-09-12 13:50 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
---
hw/eepro100.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 2099459..7c951c0 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -771,6 +771,10 @@ static void eepro100_cu_command(EEPRO100State * s, uint8_t val)
/* Starting with offset 8, the command contains
* 64 dwords microcode which we just ignore here. */
break;
+ case CmdDiagnose:
+ logout("diagnose\n");
+ status = 0; // make sure error flag is not set
+ break;
default:
missing("undefined command");
}
@@ -864,6 +868,9 @@ static void eepro100_ru_command(EEPRO100State * s, uint8_t val)
}
set_ru_state(s, ru_ready);
break;
+ case RX_ABORT:
+ set_ru_state(s, ru_idle);
+ break;
case RX_ADDR_LOAD:
/* Load RU base. */
logout("val=0x%02x (RU base address)\n", val);
--
1.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Implement the trivial diagnose CU and RU abort commands. These are necessary to make the device work with OpenSolaris 0609 (111b).
2009-09-12 13:50 [Qemu-devel] [PATCH] Implement the trivial diagnose CU and RU abort commands. These are necessary to make the device work with OpenSolaris 0609 (111b) Reimar Döffinger
@ 2009-10-05 13:24 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-10-05 13:24 UTC (permalink / raw)
To: qemu-devel
Reimar Döffinger wrote:
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
> ---
> hw/eepro100.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 2099459..7c951c0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -771,6 +771,10 @@ static void eepro100_cu_command(EEPRO100State * s, uint8_t val)
> /* Starting with offset 8, the command contains
> * 64 dwords microcode which we just ignore here. */
> break;
> + case CmdDiagnose:
> + logout("diagnose\n");
> + status = 0; // make sure error flag is not set
>
Please avoid introducing C99 comments. Also keep the first sentence of
the description concise and < 80 characters.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-05 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-12 13:50 [Qemu-devel] [PATCH] Implement the trivial diagnose CU and RU abort commands. These are necessary to make the device work with OpenSolaris 0609 (111b) Reimar Döffinger
2009-10-05 13:24 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.