* [PATCH] CRIS v32: Should index be positive?
@ 2009-11-01 13:46 Roel Kluin
2009-11-03 12:12 ` Jesper Nilsson
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-11-01 13:46 UTC (permalink / raw)
To: Mikael Starvik, Jesper Nilsson, linux-cris-kernel, Andrew Morton, LKML
`port' is used as index for writing to pins during
allocation/deallocation. It should be positive.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
arch/cris/arch-v32/kernel/pinmux.c | 4 ++--
arch/cris/arch-v32/mach-a3/pinmux.c | 2 +-
arch/cris/arch-v32/mach-fs/pinmux.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
Found by code analysis, is it required?
diff --git a/arch/cris/arch-v32/kernel/pinmux.c b/arch/cris/arch-v32/kernel/pinmux.c
index 6eb54ea..f6f3637 100644
--- a/arch/cris/arch-v32/kernel/pinmux.c
+++ b/arch/cris/arch-v32/kernel/pinmux.c
@@ -54,7 +54,7 @@ crisv32_pinmux_alloc(int port, int first_pin, int last_pin, enum pin_mode mode)
crisv32_pinmux_init();
- if (port > PORTS)
+ if (port > PORTS || port < 0)
return -EINVAL;
spin_lock_irqsave(&pinmux_lock, flags);
@@ -197,7 +197,7 @@ crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
crisv32_pinmux_init();
- if (port > PORTS)
+ if (port > PORTS || port < 0)
return -EINVAL;
spin_lock_irqsave(&pinmux_lock, flags);
diff --git a/arch/cris/arch-v32/mach-a3/pinmux.c b/arch/cris/arch-v32/mach-a3/pinmux.c
index 0a28c9b..18648ef 100644
--- a/arch/cris/arch-v32/mach-a3/pinmux.c
+++ b/arch/cris/arch-v32/mach-a3/pinmux.c
@@ -242,7 +242,7 @@ crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
crisv32_pinmux_init();
- if (port > PORTS)
+ if (port > PORTS || port < 0)
return -EINVAL;
spin_lock_irqsave(&pinmux_lock, flags);
diff --git a/arch/cris/arch-v32/mach-fs/pinmux.c b/arch/cris/arch-v32/mach-fs/pinmux.c
index d722ad9..38f29ee 100644
--- a/arch/cris/arch-v32/mach-fs/pinmux.c
+++ b/arch/cris/arch-v32/mach-fs/pinmux.c
@@ -54,7 +54,7 @@ crisv32_pinmux_alloc(int port, int first_pin, int last_pin, enum pin_mode mode)
crisv32_pinmux_init();
- if (port > PORTS)
+ if (port > PORTS || port < 0)
return -EINVAL;
spin_lock_irqsave(&pinmux_lock, flags);
@@ -195,7 +195,7 @@ int crisv32_pinmux_dealloc(int port, int first_pin, int last_pin)
crisv32_pinmux_init();
- if (port > PORTS)
+ if (port > PORTS || port < 0)
return -EINVAL;
spin_lock_irqsave(&pinmux_lock, flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] CRIS v32: Should index be positive?
2009-11-01 13:46 [PATCH] CRIS v32: Should index be positive? Roel Kluin
@ 2009-11-03 12:12 ` Jesper Nilsson
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Nilsson @ 2009-11-03 12:12 UTC (permalink / raw)
To: Roel Kluin; +Cc: Mikael Starvik, linux-cris-kernel, Andrew Morton, LKML
On Sun, Nov 01, 2009 at 02:46:26PM +0100, Roel Kluin wrote:
> `port' is used as index for writing to pins during
> allocation/deallocation. It should be positive.
Yup, that's correct. I've added this to the CRIS tree.
Thanks!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-03 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-01 13:46 [PATCH] CRIS v32: Should index be positive? Roel Kluin
2009-11-03 12:12 ` Jesper Nilsson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.