linux-next: pcmcia tree build failure

linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hi Dominik,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/telephony/ixj_pcmcia.c: In function 'ixj_probe':
drivers/telephony/ixj_pcmcia.c:35: error: 'link' undeclared (first use in this function)

Caused by commit 990c0c8eeb34f62d062052d462feaa99715cb043 ("pcmcia: use
dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)").

I have used the version of the pcmcia tree from next-20091102 for today.
Please build test.  :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hi Dominik,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/telephony/ixj_pcmcia.c: In function 'ixj_probe':
drivers/telephony/ixj_pcmcia.c:35: error: 'link' undeclared (first use in this function)

Caused by commit 990c0c8eeb34f62d062052d462feaa99715cb043 ("pcmcia: use
dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)").

I have used the version of the pcmcia tree from next-20091102 for today.
Please build test.  :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pcmcia tree build failure

[Dominik Brodowski]

Hi Stephen,

On Wed, Nov 04, 2009 at 01:15:40PM +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/telephony/ixj_pcmcia.c: In function 'ixj_probe':
> drivers/telephony/ixj_pcmcia.c:35: error: 'link' undeclared (first use in this function)
> 
> Caused by commit 990c0c8eeb34f62d062052d462feaa99715cb043 ("pcmcia: use
> dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)").
> 
> I have used the version of the pcmcia tree from next-20091102 for today.
> Please build test.  :-(

Thanks -- fixed both issues (build failure and test setup).

Best,
	Domiik

Re: linux-next: pcmcia tree build failure

[Dominik Brodowski]

Hi Stephen,

On Wed, Nov 04, 2009 at 01:15:40PM +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/telephony/ixj_pcmcia.c: In function 'ixj_probe':
> drivers/telephony/ixj_pcmcia.c:35: error: 'link' undeclared (first use in this function)
> 
> Caused by commit 990c0c8eeb34f62d062052d462feaa99715cb043 ("pcmcia: use
> dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)").
> 
> I have used the version of the pcmcia tree from next-20091102 for today.
> Please build test.  :-(

Thanks -- fixed both issues (build failure and test setup).

Best,
	Domiik

Re: linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Hi Dominik,

On Wed, 4 Nov 2009 09:07:54 +0100 Dominik Brodowski <linux@dominikbrodowski.net> wrote:
>
> Thanks -- fixed both issues (build failure and test setup).

Thanks for that.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Hi Dominik,

On Wed, 4 Nov 2009 09:07:54 +0100 Dominik Brodowski <linux@dominikbrodowski.net> wrote:
>
> Thanks -- fixed both issues (build failure and test setup).

Thanks for that.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pcmcia tree build failure

[Dominik Brodowski]

Hey Stephen,

On Mon, Jan 25, 2010 at 01:13:43PM +1100, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/built-in.o:(.toc1+0xd118): undefined reference to `pcmcia_dev_list_lock'
> 
> Caused by commit fc53c3482805cb3281dbeb0bd29dd892aaa53303 ("pcmcia:
> simplify locking").
> 
> I have used the pcmcia tree from next-20100122 for today.

Thanks, fixed for tomorrow.

Best,
	Dominik

linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi Dominik,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/built-in.o:(.toc1+0xd118): undefined reference to `pcmcia_dev_list_lock'

Caused by commit fc53c3482805cb3281dbeb0bd29dd892aaa53303 ("pcmcia:
simplify locking").

I have used the pcmcia tree from next-20100122 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pcmcia tree build failure

[Stephen Rothwell]

Hi Dominik,

On Fri, 29 Aug 2008 09:44:17 +0200 Dominik Brodowski <linux@dominikbrodowski.net> wrote:
>
> ooops. Fixed. Thanks. Also fixed another build failure, so if you can
> re-load the pcmcia tree, that'd be great.

Not until Monday, but I will apply the following patch to the end of
today's build, ok.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff --git a/drivers/usb/host/sl811_cs.c b/drivers/usb/host/sl811_cs.c
index ca733b7..516848d 100644
--- a/drivers/usb/host/sl811_cs.c
+++ b/drivers/usb/host/sl811_cs.c
@@ -112,7 +112,8 @@ static struct platform_device platform_dev = {
 	.num_resources		= ARRAY_SIZE(resources),
 };
 
-static int sl811_hc_init(struct device *parent, ioaddr_t base_addr, int irq)
+static int sl811_hc_init(struct device *parent, resource_size_t base_addr,
+			 int irq)
 {
 	if (platform_dev.dev.parent)
 		return -EBUSY;

Re: linux-next: pcmcia tree build failure

[Dominik Brodowski]

Hi Stephen,

On Fri, Aug 29, 2008 at 04:36:58PM +1000, Stephen Rothwell wrote:
> Caused by commit 86b736d122166ec779bd86ac24e24117a675e98d ("pcmcia:
> cleanup device driver header file") which removed the handle_to_dev()
> macro.  I applied the following patch.

ooops. Fixed. Thanks. Also fixed another build failure, so if you can
re-load the pcmcia tree, that'd be great.

Best,
	Dominik

linux-next: pcmcia tree build failure

[Stephen Rothwell]

Hi Dominik,

Today's linux-next build (x86_64 allmodconfig) failed like this:

sound/pcmcia/vx/vxpocket.c: In function 'vxpocket_config':
sound/pcmcia/vx/vxpocket.c:238: error: implicit declaration of function 'handle_to_dev'
sound/pcmcia/vx/vxpocket.c:238: error: invalid lvalue in unary '&'
sound/pcmcia/pdaudiocf/pdaudiocf.c: In function 'snd_pdacf_probe':
sound/pcmcia/pdaudiocf/pdaudiocf.c:131: error: implicit declaration of function 'handle_to_dev'
sound/pcmcia/pdaudiocf/pdaudiocf.c:131: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c: In function 'cm4040_config_check':
drivers/char/pcmcia/cm4040_cs.c:550: error: implicit declaration of function 'handle_to_dev'
drivers/char/pcmcia/cm4040_cs.c:550: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c:550: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c: In function 'reader_config':
drivers/char/pcmcia/cm4040_cs.c:572: error: invalid lvalue in unary '&'
drivers/char/pcmcia/cm4040_cs.c:572: error: invalid lvalue in unary '&'

Caused by commit 86b736d122166ec779bd86ac24e24117a675e98d ("pcmcia:
cleanup device driver header file") which removed the handle_to_dev()
macro.  I applied the following patch.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 29 Aug 2008 16:34:12 +1000
Subject: [PATCH] pcmcia: restore handle_to_dev macro

It is still in widespread use.

It was removed by commit 86b736d122166ec779bd86ac24e24117a675e98d
("pcmcia: cleanup device driver header file").

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/pcmcia/ds.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/pcmcia/ds.h b/include/pcmcia/ds.h
index 13c01ab..374a7cc 100644
--- a/include/pcmcia/ds.h
+++ b/include/pcmcia/ds.h
@@ -137,6 +137,7 @@ struct pcmcia_device {
 #define to_pcmcia_dev(n) container_of(n, struct pcmcia_device, dev)
 #define to_pcmcia_drv(n) container_of(n, struct pcmcia_driver, drv)
 
+#define handle_to_dev(handle) (handle->dev)
 
 /* (deprecated) error reporting by PCMCIA devices. Use dev_printk()
  * or dev_dbg() directly in the driver, without referring to pcmcia_error_func()
-- 
1.5.6.5

Re: linux-next: pcmcia tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Hi Dominik,

On Sat, 23 Aug 2008 02:40:01 +0200 Dominik Brodowski <linux@dominikbrodowski.net> wrote:
>
> On Fri, Aug 22, 2008 at 02:52:31PM +1000, Stephen Rothwell wrote:
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > ERROR: "cs_debug_level" [drivers/pcmcia/pcmcia_core.ko] undefined!
> > 
> > Caused by commit e84d3a8fd37981178933e706432fa9f763f8ba6a ("pcmcia: fix
> > CONFIG_DEBUG and dev_debug in pcmcia_core.o") ?
> 
> ooops
> 
> > I added the following patch.
> Thanks. Squashed into the (much cleaned up) pcmcia git tree.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: pcmcia tree build failure

[Dominik Brodowski]

Hi Stephen,

On Fri, Aug 22, 2008 at 02:52:31PM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> ERROR: "cs_debug_level" [drivers/pcmcia/pcmcia_core.ko] undefined!
> 
> Caused by commit e84d3a8fd37981178933e706432fa9f763f8ba6a ("pcmcia: fix
> CONFIG_DEBUG and dev_debug in pcmcia_core.o") ?

ooops

> I added the following patch.
Thanks. Squashed into the (much cleaned up) pcmcia git tree.

Best,
	Dominik

linux-next: pcmcia tree build failure

[Stephen Rothwell]

Hi Dominik,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "cs_debug_level" [drivers/pcmcia/pcmcia_core.ko] undefined!

Caused by commit e84d3a8fd37981178933e706432fa9f763f8ba6a ("pcmcia: fix
CONFIG_DEBUG and dev_debug in pcmcia_core.o") ?

I added the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From e1469fe9d72730c25adb94872a7b2783e37cc090 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 22 Aug 2008 14:50:21 +1000
Subject: [PATCH] pcmcia: fix cs_debug_level availablility

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pcmcia/cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
index fcc6145..48386f3 100644
--- a/drivers/pcmcia/cs.c
+++ b/drivers/pcmcia/cs.c
@@ -61,7 +61,7 @@ INT_MODULE_PARM(unreset_limit,	30);		/* unreset_check's */
 /* Access speed for attribute memory windows */
 INT_MODULE_PARM(cis_speed,	300);		/* ns */
 
-#ifdef DEBUG
+#ifdef CONFIG_PCMCIA_DEBUG
 static int pc_debug;
 
 module_param(pc_debug, int, 0644);
-- 
1.5.6.3