* [PATCH] gspca pac7302/pac7311: fix buffer overrun
@ 2009-11-04 22:38 Németh Márton
2009-11-05 11:19 ` Jean-Francois Moine
0 siblings, 1 reply; 2+ messages in thread
From: Németh Márton @ 2009-11-04 22:38 UTC (permalink / raw)
To: Jean-Francois Moine, V4L Mailing List
From: Márton Németh <nm127@freemail.hu>
The reg_w_seq() function expects the sequence length in entries
and not in bytes. One entry in init_7302 and init_7311 is two
bytes and not one.
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -upr a/drivers/media/video/gspca/pac7302.c b/drivers/media/video/gspca/pac7302.c
--- a/drivers/media/video/gspca/pac7302.c 2009-11-05 00:31:36.000000000 +0100
+++ b/drivers/media/video/gspca/pac7302.c 2009-11-05 00:32:50.000000000 +0100
@@ -592,7 +592,7 @@ static void sethvflip(struct gspca_dev *
/* this function is called at probe and resume time for pac7302 */
static int sd_init(struct gspca_dev *gspca_dev)
{
- reg_w_seq(gspca_dev, init_7302, sizeof init_7302);
+ reg_w_seq(gspca_dev, init_7302, sizeof(init_7302)/2);
return 0;
}
diff -upr a/drivers/media/video/gspca/pac7311.c b/drivers/media/video/gspca/pac7311.c
--- a/drivers/media/video/gspca/pac7311.c 2009-11-04 23:28:31.000000000 +0100
+++ b/drivers/media/video/gspca/pac7311.c 2009-11-05 00:33:08.000000000 +0100
@@ -490,7 +490,7 @@ static void sethvflip(struct gspca_dev *
/* this function is called at probe and resume time for pac7311 */
static int sd_init(struct gspca_dev *gspca_dev)
{
- reg_w_seq(gspca_dev, init_7311, sizeof init_7311);
+ reg_w_seq(gspca_dev, init_7311, sizeof(init_7311)/2);
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gspca pac7302/pac7311: fix buffer overrun
2009-11-04 22:38 [PATCH] gspca pac7302/pac7311: fix buffer overrun Németh Márton
@ 2009-11-05 11:19 ` Jean-Francois Moine
0 siblings, 0 replies; 2+ messages in thread
From: Jean-Francois Moine @ 2009-11-05 11:19 UTC (permalink / raw)
To: Németh Márton; +Cc: V4L Mailing List
On Wed, 04 Nov 2009 23:38:42 +0100
Németh Márton <nm127@freemail.hu> wrote:
> The reg_w_seq() function expects the sequence length in entries
> and not in bytes. One entry in init_7302 and init_7311 is two
> bytes and not one.
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff -upr a/drivers/media/video/gspca/pac7302.c
> b/drivers/media/video/gspca/pac7302.c
[snip]
Hello Németh,
Thank you for the patch! The bug did exist for a long time, and nobody
found it yet.
I have just a remark: some of your patches have a diff starting with
'a/drivers/..'. They should start with 'a/linux/drivers/..' (as done by
'hg export').
Best regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-05 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-04 22:38 [PATCH] gspca pac7302/pac7311: fix buffer overrun Németh Márton
2009-11-05 11:19 ` Jean-Francois Moine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.