All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: aliguori@us.ibm.com, avi@redhat.com, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation
Date: Tue, 30 Mar 2010 21:40:57 +0200	[thread overview]
Message-ID: <20100330194056.GB24846@8bytes.org> (raw)
In-Reply-To: <cover.1269936879.git.eduard.munteanu@linux360.ro>

Hello Eduard,

On Tue, Mar 30, 2010 at 11:20:01AM +0300, Eduard - Gabriel Munteanu wrote:
> This patchset is intended to provide a start for implementing the
> emulation of the AMD IOMMU. For those who aren't aware yet, I intend
> to participate as a student in GSoC 2010.

Great. This is a good start.

> In short, this demonstrates a mechanism of inserting ACPI tables without
> modifying SeaBIOS or other BIOS implementations. I also have a SeaBIOS
> equivalent, but I think this approach is better, at least at the moment.

I like the approach implemented in this patchset because of its
simplicity. The right place for building acpi tables is the bios,
though. I am fine with both ways. Anthony, Avi, what do you
think about it?

> I wouldn't merge this patchset yet, at least stuff after the first patch,
> until it accumulates more work. I also didn't test loading ACPI tables from
> the command line after these modifications.

When Linux finds an IVRS table it expects that there is a working AMD
IOMMU so you should change this patchset so that the ACPI table is
enabled later when the hardware emulation is working. That will keep
this work bisectable.
As the next step I suggest you to implement an AMD IOMMU pci device
with the config space, capability and the mmio register space.

Regards,

	Joerg


WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation
Date: Tue, 30 Mar 2010 21:40:57 +0200	[thread overview]
Message-ID: <20100330194056.GB24846@8bytes.org> (raw)
In-Reply-To: <cover.1269936879.git.eduard.munteanu@linux360.ro>

Hello Eduard,

On Tue, Mar 30, 2010 at 11:20:01AM +0300, Eduard - Gabriel Munteanu wrote:
> This patchset is intended to provide a start for implementing the
> emulation of the AMD IOMMU. For those who aren't aware yet, I intend
> to participate as a student in GSoC 2010.

Great. This is a good start.

> In short, this demonstrates a mechanism of inserting ACPI tables without
> modifying SeaBIOS or other BIOS implementations. I also have a SeaBIOS
> equivalent, but I think this approach is better, at least at the moment.

I like the approach implemented in this patchset because of its
simplicity. The right place for building acpi tables is the bios,
though. I am fine with both ways. Anthony, Avi, what do you
think about it?

> I wouldn't merge this patchset yet, at least stuff after the first patch,
> until it accumulates more work. I also didn't test loading ACPI tables from
> the command line after these modifications.

When Linux finds an IVRS table it expects that there is a working AMD
IOMMU so you should change this patchset so that the ACPI table is
enabled later when the hardware emulation is working. That will keep
this work bisectable.
As the next step I suggest you to implement an AMD IOMMU pci device
with the config space, capability and the mmio register space.

Regards,

	Joerg

  parent reply	other threads:[~2010-03-30 19:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  8:20 [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [RFC PATCH 1/7] acpi: qemu_realloc() might return a different pointer Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [RFC PATCH 2/7] acpi: split and rename acpi_table_add() Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [RFC PATCH 3/7] acpi: move table header definition into pc.h Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [RFC PATCH 4/7] sparc: rename hw/iommu.c Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30 17:06   ` Blue Swirl
2010-03-30 17:06     ` Blue Swirl
2010-03-30 19:28     ` Joerg Roedel
2010-03-30 19:28       ` Joerg Roedel
2010-03-30 20:00       ` Blue Swirl
2010-03-30 20:00         ` Blue Swirl
2010-03-30 20:15         ` Eduard - Gabriel Munteanu
2010-03-30 20:15           ` Eduard - Gabriel Munteanu
2010-03-31  7:27     ` Gerd Hoffmann
2010-03-31  7:27       ` Gerd Hoffmann
2010-03-30  8:20 ` [RFC PATCH 5/7] x86-64: AMD IOMMU stub Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30 20:37   ` Blue Swirl
2010-03-30 20:37     ` [Qemu-devel] " Blue Swirl
2010-03-30  8:20 ` [RFC PATCH 6/7] acpi: cleanup acpi_checksum() Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30  8:20 ` [RFC PATCH 7/7] acpi: fix bug in acpi_checksum() caused by garbage in checksum field Eduard - Gabriel Munteanu
2010-03-30  8:20   ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-03-30 15:10   ` Richard Henderson
2010-03-30 15:10     ` Richard Henderson
2010-03-30 19:40 ` Joerg Roedel [this message]
2010-03-30 19:40   ` [Qemu-devel] Re: [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation Joerg Roedel
2010-03-31  5:38   ` Avi Kivity
2010-03-31  5:38     ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100330194056.GB24846@8bytes.org \
    --to=joro@8bytes.org \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.