* [PATCH] VGA Bios allow 1920x1080
@ 2010-04-13 4:07 Øyvind Sæther
2010-04-17 20:28 ` Avi Kivity
0 siblings, 1 reply; 4+ messages in thread
From: Øyvind Sæther @ 2010-04-13 4:07 UTC (permalink / raw)
To: kvm
The patch lets me run 1920x1080 resolution, some displays are only that and
not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and
only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin
with the VGABIOS-lgpl-latest.bin it makes works (for me).
--- vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200
+++ vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200
@@ -73,12 +73,15 @@
{ 1680, 1050, 16 , 0x184},
{ 1680, 1050, 24 , 0x185},
{ 1680, 1050, 32 , 0x186},
-{ 1920, 1200, 16 , 0x187},
-{ 1920, 1200, 24 , 0x188},
-{ 1920, 1200, 32 , 0x189},
-{ 2560, 1600, 16 , 0x18a},
-{ 2560, 1600, 24 , 0x18b},
-{ 2560, 1600, 32 , 0x18c},
+{ 1920, 1080, 16 , 0x187},
+{ 1920, 1080, 24 , 0x188},
+{ 1920, 1080, 32 , 0x189},
+{ 1920, 1200, 16 , 0x18a},
+{ 1920, 1200, 24 , 0x18b},
+{ 1920, 1200, 32 , 0x18c},
+{ 2560, 1600, 16 , 0x18d},
+{ 2560, 1600, 24 , 0x18e},
+{ 2560, 1600, 32 , 0x18f},
{ 0, },
};
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VGA Bios allow 1920x1080
2010-04-13 4:07 [PATCH] VGA Bios allow 1920x1080 Øyvind Sæther
@ 2010-04-17 20:28 ` Avi Kivity
2010-04-17 21:06 ` Øyvind Sæther
0 siblings, 1 reply; 4+ messages in thread
From: Avi Kivity @ 2010-04-17 20:28 UTC (permalink / raw)
To: oyvinds; +Cc: kvm
On 04/13/2010 07:07 AM, Øyvind Sæther wrote:
> The patch lets me run 1920x1080 resolution, some displays are only that and
> not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and
> only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin
> with the VGABIOS-lgpl-latest.bin it makes works (for me).
>
>
>
Missing signoff.
> --- vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200
> +++ vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200
> @@ -73,12 +73,15 @@
> { 1680, 1050, 16 , 0x184},
> { 1680, 1050, 24 , 0x185},
> { 1680, 1050, 32 , 0x186},
> -{ 1920, 1200, 16 , 0x187},
> -{ 1920, 1200, 24 , 0x188},
> -{ 1920, 1200, 32 , 0x189},
> -{ 2560, 1600, 16 , 0x18a},
> -{ 2560, 1600, 24 , 0x18b},
> -{ 2560, 1600, 32 , 0x18c},
> +{ 1920, 1080, 16 , 0x187},
> +{ 1920, 1080, 24 , 0x188},
> +{ 1920, 1080, 32 , 0x189},
> +{ 1920, 1200, 16 , 0x18a},
> +{ 1920, 1200, 24 , 0x18b},
> +{ 1920, 1200, 32 , 0x18c},
> +{ 2560, 1600, 16 , 0x18d},
> +{ 2560, 1600, 24 , 0x18e},
> +{ 2560, 1600, 32 , 0x18f},
> { 0, },
> };
>
Please don't modify the existing mode numbers.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VGA Bios allow 1920x1080
2010-04-17 20:28 ` Avi Kivity
@ 2010-04-17 21:06 ` Øyvind Sæther
2010-04-18 2:41 ` Amos Kong
0 siblings, 1 reply; 4+ messages in thread
From: Øyvind Sæther @ 2010-04-17 21:06 UTC (permalink / raw)
To: Avi Kivity
[-- Attachment #1: Type: Text/Plain, Size: 2297 bytes --]
> > The patch lets me run 1920x1080 resolution, some displays are only that
> > and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the
> > vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and
> > replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for
> > me).
> Missing signoff.
I have never submitted much to any big project, so sorry, and am not sure what
you mean by "Missing signoff". How do I .. signoff?
> > --- vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200
> > +++ vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200
> > @@ -73,12 +73,15 @@
> >
> > { 1680, 1050, 16 , 0x184},
> > { 1680, 1050, 24 , 0x185},
> > { 1680, 1050, 32 , 0x186},
> >
> > -{ 1920, 1200, 16 , 0x187},
> > -{ 1920, 1200, 24 , 0x188},
> > -{ 1920, 1200, 32 , 0x189},
> > -{ 2560, 1600, 16 , 0x18a},
> > -{ 2560, 1600, 24 , 0x18b},
> > -{ 2560, 1600, 32 , 0x18c},
> > +{ 1920, 1080, 16 , 0x187},
> > +{ 1920, 1080, 24 , 0x188},
> > +{ 1920, 1080, 32 , 0x189},
> > +{ 1920, 1200, 16 , 0x18a},
> > +{ 1920, 1200, 24 , 0x18b},
> > +{ 1920, 1200, 32 , 0x18c},
> > +{ 2560, 1600, 16 , 0x18d},
> > +{ 2560, 1600, 24 , 0x18e},
> > +{ 2560, 1600, 32 , 0x18f},
> >
> > { 0, },
> > };
>
> Please don't modify the existing mode numbers.
So sorry about that, it somehow just looked cleaner to get them listed in
sequense. Adding new modes to the end of what was there works too.
--- vbetables-gen.c.original 2010-04-13 05:51:09.134232495 +0200
+++ vbetables-gen.c.new3 2010-04-17 23:05:39.722313167 +0200
@@ -79,6 +79,9 @@
{ 2560, 1600, 16 , 0x18a},
{ 2560, 1600, 24 , 0x18b},
{ 2560, 1600, 32 , 0x18c},
+{ 1920, 1080, 16 , 0x18d},
+{ 1920, 1080, 24 , 0x18e},
+{ 1920, 1080, 32 , 0x18f},
{ 0, },
};
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VGA Bios allow 1920x1080
2010-04-17 21:06 ` Øyvind Sæther
@ 2010-04-18 2:41 ` Amos Kong
0 siblings, 0 replies; 4+ messages in thread
From: Amos Kong @ 2010-04-18 2:41 UTC (permalink / raw)
To: oyvinds; +Cc: Avi Kivity, kvm
2010/4/18 Øyvind Sæther <oyvinds@everdot.org>:
>> > The patch lets me run 1920x1080 resolution, some displays are only that
>> > and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the
>> > vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and
>> > replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for
>> > me).
>> Missing signoff.
>
> I have never submitted much to any big project, so sorry, and am not sure what
> you mean by "Missing signoff". How do I .. signoff?
For Your Information:
http://git.kernel.org/?p=virt/kvm/kvm.git;a=blob;f=Documentation/SubmittingPatches;h=72651f788f4e3536149ef5e7ddfbed96a8f14d2f;hb=HEAD
>> > --- vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200
>> > +++ vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200
>> > @@ -73,12 +73,15 @@
>> >
>> > { 1680, 1050, 16 , 0x184},
...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-18 2:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-13 4:07 [PATCH] VGA Bios allow 1920x1080 Øyvind Sæther
2010-04-17 20:28 ` Avi Kivity
2010-04-17 21:06 ` Øyvind Sæther
2010-04-18 2:41 ` Amos Kong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.