From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@osdl.org, Alexander van Heukelum <heukelum@fastmail.fm>,
David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, linux-am33-list@redhat.com,
linux-kernel@vger.kernel.org,
Akira Takeuchi <takeuchi.akr@jp.panasonic.com>,
Mark Salter <msalter@redhat.com>
Subject: Re: [PATCH] x86, percpu: revert commit fe8e0c25
Date: Tue, 26 Oct 2010 15:25:48 +0200 [thread overview]
Message-ID: <20101026132548.GA14666@elte.hu> (raw)
In-Reply-To: <4CC6CD4D.3010501@kernel.org>
* Tejun Heo <tj@kernel.org> wrote:
> Commit fe8e0c25 (x86, 32-bit: Align percpu area and irq stacks to THREAD_SIZE)
> aligned PERCPU section to THREAD_SIZE which can be larger than PAGE_SIZE,
> introduced DEFINE_PER_CPU_MULTIPAGE_ALIGNED() and used it to make irq stacks
> aligned to THREAD_SIZE on x86_32.
>
> This won't work. The PERCPU output section is used as the template to prepare the
> percpu area and the actual percpu area is _alwasy_ aligned to PAGE_SIZE whether
> the source area is aligned to larger size or not.
The problem is, this will reintroduce a nasty boot crash which commit fe8e0c25
fixed. Do you say that fe8e0c25 didnt have the alignment effect?
Ingo
next prev parent reply other threads:[~2010-10-26 13:26 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 22:41 [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26 9:10 ` Tejun Heo
2010-10-26 10:22 ` David Howells
2010-10-26 12:14 ` Tejun Heo
2010-10-26 12:27 ` Tejun Heo
2010-10-26 12:45 ` [PATCH] x86, percpu: revert commit fe8e0c25 Tejun Heo
2010-10-26 13:25 ` Ingo Molnar [this message]
2010-10-26 13:34 ` Tejun Heo
2010-10-26 13:49 ` Brian Gerst
2010-10-26 15:08 ` Linus Torvalds
2010-10-27 5:43 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Brian Gerst
2010-10-27 6:07 ` Eric Dumazet
2010-10-27 9:57 ` Peter Zijlstra
2010-10-27 13:33 ` Eric Dumazet
2010-10-27 13:42 ` Tejun Heo
2010-10-27 13:57 ` Eric Dumazet
2010-10-27 14:00 ` Tejun Heo
2010-10-27 14:24 ` Eric Dumazet
2010-10-27 14:39 ` Tejun Heo
2010-10-27 14:39 ` Eric Dumazet
2010-10-27 14:43 ` Tejun Heo
2010-10-27 15:21 ` Eric Dumazet
2010-10-27 15:35 ` Tejun Heo
2010-10-27 16:07 ` Eric Dumazet
2010-10-27 17:33 ` [PATCH] numa: fix slab_node(MPOL_BIND) Eric Dumazet
2010-10-28 15:59 ` Linus Torvalds
2010-10-28 16:27 ` Eric Dumazet
2010-10-28 16:45 ` Mel Gorman
2010-10-28 16:55 ` Christoph Lameter
2010-10-28 21:07 ` Andrew Morton
2010-10-29 14:55 ` Christoph Lameter
2010-10-27 20:55 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Eric Dumazet
2010-10-28 12:01 ` Tejun Heo
2010-10-28 12:30 ` Eric Dumazet
2010-10-28 14:40 ` [PATCH] x86-32: NUMA irq stacks allocations Eric Dumazet
2010-10-29 6:43 ` [tip:x86/urgent] x86-32: Restore irq stacks NUMA-aware allocations tip-bot for Eric Dumazet
2010-10-29 18:32 ` Peter Zijlstra
2010-10-29 20:09 ` Cyrill Gorcunov
2010-10-29 20:28 ` Cyrill Gorcunov
2010-10-29 20:53 ` Eric Dumazet
2010-10-29 20:59 ` Cyrill Gorcunov
2010-10-29 20:58 ` Eric Dumazet
2010-10-29 21:21 ` Cyrill Gorcunov
2010-10-27 15:19 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Linus Torvalds
2010-10-27 15:30 ` Ingo Molnar
2010-10-27 15:33 ` Ingo Molnar
2010-10-27 15:40 ` Tejun Heo
2010-10-27 15:43 ` Ingo Molnar
2010-10-27 16:03 ` [tip:x86/urgent] " tip-bot for Brian Gerst
2010-10-27 16:04 ` [tip:x86/urgent] percpu: Remove the multi-page alignment facility tip-bot for Ingo Molnar
2010-10-26 14:06 ` [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE Tejun Heo
2011-03-24 6:46 ` [Uclinux-dist-devel] " Mike Frysinger
2011-03-24 6:46 ` Mike Frysinger
2011-03-24 8:25 ` Tejun Heo
2011-03-24 8:25 ` Tejun Heo
2011-03-24 8:51 ` Tejun Heo
2011-03-24 8:51 ` Tejun Heo
2011-03-24 13:46 ` Mike Frysinger
2011-03-24 13:46 ` Mike Frysinger
2011-03-24 17:51 ` Tejun Heo
2011-03-24 8:54 ` [PATCH UPDATED] " Tejun Heo
2010-10-26 14:50 ` [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26 14:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026132548.GA14666@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=heukelum@fastmail.fm \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=takeuchi.akr@jp.panasonic.com \
--cc=tj@kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.