All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
	Greg Ungerer <gerg@uclinux.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	uClinux list <uclinux-dev@uclinux.org>
Subject: Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table
Date: Thu, 5 May 2011 08:24:33 +0200	[thread overview]
Message-ID: <201105050824.34056.arnd@arndb.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1105042033190.9040@ayla.of.borg>

On Wednesday 04 May 2011, Geert Uytterhoeven wrote:
> Impact for nommu:
>   - Store table in .rodata instead of .text,
>   - Let kernel/sys_ni.c handle the stubbing of MMU-only syscalls,
>   - Implement sys_mremap and sys_nfsservct,
>   - Remove unused padding at the end of the table.
> 
> Impact for mmu:
>   - Store table in .rodata instead of .data.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

What happened to the mmap syscall? IIRC, nommu is pointing to
a different symbol (sys_mmap_pgoff/sys_mmap2).

Did you check the macros in unistd to see if they match the
actual table? I guess it would be a good time to comment out
the ones that are not implemented in either of the two ABIs.

Otherwise, this patch looks good to me.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@lists.linux-m68k.org>,
	Greg Ungerer <gerg@uclinux.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	uClinux list <uclinux-dev@uclinux.org>
Subject: Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table
Date: Thu, 5 May 2011 08:24:33 +0200	[thread overview]
Message-ID: <201105050824.34056.arnd@arndb.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1105042033190.9040@ayla.of.borg>

On Wednesday 04 May 2011, Geert Uytterhoeven wrote:
> Impact for nommu:
>   - Store table in .rodata instead of .text,
>   - Let kernel/sys_ni.c handle the stubbing of MMU-only syscalls,
>   - Implement sys_mremap and sys_nfsservct,
>   - Remove unused padding at the end of the table.
> 
> Impact for mmu:
>   - Store table in .rodata instead of .data.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

What happened to the mmap syscall? IIRC, nommu is pointing to
a different symbol (sys_mmap_pgoff/sys_mmap2).

Did you check the macros in unistd to see if they match the
actual table? I guess it would be a good time to comment out
the ones that are not implemented in either of the two ABIs.

Otherwise, this patch looks good to me.

	Arnd

  parent reply	other threads:[~2011-05-05  6:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 18:37 [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table Geert Uytterhoeven
2011-05-04 18:37 ` Geert Uytterhoeven
2011-05-04 22:18 ` Greg Ungerer
2011-05-04 22:18   ` Greg Ungerer
2011-05-05  6:24 ` Arnd Bergmann [this message]
2011-05-05  6:24   ` Arnd Bergmann
2011-05-05  7:55   ` Greg Ungerer
2011-05-05  7:55   ` Greg Ungerer
2011-05-05 18:44   ` Geert Uytterhoeven
2011-05-05 18:44     ` Geert Uytterhoeven
2011-05-05 20:37     ` Arnd Bergmann
2011-05-05 20:37       ` Arnd Bergmann
2011-05-06  5:11       ` Geert Uytterhoeven
2011-05-06  5:11       ` Geert Uytterhoeven
2011-05-06  8:24         ` Andreas Schwab
2011-05-06  8:24           ` Andreas Schwab
2011-05-06 18:56           ` Geert Uytterhoeven
2011-05-06 18:56             ` Geert Uytterhoeven
2011-05-05 20:39     ` Mikael Pettersson
2011-05-07  8:34       ` Geert Uytterhoeven
2011-05-07  8:34         ` Geert Uytterhoeven
2011-05-07 13:16         ` Mikael Pettersson
2011-10-23  9:53     ` Andreas Schwab
2011-10-23 12:20       ` Geert Uytterhoeven
2011-10-23 14:59         ` Andreas Schwab
2011-10-23 14:59           ` Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2011-04-06 20:33 Geert Uytterhoeven
2011-04-07  1:53 ` Greg Ungerer
2011-04-13 18:16 ` Geert Uytterhoeven
2011-04-17 20:13   ` Arnd Bergmann
2011-04-19  4:32     ` Greg Ungerer
2011-04-19  8:21       ` Arnd Bergmann
2011-04-19  8:30         ` Geert Uytterhoeven
2011-04-19  8:52         ` Arnd Bergmann
2011-04-19 12:26         ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105050824.34056.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.