* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-08 5:59 ` Tommy Lin
0 siblings, 0 replies; 10+ messages in thread
From: Tommy Lin @ 2011-07-08 5:59 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, Anton Vorontsov; +Cc: linux-kernel, Tommy Lin
Original mpcore_wdt config dependency is as follow:
MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
This patch will remove SMP and made the dependency as follow:
MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
(CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
The MPCore watchdog should function normally even SMP is not turned on with
ARM11 or Cortex A9 CPU.
Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
---
arch/arm/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 3262b15..c148326 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1353,7 +1353,7 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
- depends on SMP
+ depends on CPU_V6K || CPU_V7
select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
1.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-08 5:59 ` Tommy Lin
0 siblings, 0 replies; 10+ messages in thread
From: Tommy Lin @ 2011-07-08 5:59 UTC (permalink / raw)
To: linux-arm-kernel
Original mpcore_wdt config dependency is as follow:
MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
This patch will remove SMP and made the dependency as follow:
MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
(CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
The MPCore watchdog should function normally even SMP is not turned on with
ARM11 or Cortex A9 CPU.
Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
---
arch/arm/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 3262b15..c148326 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1353,7 +1353,7 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
- depends on SMP
+ depends on CPU_V6K || CPU_V7
select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
1.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
2011-07-08 5:59 ` Tommy Lin
@ 2011-07-08 9:10 ` Anton Vorontsov
-1 siblings, 0 replies; 10+ messages in thread
From: Anton Vorontsov @ 2011-07-08 9:10 UTC (permalink / raw)
To: Tommy Lin; +Cc: Russell King, linux-arm-kernel, linux-kernel, Tommy Lin
On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> Original mpcore_wdt config dependency is as follow:
> MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
> This patch will remove SMP and made the dependency as follow:
> MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
>
> The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
> Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
> (CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
> The MPCore watchdog should function normally even SMP is not turned on with
> ARM11 or Cortex A9 CPU.
>
> Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
> ---
Russell,
As the patch is needed for CNS3xxx Watchdog support, I'd like to take
it via CNS3xxx tree, if you're OK with that.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-08 9:10 ` Anton Vorontsov
0 siblings, 0 replies; 10+ messages in thread
From: Anton Vorontsov @ 2011-07-08 9:10 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> Original mpcore_wdt config dependency is as follow:
> MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
> This patch will remove SMP and made the dependency as follow:
> MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
>
> The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
> Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
> (CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
> The MPCore watchdog should function normally even SMP is not turned on with
> ARM11 or Cortex A9 CPU.
>
> Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
> ---
Russell,
As the patch is needed for CNS3xxx Watchdog support, I'd like to take
it via CNS3xxx tree, if you're OK with that.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
2011-07-08 9:10 ` Anton Vorontsov
@ 2011-07-08 9:17 ` Russell King - ARM Linux
-1 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2011-07-08 9:17 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Tommy Lin, linux-arm-kernel, linux-kernel, Tommy Lin
On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > Original mpcore_wdt config dependency is as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
> > This patch will remove SMP and made the dependency as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
> >
> > The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
> > Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
> > (CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
> > The MPCore watchdog should function normally even SMP is not turned on with
> > ARM11 or Cortex A9 CPU.
> >
> > Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
> > ---
>
> Russell,
>
> As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> it via CNS3xxx tree, if you're OK with that.
No.
TWD is only useful if SMP is enabled, otherwise the contained code
won't be called. Without SMP you'll find that the timer rate will
be zero.
So actually your problems are bigger than just this dependency.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-08 9:17 ` Russell King - ARM Linux
0 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2011-07-08 9:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > Original mpcore_wdt config dependency is as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> SMP -> (CPU_V6K || CPU_V7)
> > This patch will remove SMP and made the dependency as follow:
> > MPCORE_WATCHDOG -> HAVE_ARM_TWD -> (CPU_V6K || CPU_V7)
> >
> > The MPCore watchdog (and timer) can be found at ARM11 MPCore (CPU_V6K) and
> > Cortex A9 MPCore (CPU_V7). The dependency between MPCORE_WATCHDOG and
> > (CPU_V6K || CPUV7) is necessary, but the dependency of SMP is redundant.
> > The MPCore watchdog should function normally even SMP is not turned on with
> > ARM11 or Cortex A9 CPU.
> >
> > Signed-off-by: Tommy Lin <tommy.lin@caviumnetworks.com>
> > ---
>
> Russell,
>
> As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> it via CNS3xxx tree, if you're OK with that.
No.
TWD is only useful if SMP is enabled, otherwise the contained code
won't be called. Without SMP you'll find that the timer rate will
be zero.
So actually your problems are bigger than just this dependency.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
2011-07-08 9:17 ` Russell King - ARM Linux
@ 2011-07-12 6:57 ` 林宏文
-1 siblings, 0 replies; 10+ messages in thread
From: 林宏文 @ 2011-07-12 6:57 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: Anton Vorontsov, linux-arm-kernel, linux-kernel
2011/7/8 Russell King - ARM Linux <linux@arm.linux.org.uk>
>
> On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> > On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > Russell,
> >
> > As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> > it via CNS3xxx tree, if you're OK with that.
>
> No.
>
> TWD is only useful if SMP is enabled, otherwise the contained code
> won't be called. Without SMP you'll find that the timer rate will
> be zero.
>
> So actually your problems are bigger than just this dependency.
I think LOCAL_TIMERS is the one that useful if SMP is enabled. The zero
timer rate issue still able to limited by LOCAL_TIMERS.
MPCore watchdog is rely on HAVE_ARM_TWD, but not related to SMP
at least in the current source. I have test the watchdog part without enable
SMP and watchdog works well except wrong reload value that can be fixed
by another patch.
--
Best Regards,
Tommy Lin
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-12 6:57 ` 林宏文
0 siblings, 0 replies; 10+ messages in thread
From: 林宏文 @ 2011-07-12 6:57 UTC (permalink / raw)
To: linux-arm-kernel
2011/7/8 Russell King - ARM Linux <linux@arm.linux.org.uk>
>
> On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> > On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > Russell,
> >
> > As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> > it via CNS3xxx tree, if you're OK with that.
>
> No.
>
> TWD is only useful if SMP is enabled, otherwise the contained code
> won't be called. Without SMP you'll find that the timer rate will
> be zero.
>
> So actually your problems are bigger than just this dependency.
I think LOCAL_TIMERS is the one that useful if SMP is enabled. The zero
timer rate issue still able to limited by LOCAL_TIMERS.
MPCore watchdog is rely on HAVE_ARM_TWD, but not related to SMP
at least in the current source. I have test the watchdog part without enable
SMP and watchdog works well except wrong reload value that can be fixed
by another patch.
--
Best Regards,
Tommy Lin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
2011-07-12 6:57 ` 林宏文
@ 2011-07-12 7:34 ` Russell King - ARM Linux
-1 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2011-07-12 7:34 UTC (permalink / raw)
To: 林宏文; +Cc: Anton Vorontsov, linux-arm-kernel, linux-kernel
On Tue, Jul 12, 2011 at 02:57:38PM +0800, 林宏文 wrote:
> 2011/7/8 Russell King - ARM Linux <linux@arm.linux.org.uk>
> >
> > On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> > > On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > > Russell,
> > >
> > > As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> > > it via CNS3xxx tree, if you're OK with that.
> >
> > No.
> >
> > TWD is only useful if SMP is enabled, otherwise the contained code
> > won't be called. Without SMP you'll find that the timer rate will
> > be zero.
> >
> > So actually your problems are bigger than just this dependency.
>
> I think LOCAL_TIMERS is the one that useful if SMP is enabled. The zero
> timer rate issue still able to limited by LOCAL_TIMERS.
No. I could repeat everything I've said about the initialization but
there's no point. I'm not dropping the SMP dependency of SMP_TWD.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD
@ 2011-07-12 7:34 ` Russell King - ARM Linux
0 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux @ 2011-07-12 7:34 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 12, 2011 at 02:57:38PM +0800, ??? wrote:
> 2011/7/8 Russell King - ARM Linux <linux@arm.linux.org.uk>
> >
> > On Fri, Jul 08, 2011 at 01:10:14PM +0400, Anton Vorontsov wrote:
> > > On Fri, Jul 08, 2011 at 01:59:23PM +0800, Tommy Lin wrote:
> > > Russell,
> > >
> > > As the patch is needed for CNS3xxx Watchdog support, I'd like to take
> > > it via CNS3xxx tree, if you're OK with that.
> >
> > No.
> >
> > TWD is only useful if SMP is enabled, otherwise the contained code
> > won't be called. Without SMP you'll find that the timer rate will
> > be zero.
> >
> > So actually your problems are bigger than just this dependency.
>
> I think LOCAL_TIMERS is the one that useful if SMP is enabled. The zero
> timer rate issue still able to limited by LOCAL_TIMERS.
No. I could repeat everything I've said about the initialization but
there's no point. I'm not dropping the SMP dependency of SMP_TWD.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-07-12 7:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-08 5:59 [PATCH 1/2] arch: arm: Correct the dependency of HAVE_ARM_TWD Tommy Lin
2011-07-08 5:59 ` Tommy Lin
2011-07-08 9:10 ` Anton Vorontsov
2011-07-08 9:10 ` Anton Vorontsov
2011-07-08 9:17 ` Russell King - ARM Linux
2011-07-08 9:17 ` Russell King - ARM Linux
2011-07-12 6:57 ` 林宏文
2011-07-12 6:57 ` 林宏文
2011-07-12 7:34 ` Russell King - ARM Linux
2011-07-12 7:34 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.