From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] clk: Add initial WM831x clock driver
Date: Fri, 15 Jul 2011 05:05:05 +0000 [thread overview]
Message-ID: <20110715050503.GL32716@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110715025339.GO2927@ponder.secretlab.ca>
On Thu, Jul 14, 2011 at 08:53:39PM -0600, Grant Likely wrote:
> On Mon, Jul 11, 2011 at 11:53:57AM +0900, Mark Brown wrote:
> > @@ -10,6 +10,7 @@ config GENERIC_CLK_BUILD_TEST
> > depends on EXPERIMENTAL && GENERIC_CLK
> > select GENERIC_CLK_FIXED
> > select GENERIC_CLK_GATE
> > + select GENERIC_CLK_WM831X if MFD_WM831X=y
> Hmmm, this could get unwieldy in a hurry.
It's not really any hassle, we've got a one of these in ASoC. The list
gets long but if you keep it sorted it's not an issue for merges and
otherwise it's just long not complicated. The ability to get build
coverage is *really* useful.
> > +static int wm831x_xtal_enable(struct clk_hw *hw)
> > +{
> > + struct wm831x_clk *clkdata = container_of(hw, struct wm831x_clk,
> > + xtal_hw);
> This container of is used 10 times. A static inline would be
> reasonable.
Not quite - it's used in three different variants (one for each of the
clocks).
> > + if (clkdata->xtal_ena)
> > + return 0;
> > + else
> > + return -EPERM;
> > +}
> Nit: return clkdata->xtal_ena ? 0 : -EPERM;
> Just makes for more concise code.
I have an extremely strong dislike of the ternery operator, I find it
does nothing for legibility.
> > + if (!clk_register(wm831x->dev, &wm831x_clkout_ops, &clkdata->clkout_hw,
> > + "clkout")) {
> > + ret = -EINVAL;
> > + goto err_fll;
> > + }
> How common will this pattern be? Is there need for a
> clk_register_many() variant?
I dunno, I think a lot of the SoCs may be doing one clk per device. But
equally well it's not like it'd be hard if someone starts working on the
API again.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Jeremy Kerr <jeremy.kerr@canonical.com>,
Grant Likely <grant@secretlab.ca>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 6/6] clk: Add initial WM831x clock driver
Date: Fri, 15 Jul 2011 14:05:05 +0900 [thread overview]
Message-ID: <20110715050503.GL32716@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110715025339.GO2927@ponder.secretlab.ca>
On Thu, Jul 14, 2011 at 08:53:39PM -0600, Grant Likely wrote:
> On Mon, Jul 11, 2011 at 11:53:57AM +0900, Mark Brown wrote:
> > @@ -10,6 +10,7 @@ config GENERIC_CLK_BUILD_TEST
> > depends on EXPERIMENTAL && GENERIC_CLK
> > select GENERIC_CLK_FIXED
> > select GENERIC_CLK_GATE
> > + select GENERIC_CLK_WM831X if MFD_WM831X=y
> Hmmm, this could get unwieldy in a hurry.
It's not really any hassle, we've got a one of these in ASoC. The list
gets long but if you keep it sorted it's not an issue for merges and
otherwise it's just long not complicated. The ability to get build
coverage is *really* useful.
> > +static int wm831x_xtal_enable(struct clk_hw *hw)
> > +{
> > + struct wm831x_clk *clkdata = container_of(hw, struct wm831x_clk,
> > + xtal_hw);
> This container of is used 10 times. A static inline would be
> reasonable.
Not quite - it's used in three different variants (one for each of the
clocks).
> > + if (clkdata->xtal_ena)
> > + return 0;
> > + else
> > + return -EPERM;
> > +}
> Nit: return clkdata->xtal_ena ? 0 : -EPERM;
> Just makes for more concise code.
I have an extremely strong dislike of the ternery operator, I find it
does nothing for legibility.
> > + if (!clk_register(wm831x->dev, &wm831x_clkout_ops, &clkdata->clkout_hw,
> > + "clkout")) {
> > + ret = -EINVAL;
> > + goto err_fll;
> > + }
> How common will this pattern be? Is there need for a
> clk_register_many() variant?
I dunno, I think a lot of the SoCs may be doing one clk per device. But
equally well it's not like it'd be hard if someone starts working on the
API again.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] clk: Add initial WM831x clock driver
Date: Fri, 15 Jul 2011 14:05:05 +0900 [thread overview]
Message-ID: <20110715050503.GL32716@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110715025339.GO2927@ponder.secretlab.ca>
On Thu, Jul 14, 2011 at 08:53:39PM -0600, Grant Likely wrote:
> On Mon, Jul 11, 2011 at 11:53:57AM +0900, Mark Brown wrote:
> > @@ -10,6 +10,7 @@ config GENERIC_CLK_BUILD_TEST
> > depends on EXPERIMENTAL && GENERIC_CLK
> > select GENERIC_CLK_FIXED
> > select GENERIC_CLK_GATE
> > + select GENERIC_CLK_WM831X if MFD_WM831X=y
> Hmmm, this could get unwieldy in a hurry.
It's not really any hassle, we've got a one of these in ASoC. The list
gets long but if you keep it sorted it's not an issue for merges and
otherwise it's just long not complicated. The ability to get build
coverage is *really* useful.
> > +static int wm831x_xtal_enable(struct clk_hw *hw)
> > +{
> > + struct wm831x_clk *clkdata = container_of(hw, struct wm831x_clk,
> > + xtal_hw);
> This container of is used 10 times. A static inline would be
> reasonable.
Not quite - it's used in three different variants (one for each of the
clocks).
> > + if (clkdata->xtal_ena)
> > + return 0;
> > + else
> > + return -EPERM;
> > +}
> Nit: return clkdata->xtal_ena ? 0 : -EPERM;
> Just makes for more concise code.
I have an extremely strong dislike of the ternery operator, I find it
does nothing for legibility.
> > + if (!clk_register(wm831x->dev, &wm831x_clkout_ops, &clkdata->clkout_hw,
> > + "clkout")) {
> > + ret = -EINVAL;
> > + goto err_fll;
> > + }
> How common will this pattern be? Is there need for a
> clk_register_many() variant?
I dunno, I think a lot of the SoCs may be doing one clk per device. But
equally well it's not like it'd be hard if someone starts working on the
API again.
next prev parent reply other threads:[~2011-07-15 5:05 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 2:53 [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` [PATCH 1/6] clk: Prototype and document clk_register() Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` [PATCH 2/6] clk: Provide a dummy clk_unregister() Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` [PATCH 3/6] clk: Constify struct clk_hw_ops Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` [PATCH 4/6] clk: Add Kconfig option to build all generic clk drivers Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 9:34 ` [PATCH 5/6] clk: Support multiple instances of the same clock Russell King - ARM Linux
2011-07-11 9:34 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Russell King - ARM Linux
2011-07-11 9:34 ` Russell King - ARM Linux
2011-07-11 10:53 ` [PATCH 5/6] clk: Support multiple instances of the same clock Mark Brown
2011-07-11 10:53 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Mark Brown
2011-07-11 10:53 ` Mark Brown
2011-07-11 11:11 ` [PATCH 5/6] clk: Support multiple instances of the same clock Russell King - ARM Linux
2011-07-11 11:11 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Russell King - ARM Linux
2011-07-11 11:11 ` Russell King - ARM Linux
2011-07-11 11:41 ` [PATCH 5/6] clk: Support multiple instances of the same clock Mark Brown
2011-07-11 11:41 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Mark Brown
2011-07-11 11:41 ` Mark Brown
2011-07-11 2:53 ` [PATCH 6/6] clk: Add initial WM831x clock driver Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-11 2:53 ` Mark Brown
2011-07-15 2:53 ` Grant Likely
2011-07-15 2:53 ` Grant Likely
2011-07-15 2:53 ` Grant Likely
2011-07-15 5:05 ` Mark Brown [this message]
2011-07-15 5:05 ` Mark Brown
2011-07-15 5:05 ` Mark Brown
2011-07-15 5:14 ` Ryan Mallon
2011-07-15 5:14 ` Ryan Mallon
2011-07-15 5:14 ` Ryan Mallon
2011-07-15 2:53 ` [PATCH 1/6] clk: Prototype and document clk_register() Grant Likely
2011-07-15 2:53 ` Grant Likely
2011-07-15 2:53 ` Grant Likely
2011-07-11 3:57 ` [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks Mark Brown
2011-07-11 3:57 ` Mark Brown
2011-07-11 3:57 ` Mark Brown
2011-07-11 4:30 ` Mike Frysinger
2011-07-11 4:30 ` Mike Frysinger
2011-07-11 4:30 ` Mike Frysinger
2011-07-11 4:56 ` Barry Song
2011-07-11 4:56 ` Barry Song
2011-07-11 4:56 ` Barry Song
2011-07-11 5:01 ` [uclinux-dist-devel] [PATCH 0/6] clk: Initial feedback for Mike Frysinger
2011-07-11 5:01 ` [uclinux-dist-devel] [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks Mike Frysinger
2011-07-11 5:01 ` Mike Frysinger
2011-07-11 9:31 ` Russell King - ARM Linux
2011-07-11 9:31 ` Russell King - ARM Linux
2011-07-11 9:31 ` Russell King - ARM Linux
2011-07-11 10:07 ` Sascha Hauer
2011-07-11 10:07 ` Sascha Hauer
2011-07-11 10:07 ` Sascha Hauer
2011-07-11 10:28 ` Russell King - ARM Linux
2011-07-11 10:28 ` Russell King - ARM Linux
2011-07-11 10:28 ` Russell King - ARM Linux
2011-07-11 10:46 ` Sascha Hauer
2011-07-11 10:46 ` Sascha Hauer
2011-07-11 10:46 ` Sascha Hauer
2011-07-11 11:43 ` Mark Brown
2011-07-11 11:43 ` Mark Brown
2011-07-11 11:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715050503.GL32716@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.