From: Mel Gorman <mgorman@suse.de> To: Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Minchan Kim <minchan.kim@gmail.com>, Dave Jones <davej@redhat.com>, Jan Kara <jack@suse.cz>, Andy Isaacson <adi@hexapodia.org>, Johannes Weiner <jweiner@redhat.com>, Rik van Riel <riel@redhat.com>, Nai Xia <nai.xia@gmail.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Date: Mon, 16 Jan 2012 11:33:04 +0000 [thread overview] Message-ID: <20120116113304.GB3143@suse.de> (raw) In-Reply-To: <20120113132540.b2c1b170.akpm@linux-foundation.org> On Fri, Jan 13, 2012 at 01:25:40PM -0800, Andrew Morton wrote: > On Wed, 14 Dec 2011 15:41:30 +0000 > Mel Gorman <mgorman@suse.de> wrote: > > > This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT > > mode that avoids writing back pages to backing storage. Async > > compaction maps to MIGRATE_ASYNC while sync compaction maps to > > MIGRATE_SYNC_LIGHT. For other migrate_pages users such as memory > > hotplug, MIGRATE_SYNC is used. > > > > This avoids sync compaction stalling for an excessive length of time, > > particularly when copying files to a USB stick where there might be > > a large number of dirty pages backed by a filesystem that does not > > support ->writepages. > > > > ... > > > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -525,6 +525,7 @@ enum positive_aop_returns { > > struct page; > > struct address_space; > > struct writeback_control; > > +enum migrate_mode; > > > > struct iov_iter { > > const struct iovec *iov; > > @@ -614,7 +615,7 @@ struct address_space_operations { > > * is false, it must not block. > > */ > > int (*migratepage) (struct address_space *, > > - struct page *, struct page *, bool); > > + struct page *, struct page *, enum migrate_mode); > > I'm getting a huge warning spew from this with my sparc64 gcc-3.4.5. > I'm not sure why, really. > Tetsuo Handa complained about the same thing using gcc 3.3 (added to cc). > Forward-declaring an enum in this fashion is problematic because some > compilers (I'm unsure about gcc) use different sizeofs for enums, > depending on the enum's value range. For example, an enum which only > has values 0...255 can fit into a byte. (iirc, the compiler actually > put it in a 16-bit storage). > Ok, I was not aware of this. Thanks for the heads-up. > So I propose: > > From: Andrew Morton <akpm@linux-foundation.org> > Subject: mm: fix warnings regarding enum migrate_mode > > sparc64 allmodconfig: > > In file included from include/linux/compat.h:15, > from /usr/src/25/arch/sparc/include/asm/siginfo.h:19, > from include/linux/signal.h:5, > from include/linux/sched.h:73, > from arch/sparc/kernel/asm-offsets.c:13: > include/linux/fs.h:618: warning: parameter has incomplete type > > It seems that my sparc64 compiler (gcc-3.4.5) doesn't like the forward > declaration of enums. > > Fix this by moving the "enum migrate_mode" definition into its own header > file. > > Cc: Mel Gorman <mgorman@suse.de> > Cc: Rik van Riel <riel@redhat.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Minchan Kim <minchan.kim@gmail.com> > Cc: Dave Jones <davej@redhat.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Andy Isaacson <adi@hexapodia.org> > Cc: Nai Xia <nai.xia@gmail.com> > Cc: Johannes Weiner <jweiner@redhat.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Mel Gorman <mgorman@suse.de> -- Mel Gorman SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de> To: Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Minchan Kim <minchan.kim@gmail.com>, Dave Jones <davej@redhat.com>, Jan Kara <jack@suse.cz>, Andy Isaacson <adi@hexapodia.org>, Johannes Weiner <jweiner@redhat.com>, Rik van Riel <riel@redhat.com>, Nai Xia <nai.xia@gmail.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Date: Mon, 16 Jan 2012 11:33:04 +0000 [thread overview] Message-ID: <20120116113304.GB3143@suse.de> (raw) In-Reply-To: <20120113132540.b2c1b170.akpm@linux-foundation.org> On Fri, Jan 13, 2012 at 01:25:40PM -0800, Andrew Morton wrote: > On Wed, 14 Dec 2011 15:41:30 +0000 > Mel Gorman <mgorman@suse.de> wrote: > > > This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT > > mode that avoids writing back pages to backing storage. Async > > compaction maps to MIGRATE_ASYNC while sync compaction maps to > > MIGRATE_SYNC_LIGHT. For other migrate_pages users such as memory > > hotplug, MIGRATE_SYNC is used. > > > > This avoids sync compaction stalling for an excessive length of time, > > particularly when copying files to a USB stick where there might be > > a large number of dirty pages backed by a filesystem that does not > > support ->writepages. > > > > ... > > > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -525,6 +525,7 @@ enum positive_aop_returns { > > struct page; > > struct address_space; > > struct writeback_control; > > +enum migrate_mode; > > > > struct iov_iter { > > const struct iovec *iov; > > @@ -614,7 +615,7 @@ struct address_space_operations { > > * is false, it must not block. > > */ > > int (*migratepage) (struct address_space *, > > - struct page *, struct page *, bool); > > + struct page *, struct page *, enum migrate_mode); > > I'm getting a huge warning spew from this with my sparc64 gcc-3.4.5. > I'm not sure why, really. > Tetsuo Handa complained about the same thing using gcc 3.3 (added to cc). > Forward-declaring an enum in this fashion is problematic because some > compilers (I'm unsure about gcc) use different sizeofs for enums, > depending on the enum's value range. For example, an enum which only > has values 0...255 can fit into a byte. (iirc, the compiler actually > put it in a 16-bit storage). > Ok, I was not aware of this. Thanks for the heads-up. > So I propose: > > From: Andrew Morton <akpm@linux-foundation.org> > Subject: mm: fix warnings regarding enum migrate_mode > > sparc64 allmodconfig: > > In file included from include/linux/compat.h:15, > from /usr/src/25/arch/sparc/include/asm/siginfo.h:19, > from include/linux/signal.h:5, > from include/linux/sched.h:73, > from arch/sparc/kernel/asm-offsets.c:13: > include/linux/fs.h:618: warning: parameter has incomplete type > > It seems that my sparc64 compiler (gcc-3.4.5) doesn't like the forward > declaration of enums. > > Fix this by moving the "enum migrate_mode" definition into its own header > file. > > Cc: Mel Gorman <mgorman@suse.de> > Cc: Rik van Riel <riel@redhat.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Minchan Kim <minchan.kim@gmail.com> > Cc: Dave Jones <davej@redhat.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Andy Isaacson <adi@hexapodia.org> > Cc: Nai Xia <nai.xia@gmail.com> > Cc: Johannes Weiner <jweiner@redhat.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Mel Gorman <mgorman@suse.de> -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-16 11:33 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-14 15:41 [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v6 Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-14 15:41 ` [PATCH 01/11] mm: compaction: Allow compaction to isolate dirty pages Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-14 15:41 ` [PATCH 02/11] mm: compaction: Use synchronous compaction for /proc/sys/vm/compact_memory Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-14 15:41 ` [PATCH 03/11] mm: vmscan: Check if we isolated a compound page during lumpy scan Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-15 23:21 ` Rik van Riel 2011-12-15 23:21 ` Rik van Riel 2011-12-14 15:41 ` [PATCH 04/11] mm: vmscan: Do not OOM if aborting reclaim to start compaction Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-15 23:36 ` Rik van Riel 2011-12-15 23:36 ` Rik van Riel 2011-12-14 15:41 ` [PATCH 05/11] mm: compaction: Determine if dirty pages can be migrated without blocking within ->migratepage Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 3:32 ` Rik van Riel 2011-12-16 3:32 ` Rik van Riel 2011-12-16 23:20 ` Andrew Morton 2011-12-16 23:20 ` Andrew Morton 2011-12-17 3:03 ` Nai Xia 2011-12-17 3:03 ` Nai Xia 2011-12-17 3:26 ` Andrew Morton 2011-12-17 3:26 ` Andrew Morton 2011-12-19 11:05 ` Mel Gorman 2011-12-19 11:05 ` Mel Gorman 2011-12-19 13:12 ` nai.xia 2011-12-19 13:12 ` nai.xia 2011-12-14 15:41 ` [PATCH 06/11] mm: compaction: make isolate_lru_page() filter-aware again Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 3:34 ` Rik van Riel 2011-12-16 3:34 ` Rik van Riel 2011-12-18 1:53 ` Minchan Kim 2011-12-18 1:53 ` Minchan Kim 2011-12-14 15:41 ` [PATCH 07/11] mm: page allocator: Do not call direct reclaim for THP allocations while compaction is deferred Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 4:10 ` Rik van Riel 2011-12-16 4:10 ` Rik van Riel 2011-12-14 15:41 ` [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 4:31 ` Rik van Riel 2011-12-16 4:31 ` Rik van Riel 2011-12-18 2:05 ` Minchan Kim 2011-12-18 2:05 ` Minchan Kim 2011-12-19 11:45 ` Mel Gorman 2011-12-19 11:45 ` Mel Gorman 2011-12-20 7:18 ` Minchan Kim 2011-12-20 7:18 ` Minchan Kim 2012-01-13 21:25 ` Andrew Morton 2012-01-13 21:25 ` Andrew Morton 2012-01-16 11:33 ` Mel Gorman [this message] 2012-01-16 11:33 ` Mel Gorman 2011-12-14 15:41 ` [PATCH 09/11] mm: vmscan: When reclaiming for compaction, ensure there are sufficient free pages available Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 4:35 ` Rik van Riel 2011-12-16 4:35 ` Rik van Riel 2011-12-14 15:41 ` [PATCH 10/11] mm: vmscan: Check if reclaim should really abort even if compaction_ready() is true for one zone Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 4:38 ` Rik van Riel 2011-12-16 4:38 ` Rik van Riel 2011-12-16 11:29 ` Mel Gorman 2011-12-16 11:29 ` Mel Gorman 2011-12-14 15:41 ` [PATCH 11/11] mm: Isolate pages for immediate reclaim on their own LRU Mel Gorman 2011-12-14 15:41 ` Mel Gorman 2011-12-16 4:47 ` Rik van Riel 2011-12-16 4:47 ` Rik van Riel 2011-12-16 12:26 ` Mel Gorman 2011-12-16 12:26 ` Mel Gorman 2011-12-16 15:17 ` Johannes Weiner 2011-12-16 15:17 ` Johannes Weiner 2011-12-16 16:07 ` Mel Gorman 2011-12-16 16:07 ` Mel Gorman 2011-12-19 16:14 ` Johannes Weiner 2011-12-19 16:14 ` Johannes Weiner 2011-12-17 16:08 ` Minchan Kim 2011-12-17 16:08 ` Minchan Kim 2011-12-19 13:26 ` Mel Gorman 2011-12-19 13:26 ` Mel Gorman 2011-12-20 7:10 ` Minchan Kim 2011-12-20 7:10 ` Minchan Kim 2011-12-20 9:55 ` Mel Gorman 2011-12-20 9:55 ` Mel Gorman 2011-12-23 19:08 ` Hugh Dickins 2011-12-23 19:08 ` Hugh Dickins 2011-12-29 16:59 ` Mel Gorman 2011-12-29 16:59 ` Mel Gorman 2011-12-29 19:31 ` Rik van Riel 2011-12-29 19:31 ` Rik van Riel 2011-12-30 11:27 ` Mel Gorman 2011-12-30 11:27 ` Mel Gorman 2011-12-16 22:56 ` [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v6 Andrew Morton 2011-12-16 22:56 ` Andrew Morton 2011-12-19 14:40 ` Mel Gorman 2011-12-19 14:40 ` Mel Gorman 2011-12-16 23:37 ` Andrew Morton 2011-12-16 23:37 ` Andrew Morton 2011-12-19 14:20 ` Mel Gorman 2011-12-19 14:20 ` Mel Gorman -- strict thread matches above, loose matches on Subject: below -- 2011-12-01 17:36 [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v5 Mel Gorman 2011-12-01 17:36 ` [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Mel Gorman 2011-12-01 17:36 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120116113304.GB3143@suse.de \ --to=mgorman@suse.de \ --cc=aarcange@redhat.com \ --cc=adi@hexapodia.org \ --cc=akpm@linux-foundation.org \ --cc=davej@redhat.com \ --cc=jack@suse.cz \ --cc=jweiner@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan.kim@gmail.com \ --cc=nai.xia@gmail.com \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.