All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@hack.frob.com>
To: Jason Baron <jbaron@redhat.com>
Cc: akpm@linux-foundation.org, avi@redhat.com,
	linux-kernel@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag
Date: Wed,  7 Mar 2012 11:43:02 -0800 (PST)	[thread overview]
Message-ID: <20120307194302.7BD142C0C3@topped-with-meat.com> (raw)
In-Reply-To: Jason Baron's message of  Wednesday, 7 March 2012 13:50:37 -0500 <20120307185035.GA2409@redhat.com>

> well, sure, we can provide an arch interface, for this check. I'm more
> concerned with the general idea. If it seems ok, I can re-do this bit
> with an arch interface.

Anything based on strcmp is dismal.  VM_ALWAYSDUMP was nice and clean.
A hook along the lines of arch_vma_name would be clean enough I suppose.
In fact, there is only one instance today (tile) where arch_vma_name()!=NULL
wouldn't do just what you need.


Thanks,
Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland McGrath <roland@hack.frob.com>
To: Jason Baron <jbaron@redhat.com>
Cc: qemu-devel@nongnu.org, akpm@linux-foundation.org, avi@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag
Date: Wed,  7 Mar 2012 11:43:02 -0800 (PST)	[thread overview]
Message-ID: <20120307194302.7BD142C0C3@topped-with-meat.com> (raw)
In-Reply-To: Jason Baron's message of  Wednesday, 7 March 2012 13:50:37 -0500 <20120307185035.GA2409@redhat.com>

> well, sure, we can provide an arch interface, for this check. I'm more
> concerned with the general idea. If it seems ok, I can re-do this bit
> with an arch interface.

Anything based on strcmp is dismal.  VM_ALWAYSDUMP was nice and clean.
A hook along the lines of arch_vma_name would be clean enough I suppose.
In fact, there is only one instance today (tile) where arch_vma_name()!=NULL
wouldn't do just what you need.


Thanks,
Roland

  reply	other threads:[~2012-03-07 19:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 17:00 [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP Jason Baron
2012-03-07 17:00 ` [Qemu-devel] " Jason Baron
2012-03-07 17:00 ` [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag Jason Baron
2012-03-07 17:00   ` [Qemu-devel] " Jason Baron
2012-03-07 17:59   ` Roland McGrath
2012-03-07 17:59     ` [Qemu-devel] " Roland McGrath
2012-03-07 18:50     ` Jason Baron
2012-03-07 18:50       ` [Qemu-devel] " Jason Baron
2012-03-07 19:43       ` Roland McGrath [this message]
2012-03-07 19:43         ` Roland McGrath
2012-03-07 21:19         ` Jason Baron
2012-03-07 21:19           ` [Qemu-devel] " Jason Baron
2012-03-07 21:26           ` Chris Metcalf
2012-03-07 21:26             ` [Qemu-devel] " Chris Metcalf
2012-03-07 21:36             ` Jason Baron
2012-03-07 21:36               ` [Qemu-devel] " Jason Baron
2012-03-07 21:41           ` Roland McGrath
2012-03-07 21:41             ` [Qemu-devel] " Roland McGrath
2012-03-07 17:00 ` [PATCH 2/2] core dump: add a new VM_DONTDUMP flag Jason Baron
2012-03-07 17:00   ` [Qemu-devel] " Jason Baron
2012-03-07 22:30 ` [PATCH 0/2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_DONTDUMP Andrew Morton
2012-03-07 22:30   ` [Qemu-devel] " Andrew Morton
2012-03-08  1:32   ` Jason Baron
2012-03-08  1:32     ` [Qemu-devel] " Jason Baron
2012-04-23 22:42 ` Michael Kerrisk
2012-04-23 22:42   ` Michael Kerrisk
2012-04-27 18:43   ` Jason Baron
2012-04-27 18:43     ` Jason Baron
2012-04-28  7:29     ` Michael Kerrisk (man-pages)
2012-04-28  7:29       ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120307194302.7BD142C0C3@topped-with-meat.com \
    --to=roland@hack.frob.com \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.