* [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
@ 2012-03-16 11:21 Michal Nazarewicz
2012-03-16 11:25 ` Michal Nazarewicz
2012-04-12 10:13 ` Michal Nazarewicz
0 siblings, 2 replies; 9+ messages in thread
From: Michal Nazarewicz @ 2012-03-16 11:21 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
From: Michal Nazarewicz <mina86@mina86.com>
There are no in-tree fsg_add() users and it has been deprecated
since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
out-of-tree users had more then enough time to convert. Removing.
---
drivers/usb/gadget/f_mass_storage.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index a371e96..47383f4 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -3110,13 +3110,6 @@ static int fsg_bind_config(struct usb_composite_dev *cdev,
return rc;
}
-static inline int __deprecated __maybe_unused
-fsg_add(struct usb_composite_dev *cdev, struct usb_configuration *c,
- struct fsg_common *common)
-{
- return fsg_bind_config(cdev, c, common);
-}
-
/************************* Module parameters *************************/
--
1.7.9.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-03-16 11:21 [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add() Michal Nazarewicz
@ 2012-03-16 11:25 ` Michal Nazarewicz
2012-04-11 9:41 ` Felipe Balbi
2012-04-12 10:13 ` Michal Nazarewicz
1 sibling, 1 reply; 9+ messages in thread
From: Michal Nazarewicz @ 2012-03-16 11:25 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
From: Michal Nazarewicz <mina86@mina86.com>
There are no in-tree fsg_add() users and it has been deprecated
since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
out-of-tree users had more then enough time to convert. Removing.
---
drivers/usb/gadget/f_mass_storage.c | 7 -------
1 file changed, 7 deletions(-)
Sorry, still had Greg's old email address in my alias list. Fixing.
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index a371e96..47383f4 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -3110,13 +3110,6 @@ static int fsg_bind_config(struct usb_composite_dev *cdev,
return rc;
}
-static inline int __deprecated __maybe_unused
-fsg_add(struct usb_composite_dev *cdev, struct usb_configuration *c,
- struct fsg_common *common)
-{
- return fsg_bind_config(cdev, c, common);
-}
-
/************************* Module parameters *************************/
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-03-16 11:25 ` Michal Nazarewicz
@ 2012-04-11 9:41 ` Felipe Balbi
2012-04-11 15:25 ` Greg Kroah-Hartman
0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2012-04-11 9:41 UTC (permalink / raw)
To: Michal Nazarewicz
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Fri, Mar 16, 2012 at 12:25:42PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> There are no in-tree fsg_add() users and it has been deprecated
> since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> out-of-tree users had more then enough time to convert. Removing.
> ---
applied, thanks. Also added your SOB, next time be more careful.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-04-11 9:41 ` Felipe Balbi
@ 2012-04-11 15:25 ` Greg Kroah-Hartman
2012-04-11 19:49 ` Michal Nazarewicz
0 siblings, 1 reply; 9+ messages in thread
From: Greg Kroah-Hartman @ 2012-04-11 15:25 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Michal Nazarewicz, linux-usb, linux-kernel
On Wed, Apr 11, 2012 at 12:41:13PM +0300, Felipe Balbi wrote:
> On Fri, Mar 16, 2012 at 12:25:42PM +0100, Michal Nazarewicz wrote:
> > From: Michal Nazarewicz <mina86@mina86.com>
> >
> > There are no in-tree fsg_add() users and it has been deprecated
> > since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> > out-of-tree users had more then enough time to convert. Removing.
> > ---
>
> applied, thanks. Also added your SOB, next time be more careful.
Um, wait, you can't just "add" a SOB, that's not allowed at all, sorry.
Michal, do you sign-off on this patch? If so, please do so.
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-04-11 15:25 ` Greg Kroah-Hartman
@ 2012-04-11 19:49 ` Michal Nazarewicz
2012-04-12 7:52 ` Felipe Balbi
0 siblings, 1 reply; 9+ messages in thread
From: Michal Nazarewicz @ 2012-04-11 19:49 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
>> On Fri, Mar 16, 2012 at 12:25:42PM +0100, Michal Nazarewicz wrote:
>>> From: Michal Nazarewicz <mina86@mina86.com>
>>>
>>> There are no in-tree fsg_add() users and it has been deprecated
>>> since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
>>> out-of-tree users had more then enough time to convert. Removing.
> On Wed, Apr 11, 2012 at 12:41:13PM +0300, Felipe Balbi wrote:
>> applied, thanks. Also added your SOB, next time be more careful.
On Wed, 11 Apr 2012 17:25:28 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote
> Um, wait, you can't just "add" a SOB, that's not allowed at all, sorry.
>
> Michal, do you sign-off on this patch? If so, please do so.
Sorry, yes, of course.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-04-11 19:49 ` Michal Nazarewicz
@ 2012-04-12 7:52 ` Felipe Balbi
2012-04-12 10:16 ` Michal Nazarewicz
0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2012-04-12 7:52 UTC (permalink / raw)
To: Michal Nazarewicz
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On Wed, Apr 11, 2012 at 09:49:49PM +0200, Michal Nazarewicz wrote:
> >>On Fri, Mar 16, 2012 at 12:25:42PM +0100, Michal Nazarewicz wrote:
> >>>From: Michal Nazarewicz <mina86@mina86.com>
> >>>
> >>>There are no in-tree fsg_add() users and it has been deprecated
> >>>since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> >>>out-of-tree users had more then enough time to convert. Removing.
>
> >On Wed, Apr 11, 2012 at 12:41:13PM +0300, Felipe Balbi wrote:
> >>applied, thanks. Also added your SOB, next time be more careful.
>
> On Wed, 11 Apr 2012 17:25:28 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote
> >Um, wait, you can't just "add" a SOB, that's not allowed at all, sorry.
> >
> >Michal, do you sign-off on this patch? If so, please do so.
>
> Sorry, yes, of course.
I think you need to be more verbose and reply with the actual
Signed-off-by: line
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-03-16 11:21 [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add() Michal Nazarewicz
2012-03-16 11:25 ` Michal Nazarewicz
@ 2012-04-12 10:13 ` Michal Nazarewicz
2012-04-12 11:25 ` Felipe Balbi
1 sibling, 1 reply; 9+ messages in thread
From: Michal Nazarewicz @ 2012-04-12 10:13 UTC (permalink / raw)
To: Felipe Balbi, Michal Nazarewicz
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, 16 Mar 2012 12:21:15 +0100, Michal Nazarewicz <mpn@google.com> wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> There are no in-tree fsg_add() users and it has been deprecated
> since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> out-of-tree users had more then enough time to convert. Removing.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/f_mass_storage.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
> index a371e96..47383f4 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -3110,13 +3110,6 @@ static int fsg_bind_config(struct usb_composite_dev *cdev,
> return rc;
> }
>-static inline int __deprecated __maybe_unused
> -fsg_add(struct usb_composite_dev *cdev, struct usb_configuration *c,
> - struct fsg_common *common)
> -{
> - return fsg_bind_config(cdev, c, common);
> -}
> -
> /************************* Module parameters *************************/
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-04-12 7:52 ` Felipe Balbi
@ 2012-04-12 10:16 ` Michal Nazarewicz
0 siblings, 0 replies; 9+ messages in thread
From: Michal Nazarewicz @ 2012-04-12 10:16 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Thu, 12 Apr 2012 09:52:23 +0200, Felipe Balbi <balbi@ti.com> wrote:
> I think you need to be more verbose and reply with the actual
> Signed-off-by: line
Done, replied to the original with SOB line.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
2012-04-12 10:13 ` Michal Nazarewicz
@ 2012-04-12 11:25 ` Felipe Balbi
0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2012-04-12 11:25 UTC (permalink / raw)
To: Michal Nazarewicz
Cc: Felipe Balbi, Michal Nazarewicz, Greg Kroah-Hartman, linux-usb,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Thu, Apr 12, 2012 at 12:13:32PM +0200, Michal Nazarewicz wrote:
> On Fri, 16 Mar 2012 12:21:15 +0100, Michal Nazarewicz <mpn@google.com> wrote:
> >From: Michal Nazarewicz <mina86@mina86.com>
> >
> >There are no in-tree fsg_add() users and it has been deprecated
> >since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> >out-of-tree users had more then enough time to convert. Removing.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-04-12 11:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-16 11:21 [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add() Michal Nazarewicz
2012-03-16 11:25 ` Michal Nazarewicz
2012-04-11 9:41 ` Felipe Balbi
2012-04-11 15:25 ` Greg Kroah-Hartman
2012-04-11 19:49 ` Michal Nazarewicz
2012-04-12 7:52 ` Felipe Balbi
2012-04-12 10:16 ` Michal Nazarewicz
2012-04-12 10:13 ` Michal Nazarewicz
2012-04-12 11:25 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.