* linux-next: build failure after merge of the final tree (net-next tree related)
@ 2012-04-30 5:58 ` Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2012-04-30 5:58 UTC (permalink / raw)
To: David Miller, netdev; +Cc: linux-next, linux-kernel, Benjamin LaHaise
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
net/l2tp/l2tp_core.c: In function 'l2tp_verify_udp_checksum':
net/l2tp/l2tp_core.c:464:7: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
Caused by commit d2cf3361677e ("net/l2tp: add support for L2TP over IPv6
UDP"). Include file missing.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build failure after merge of the final tree (net-next tree related)
@ 2012-04-30 5:58 ` Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2012-04-30 5:58 UTC (permalink / raw)
To: David Miller, netdev; +Cc: linux-next, linux-kernel, Benjamin LaHaise
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
net/l2tp/l2tp_core.c: In function 'l2tp_verify_udp_checksum':
net/l2tp/l2tp_core.c:464:7: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
Caused by commit d2cf3361677e ("net/l2tp: add support for L2TP over IPv6
UDP"). Include file missing.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the final tree (net-next tree related)
2012-04-30 5:58 ` Stephen Rothwell
(?)
@ 2012-04-30 17:22 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-04-30 17:22 UTC (permalink / raw)
To: sfr; +Cc: netdev, linux-next, linux-kernel, bcrl
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Apr 2012 15:58:36 +1000
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> net/l2tp/l2tp_core.c: In function 'l2tp_verify_udp_checksum':
> net/l2tp/l2tp_core.c:464:7: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>
> Caused by commit d2cf3361677e ("net/l2tp: add support for L2TP over IPv6
> UDP"). Include file missing.
>
> I have reverted that commit for today.
The fix is less work than the revert on this one isn't it? :-)
Pushed to net-next, thanks Stephen:
--------------------
l2tp: Add missing net/net/ip6_checksum.h include.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/l2tp/l2tp_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index e91d559..0ca9bc3 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -56,6 +56,7 @@
#include <net/inet6_connection_sock.h>
#include <net/inet_ecn.h>
#include <net/ip6_route.h>
+#include <net/ip6_checksum.h>
#include <asm/byteorder.h>
#include <linux/atomic.h>
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH net-next] net/l2tp: fix build error in l2tp from missing ipv6 checksum include
2012-04-30 5:58 ` Stephen Rothwell
(?)
(?)
@ 2012-04-30 17:24 ` Benjamin LaHaise
2012-04-30 17:31 ` David Miller
-1 siblings, 1 reply; 5+ messages in thread
From: Benjamin LaHaise @ 2012-04-30 17:24 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: David Miller, netdev, linux-next, linux-kernel
Hi Stephen,
Can you please verify if the patch below fixes the issue? Thanks.
-ben
----
net/l2tp: fix build error in l2tp from missing ipv6 checksum include
L2TP needs to ensure the IPv6 checksum helpers are included.
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
---
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index e91d559..0ca9bc3 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -56,6 +56,7 @@
#include <net/inet6_connection_sock.h>
#include <net/inet_ecn.h>
#include <net/ip6_route.h>
+#include <net/ip6_checksum.h>
#include <asm/byteorder.h>
#include <linux/atomic.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/l2tp: fix build error in l2tp from missing ipv6 checksum include
2012-04-30 17:24 ` [PATCH net-next] net/l2tp: fix build error in l2tp from missing ipv6 checksum include Benjamin LaHaise
@ 2012-04-30 17:31 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-04-30 17:31 UTC (permalink / raw)
To: bcrl; +Cc: sfr, netdev, linux-next, linux-kernel
From: Benjamin LaHaise <bcrl@kvack.org>
Date: Mon, 30 Apr 2012 13:24:02 -0400
> Can you please verify if the patch below fixes the issue? Thanks.
I already checked a fix into the tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-30 17:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-30 5:58 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2012-04-30 5:58 ` Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-04-30 17:24 ` [PATCH net-next] net/l2tp: fix build error in l2tp from missing ipv6 checksum include Benjamin LaHaise
2012-04-30 17:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.