* [GUILT] [PATCH] Handle empty patches and patches with only a header.
@ 2012-04-30 10:29 Per Cederqvist
2012-04-30 16:48 ` Jeff Sipek
0 siblings, 1 reply; 3+ messages in thread
From: Per Cederqvist @ 2012-04-30 10:29 UTC (permalink / raw)
To: Jeff Sipek; +Cc: git, ceder
"git apply --numstat" in Git 1.7.10 gives an error message unless the
patch contains a diff, so don't attempt to apply it unless we find a
Signed-off-by: Per Cederqvist <cederp@opera.com>
---
guilt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guilt b/guilt
index 5d619c5..66a671a 100755
--- a/guilt
+++ b/guilt
@@ -622,7 +622,7 @@ push_patch()
cd_to_toplevel
# apply the patch if and only if there is something to apply
- if [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
+ if grep -q '^diff ' "$p" && [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
if [ "$bail_action" = abort ]; then
reject=""
fi
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GUILT] [PATCH] Handle empty patches and patches with only a header.
2012-04-30 10:29 [GUILT] [PATCH] Handle empty patches and patches with only a header Per Cederqvist
@ 2012-04-30 16:48 ` Jeff Sipek
2012-05-02 6:27 ` Per Cederqvist
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Sipek @ 2012-04-30 16:48 UTC (permalink / raw)
To: Per Cederqvist; +Cc: git
On Mon, Apr 30, 2012 at 12:29:55PM +0200, Per Cederqvist wrote:
> "git apply --numstat" in Git 1.7.10 gives an error message unless the
> patch contains a diff, so don't attempt to apply it unless we find a
Find a what? Such a cliff-hanger! :)
I assume you mean find a '^diff'.
I'll fix up the commit message before applying.
Thanks,
Jeff.
> Signed-off-by: Per Cederqvist <cederp@opera.com>
> ---
> guilt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guilt b/guilt
> index 5d619c5..66a671a 100755
> --- a/guilt
> +++ b/guilt
> @@ -622,7 +622,7 @@ push_patch()
> cd_to_toplevel
>
> # apply the patch if and only if there is something to apply
> - if [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
> + if grep -q '^diff ' "$p" && [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
> if [ "$bail_action" = abort ]; then
> reject=""
> fi
> --
> 1.7.10
>
--
Keyboard not found!
Press F1 to enter Setup
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GUILT] [PATCH] Handle empty patches and patches with only a header.
2012-04-30 16:48 ` Jeff Sipek
@ 2012-05-02 6:27 ` Per Cederqvist
0 siblings, 0 replies; 3+ messages in thread
From: Per Cederqvist @ 2012-05-02 6:27 UTC (permalink / raw)
To: Jeff Sipek; +Cc: git, ceder
On 04/30/2012 06:48 PM, Jeff Sipek wrote:
> On Mon, Apr 30, 2012 at 12:29:55PM +0200, Per Cederqvist wrote:
>> "git apply --numstat" in Git 1.7.10 gives an error message unless the
>> patch contains a diff, so don't attempt to apply it unless we find a
>
> Find a what? Such a cliff-hanger! :)
>
> I assume you mean find a '^diff'.
Yes. Initially, I searched for "@@" and the commit message
said "diff hunk", but that heuristic failed if you had a
patch that just changed the mode of a single file. So I
changed the patch to search for "^diff" instead, and
apparently got distracted while editing the commit message.
/cederp
> I'll fix up the commit message before applying.
>
> Thanks,
>
> Jeff.
>
>> Signed-off-by: Per Cederqvist<cederp@opera.com>
>> ---
>> guilt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guilt b/guilt
>> index 5d619c5..66a671a 100755
>> --- a/guilt
>> +++ b/guilt
>> @@ -622,7 +622,7 @@ push_patch()
>> cd_to_toplevel
>>
>> # apply the patch if and only if there is something to apply
>> - if [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
>> + if grep -q '^diff ' "$p"&& [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
>> if [ "$bail_action" = abort ]; then
>> reject=""
>> fi
>> --
>> 1.7.10
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-02 6:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-30 10:29 [GUILT] [PATCH] Handle empty patches and patches with only a header Per Cederqvist
2012-04-30 16:48 ` Jeff Sipek
2012-05-02 6:27 ` Per Cederqvist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.