[PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

[PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

[David Herrmann]

We use errno and EINVAL so include errno.h.

This patch introduced this bug:
http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Cc: Chia-I Wu <olv@lunarg.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Adam Jackson <ajax@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
---
I've CC'ed everyone who reviewed/applied the patch that broke fbdev. Hopefully,
someone can apply it this time.

 src/gallium/state_trackers/egl/fbdev/native_fbdev.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
index b45ab5c..b17a8ce 100644
--- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
+++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
@@ -41,6 +41,7 @@
  *  - no pixmap support
  */
 
+#include <errno.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-- 
1.7.10

Re: [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

[Kristian Hoegsberg]

On Sun, Apr 29, 2012 at 11:53:16AM +0200, David Herrmann wrote:
> We use errno and EINVAL so include errno.h.
> 
> This patch introduced this bug:
> http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> Cc: Chia-I Wu <olv@lunarg.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> I've CC'ed everyone who reviewed/applied the patch that broke fbdev. Hopefully,
> someone can apply it this time.

Thanks, applied.
Kristian

>  src/gallium/state_trackers/egl/fbdev/native_fbdev.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> index b45ab5c..b17a8ce 100644
> --- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> +++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> @@ -41,6 +41,7 @@
>   *  - no pixmap support
>   */
>  
> +#include <errno.h>
>  #include <sys/ioctl.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
> -- 
> 1.7.10
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h

[David Herrmann]

Hi Dave

You applied the following patch which breaks fbdev-egl backend:

http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7

It doesn't compile anymore. I appended the correct fix below. I also
CC'ed mesa-dev and the people who reviewed the original patch this
time as I have no idea who I need to send this to.

Thanks
David

**********************************************

egl-fbdev: Fix compile-error by including errno.h

We use errno and EINVAL so include errno.h.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 src/gallium/state_trackers/egl/fbdev/native_fbdev.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
index b45ab5c..b17a8ce 100644
--- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
+++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
@@ -41,6 +41,7 @@
 *  - no pixmap support
 */
+#include <errno.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
--
1.7.10