From: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com> To: Miklos Szeredi <miklos@szeredi.hu>, Alexander Viro <viro@zeniv.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, Muthukumar R <muthur@gmail.com> Cc: fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, yrl.pp-manager.tt@hitachi.com, Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>, Miklos Szeredi <miklos@szeredi.hu>, Nikolaus Rath <Nikolaus@rath.org>, Liu Yuan <namei.unix@gmail.com>, Has-Wen Nienhuys <hanwen@xs4all.nl> Subject: [PATCH -v2 3/6] fuse: remove cache for fuse request allocation Date: Thu, 19 Jul 2012 21:49:34 +0900 [thread overview] Message-ID: <20120719124934.6250.47335.stgit@ltc137.sdl.hitachi.co.jp> (raw) In-Reply-To: <20120719124851.6250.43316.stgit@ltc137.sdl.hitachi.co.jp> Remove fuse_req_cachep, which was used for fuse request buffer. It is no longer used since the buffer is allocated dynamically due to the tunable maximum read/write request size. Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Liu Yuan <namei.unix@gmail.com> Cc: Has-Wen Nienhuys <hanwen@xs4all.nl> --- fs/fuse/dev.c | 21 +-------------------- 1 files changed, 1 insertions(+), 20 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 511560b..4087ff4 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -23,8 +23,6 @@ MODULE_ALIAS_MISCDEV(FUSE_MINOR); MODULE_ALIAS("devname:fuse"); -static struct kmem_cache *fuse_req_cachep; - static struct fuse_conn *fuse_get_conn(struct file *file) { /* @@ -2075,27 +2073,10 @@ static struct miscdevice fuse_miscdevice = { int __init fuse_dev_init(void) { - int err = -ENOMEM; - fuse_req_cachep = kmem_cache_create("fuse_request", - sizeof(struct fuse_req), - 0, 0, NULL); - if (!fuse_req_cachep) - goto out; - - err = misc_register(&fuse_miscdevice); - if (err) - goto out_cache_clean; - - return 0; - - out_cache_clean: - kmem_cache_destroy(fuse_req_cachep); - out: - return err; + return misc_register(&fuse_miscdevice); } void fuse_dev_cleanup(void) { misc_deregister(&fuse_miscdevice); - kmem_cache_destroy(fuse_req_cachep); }
WARNING: multiple messages have this Message-ID (diff)
From: Mitsuo Hayasaka <mitsuo.hayasaka.hu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org> To: Miklos Szeredi <miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org>, Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Muthukumar R <muthur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Miklos Szeredi <miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nikolaus Rath <Nikolaus-BTH8mxji4b0@public.gmane.org>, yrl.pp-manager.tt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH -v2 3/6] fuse: remove cache for fuse request allocation Date: Thu, 19 Jul 2012 21:49:34 +0900 [thread overview] Message-ID: <20120719124934.6250.47335.stgit@ltc137.sdl.hitachi.co.jp> (raw) In-Reply-To: <20120719124851.6250.43316.stgit-1LHq5NA/h4JbBxankqS+oUK/SjQzz50+@public.gmane.org> Remove fuse_req_cachep, which was used for fuse request buffer. It is no longer used since the buffer is allocated dynamically due to the tunable maximum read/write request size. Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org> Cc: Miklos Szeredi <miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org> Cc: Nikolaus Rath <Nikolaus-BTH8mxji4b0@public.gmane.org> Cc: Liu Yuan <namei.unix-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Has-Wen Nienhuys <hanwen-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> --- fs/fuse/dev.c | 21 +-------------------- 1 files changed, 1 insertions(+), 20 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 511560b..4087ff4 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -23,8 +23,6 @@ MODULE_ALIAS_MISCDEV(FUSE_MINOR); MODULE_ALIAS("devname:fuse"); -static struct kmem_cache *fuse_req_cachep; - static struct fuse_conn *fuse_get_conn(struct file *file) { /* @@ -2075,27 +2073,10 @@ static struct miscdevice fuse_miscdevice = { int __init fuse_dev_init(void) { - int err = -ENOMEM; - fuse_req_cachep = kmem_cache_create("fuse_request", - sizeof(struct fuse_req), - 0, 0, NULL); - if (!fuse_req_cachep) - goto out; - - err = misc_register(&fuse_miscdevice); - if (err) - goto out_cache_clean; - - return 0; - - out_cache_clean: - kmem_cache_destroy(fuse_req_cachep); - out: - return err; + return misc_register(&fuse_miscdevice); } void fuse_dev_cleanup(void) { misc_deregister(&fuse_miscdevice); - kmem_cache_destroy(fuse_req_cachep); } ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
next prev parent reply other threads:[~2012-07-19 12:42 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-19 12:48 [PATCH -v2 0/6] fuse: make maximum read/write request size tunable Mitsuo Hayasaka 2012-07-19 12:49 ` [PATCH -v2 1/6] pipe: make the maximum pipe size referable from kernel module Mitsuo Hayasaka 2012-07-19 12:49 ` [PATCH -v2 2/6] fuse: make the maximum read/write request size tunable Mitsuo Hayasaka 2012-08-08 14:04 ` Miklos Szeredi 2012-07-19 12:49 ` Mitsuo Hayasaka [this message] 2012-07-19 12:49 ` [PATCH -v2 3/6] fuse: remove cache for fuse request allocation Mitsuo Hayasaka 2012-07-19 12:49 ` [PATCH -v2 4/6] fuse: add a sysfs parameter to control the maximum request size Mitsuo Hayasaka 2012-07-19 12:49 ` Mitsuo Hayasaka 2012-08-08 14:43 ` Miklos Szeredi 2012-07-19 12:49 ` [PATCH -v2 5/6] fuse: set default global limit considering tunable " Mitsuo Hayasaka 2012-07-19 12:49 ` Mitsuo Hayasaka 2012-07-19 12:50 ` [PATCH -v2 6/6] fuse: add documentation of sysfs parameter to limit maximum fuse " Mitsuo Hayasaka 2012-07-19 12:50 ` Mitsuo Hayasaka 2012-07-19 17:51 ` Rob Landley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120719124934.6250.47335.stgit@ltc137.sdl.hitachi.co.jp \ --to=mitsuo.hayasaka.hu@hitachi.com \ --cc=Nikolaus@rath.org \ --cc=akpm@linux-foundation.org \ --cc=fuse-devel@lists.sourceforge.net \ --cc=hanwen@xs4all.nl \ --cc=linux-doc@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=muthur@gmail.com \ --cc=namei.unix@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=yrl.pp-manager.tt@hitachi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.