* [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt
@ 2013-01-20 0:32 Aaro Koskinen
[not found] ` <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Aaro Koskinen @ 2013-01-20 0:32 UTC (permalink / raw)
To: w.sang, ben-linux, linux-omap, linux-i2c, balbi; +Cc: Aaro Koskinen
The errata handling function acks wrong interrupt in case of "Arbitration
lost". Fix it.
Discovered during code review, the real impact of the bug is unknown.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/i2c/busses/i2c-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 20d41bf..832f16e 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -803,7 +803,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *dev)
if (stat & OMAP_I2C_STAT_AL) {
dev_err(dev->dev, "Arbitration lost\n");
dev->cmd_err |= OMAP_I2C_STAT_AL;
- omap_i2c_ack_stat(dev, OMAP_I2C_STAT_NACK);
+ omap_i2c_ack_stat(dev, OMAP_I2C_STAT_AL);
}
return -EIO;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt
[not found] ` <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
@ 2013-01-20 9:19 ` Felipe Balbi
2013-01-23 9:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2013-01-20 9:19 UTC (permalink / raw)
To: Aaro Koskinen
Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
Hi,
On Sun, Jan 20, 2013 at 02:32:58AM +0200, Aaro Koskinen wrote:
> The errata handling function acks wrong interrupt in case of "Arbitration
> lost". Fix it.
>
> Discovered during code review, the real impact of the bug is unknown.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
thanks for sending this
Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 20d41bf..832f16e 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -803,7 +803,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *dev)
> if (stat & OMAP_I2C_STAT_AL) {
> dev_err(dev->dev, "Arbitration lost\n");
> dev->cmd_err |= OMAP_I2C_STAT_AL;
> - omap_i2c_ack_stat(dev, OMAP_I2C_STAT_NACK);
> + omap_i2c_ack_stat(dev, OMAP_I2C_STAT_AL);
> }
>
> return -EIO;
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt
[not found] ` <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2013-01-20 9:19 ` Felipe Balbi
@ 2013-01-23 9:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2013-01-23 9:57 UTC (permalink / raw)
To: Aaro Koskinen
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0
On Sun, Jan 20, 2013 at 02:32:58AM +0200, Aaro Koskinen wrote:
> The errata handling function acks wrong interrupt in case of "Arbitration
> lost". Fix it.
>
> Discovered during code review, the real impact of the bug is unknown.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Applied to current, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-23 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-20 0:32 [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt Aaro Koskinen
[not found] ` <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2013-01-20 9:19 ` Felipe Balbi
2013-01-23 9:57 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.