From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: Seth Jennings <sjenning@linux.vnet.ibm.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>, Dan Magenheimer <dan.magenheimer@oracle.com>, Robert Jennings <rcj@linux.vnet.ibm.com>, Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <jweiner@redhat.com>, Rik van Riel <riel@redhat.com>, Larry Woodman <lwoodman@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Dave Hansen <dave@linux.vnet.ibm.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCHv3 1/6] debugfs: add get/set for atomic types Date: Tue, 29 Jan 2013 15:35:10 -0500 [thread overview] Message-ID: <20130129203509.GB27740@konrad-lan.dumpdata.com> (raw) In-Reply-To: <1359409767-30092-2-git-send-email-sjenning@linux.vnet.ibm.com> On Mon, Jan 28, 2013 at 03:49:22PM -0600, Seth Jennings wrote: > debugfs currently lack the ability to create attributes > that set/get atomic_t values. > > This patch adds support for this through a new > debugfs_create_atomic_t() function. > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > fs/debugfs/file.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > include/linux/debugfs.h | 2 ++ > 2 files changed, 44 insertions(+) > > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c > index c5ca6ae..fa26d5b 100644 > --- a/fs/debugfs/file.c > +++ b/fs/debugfs/file.c > @@ -21,6 +21,7 @@ > #include <linux/debugfs.h> > #include <linux/io.h> > #include <linux/slab.h> > +#include <linux/atomic.h> > > static ssize_t default_read_file(struct file *file, char __user *buf, > size_t count, loff_t *ppos) > @@ -403,6 +404,47 @@ struct dentry *debugfs_create_size_t(const char *name, umode_t mode, > } > EXPORT_SYMBOL_GPL(debugfs_create_size_t); > > +static int debugfs_atomic_t_set(void *data, u64 val) Should the 'data' be 'atomic_t *' just to make sure nobody messes this up? Or would that bring too much header changes? > +{ > + atomic_set((atomic_t *)data, val); > + return 0; > +} > +static int debugfs_atomic_t_get(void *data, u64 *val) > +{ > + *val = atomic_read((atomic_t *)data); > + return 0; > +} > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t, debugfs_atomic_t_get, > + debugfs_atomic_t_set, "%llu\n"); > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t_ro, debugfs_atomic_t_get, NULL, "%llu\n"); > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t_wo, NULL, debugfs_atomic_t_set, "%llu\n"); > + > +/** > + * debugfs_create_atomic_t - create a debugfs file that is used to read and > + * write an atomic_t value > + * @name: a pointer to a string containing the name of the file to create. > + * @mode: the permission that the file should have > + * @parent: a pointer to the parent dentry for this file. This should be a > + * directory dentry if set. If this parameter is %NULL, then the > + * file will be created in the root of the debugfs filesystem. > + * @value: a pointer to the variable that the file should read to and write > + * from. > + */ > +struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, > + struct dentry *parent, atomic_t *value) > +{ > + /* if there are no write bits set, make read only */ > + if (!(mode & S_IWUGO)) > + return debugfs_create_file(name, mode, parent, value, > + &fops_atomic_t_ro); > + /* if there are no read bits set, make write only */ > + if (!(mode & S_IRUGO)) > + return debugfs_create_file(name, mode, parent, value, > + &fops_atomic_t_wo); > + > + return debugfs_create_file(name, mode, parent, value, &fops_atomic_t); > +} > +EXPORT_SYMBOL_GPL(debugfs_create_atomic_t); > > static ssize_t read_file_bool(struct file *file, char __user *user_buf, > size_t count, loff_t *ppos) > diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h > index 66c434f..51fea70 100644 > --- a/include/linux/debugfs.h > +++ b/include/linux/debugfs.h > @@ -79,6 +79,8 @@ struct dentry *debugfs_create_x64(const char *name, umode_t mode, > struct dentry *parent, u64 *value); > struct dentry *debugfs_create_size_t(const char *name, umode_t mode, > struct dentry *parent, size_t *value); > +struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, > + struct dentry *parent, atomic_t *value); > struct dentry *debugfs_create_bool(const char *name, umode_t mode, > struct dentry *parent, u32 *value); > > -- > 1.7.9.5 >
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> To: Seth Jennings <sjenning@linux.vnet.ibm.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>, Dan Magenheimer <dan.magenheimer@oracle.com>, Robert Jennings <rcj@linux.vnet.ibm.com>, Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <jweiner@redhat.com>, Rik van Riel <riel@redhat.com>, Larry Woodman <lwoodman@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Dave Hansen <dave@linux.vnet.ibm.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCHv3 1/6] debugfs: add get/set for atomic types Date: Tue, 29 Jan 2013 15:35:10 -0500 [thread overview] Message-ID: <20130129203509.GB27740@konrad-lan.dumpdata.com> (raw) In-Reply-To: <1359409767-30092-2-git-send-email-sjenning@linux.vnet.ibm.com> On Mon, Jan 28, 2013 at 03:49:22PM -0600, Seth Jennings wrote: > debugfs currently lack the ability to create attributes > that set/get atomic_t values. > > This patch adds support for this through a new > debugfs_create_atomic_t() function. > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > fs/debugfs/file.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > include/linux/debugfs.h | 2 ++ > 2 files changed, 44 insertions(+) > > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c > index c5ca6ae..fa26d5b 100644 > --- a/fs/debugfs/file.c > +++ b/fs/debugfs/file.c > @@ -21,6 +21,7 @@ > #include <linux/debugfs.h> > #include <linux/io.h> > #include <linux/slab.h> > +#include <linux/atomic.h> > > static ssize_t default_read_file(struct file *file, char __user *buf, > size_t count, loff_t *ppos) > @@ -403,6 +404,47 @@ struct dentry *debugfs_create_size_t(const char *name, umode_t mode, > } > EXPORT_SYMBOL_GPL(debugfs_create_size_t); > > +static int debugfs_atomic_t_set(void *data, u64 val) Should the 'data' be 'atomic_t *' just to make sure nobody messes this up? Or would that bring too much header changes? > +{ > + atomic_set((atomic_t *)data, val); > + return 0; > +} > +static int debugfs_atomic_t_get(void *data, u64 *val) > +{ > + *val = atomic_read((atomic_t *)data); > + return 0; > +} > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t, debugfs_atomic_t_get, > + debugfs_atomic_t_set, "%llu\n"); > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t_ro, debugfs_atomic_t_get, NULL, "%llu\n"); > +DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t_wo, NULL, debugfs_atomic_t_set, "%llu\n"); > + > +/** > + * debugfs_create_atomic_t - create a debugfs file that is used to read and > + * write an atomic_t value > + * @name: a pointer to a string containing the name of the file to create. > + * @mode: the permission that the file should have > + * @parent: a pointer to the parent dentry for this file. This should be a > + * directory dentry if set. If this parameter is %NULL, then the > + * file will be created in the root of the debugfs filesystem. > + * @value: a pointer to the variable that the file should read to and write > + * from. > + */ > +struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, > + struct dentry *parent, atomic_t *value) > +{ > + /* if there are no write bits set, make read only */ > + if (!(mode & S_IWUGO)) > + return debugfs_create_file(name, mode, parent, value, > + &fops_atomic_t_ro); > + /* if there are no read bits set, make write only */ > + if (!(mode & S_IRUGO)) > + return debugfs_create_file(name, mode, parent, value, > + &fops_atomic_t_wo); > + > + return debugfs_create_file(name, mode, parent, value, &fops_atomic_t); > +} > +EXPORT_SYMBOL_GPL(debugfs_create_atomic_t); > > static ssize_t read_file_bool(struct file *file, char __user *user_buf, > size_t count, loff_t *ppos) > diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h > index 66c434f..51fea70 100644 > --- a/include/linux/debugfs.h > +++ b/include/linux/debugfs.h > @@ -79,6 +79,8 @@ struct dentry *debugfs_create_x64(const char *name, umode_t mode, > struct dentry *parent, u64 *value); > struct dentry *debugfs_create_size_t(const char *name, umode_t mode, > struct dentry *parent, size_t *value); > +struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, > + struct dentry *parent, atomic_t *value); > struct dentry *debugfs_create_bool(const char *name, umode_t mode, > struct dentry *parent, u32 *value); > > -- > 1.7.9.5 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-29 20:36 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-28 21:49 [PATCHv3 0/6] zswap: compressed swap caching Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-28 21:49 ` [PATCHv3 1/6] debugfs: add get/set for atomic types Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-29 20:35 ` Konrad Rzeszutek Wilk [this message] 2013-01-29 20:35 ` Konrad Rzeszutek Wilk 2013-01-29 20:49 ` Seth Jennings 2013-01-29 20:49 ` Seth Jennings 2013-01-28 21:49 ` [PATCHv3 2/6] zsmalloc: promote to lib/ Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-28 23:56 ` Minchan Kim 2013-01-28 23:56 ` Minchan Kim 2013-01-28 21:49 ` [PATCHv3 3/6] mm: break up swap_writepage() for frontswap backends Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-28 23:58 ` Minchan Kim 2013-01-28 23:58 ` Minchan Kim 2013-01-28 21:49 ` [PATCHv3 4/6] mm: allow for outstanding swap writeback accounting Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-29 0:01 ` Minchan Kim 2013-01-29 0:01 ` Minchan Kim 2013-01-28 21:49 ` [PATCHv3 5/6] zswap: add to mm/ Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-29 6:27 ` Minchan Kim 2013-01-29 6:27 ` Minchan Kim 2013-01-29 17:26 ` Seth Jennings 2013-01-29 17:26 ` Seth Jennings 2013-01-30 4:44 ` Minchan Kim 2013-01-30 4:44 ` Minchan Kim 2013-02-06 23:47 ` Dan Magenheimer 2013-02-06 23:47 ` Dan Magenheimer 2013-02-07 3:08 ` Seth Jennings 2013-02-07 3:08 ` Seth Jennings 2013-01-29 18:55 ` Seth Jennings 2013-01-29 18:55 ` Seth Jennings 2013-01-28 21:49 ` [PATCHv3 6/6] zswap: add documentation Seth Jennings 2013-01-28 21:49 ` Seth Jennings 2013-01-28 22:08 ` [PATCHv3 0/6] zswap: compressed swap caching Seth Jennings 2013-01-28 22:08 ` Seth Jennings
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130129203509.GB27740@konrad-lan.dumpdata.com \ --to=konrad.wilk@oracle.com \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=dan.magenheimer@oracle.com \ --cc=dave@linux.vnet.ibm.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=jhopper@us.ibm.com \ --cc=jweiner@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lwoodman@redhat.com \ --cc=mgorman@suse.de \ --cc=minchan@kernel.org \ --cc=ngupta@vflare.org \ --cc=rcj@linux.vnet.ibm.com \ --cc=riel@redhat.com \ --cc=sjenning@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.