All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org, shawn.guo@linaro.org,
	B38611@freescale.com, s.hauer@pengutronix.de
Subject: Re: [PATCH v3 2/2 net-next] net: fec: fix spin_lock dead lock
Date: Thu, 07 Feb 2013 23:37:08 -0500 (EST)	[thread overview]
Message-ID: <20130207.233708.2170335376726433338.davem@davemloft.net> (raw)
In-Reply-To: <1360198799-25173-2-git-send-email-Frank.Li@freescale.com>

From: Frank Li <Frank.Li@freescale.com>
Date: Thu, 7 Feb 2013 08:59:59 +0800

> =========================================================
> [ INFO: possible irq lock inversion dependency detected ]
> 3.8.0-rc5+ #82 Not tainted
> ---------------------------------------------------------
> swapper/0/0 just changed the state of lock:
>  (&(&fep->hw_lock)->rlock){..-...}, at: [<8034e2f8>] fec_enet_start_xmit+0x48/0x                      2cc
> but this lock took another, SOFTIRQ-unsafe lock in the past:
> (prepare_lock){+.+.+.}
> 
> and interrupts could create inverse lock ordering between them.
> other info that might help us debug this:
> Possible interrupt unsafe locking scenario:
> 
> CPU0				CPU1
> ----				----
> lock(prepare_lock);
> 				local_irq_disable()
> 				lock(&(&fep->hw_lock)->rlock);
> 				lock(prepare_lock);
> <Interrupt>
> lock(&(&fep->hw_lock)->rlock);
> 
> *** DEADLOCK ***
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

Applied.

WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2 net-next] net: fec: fix spin_lock dead lock
Date: Thu, 07 Feb 2013 23:37:08 -0500 (EST)	[thread overview]
Message-ID: <20130207.233708.2170335376726433338.davem@davemloft.net> (raw)
In-Reply-To: <1360198799-25173-2-git-send-email-Frank.Li@freescale.com>

From: Frank Li <Frank.Li@freescale.com>
Date: Thu, 7 Feb 2013 08:59:59 +0800

> =========================================================
> [ INFO: possible irq lock inversion dependency detected ]
> 3.8.0-rc5+ #82 Not tainted
> ---------------------------------------------------------
> swapper/0/0 just changed the state of lock:
>  (&(&fep->hw_lock)->rlock){..-...}, at: [<8034e2f8>] fec_enet_start_xmit+0x48/0x                      2cc
> but this lock took another, SOFTIRQ-unsafe lock in the past:
> (prepare_lock){+.+.+.}
> 
> and interrupts could create inverse lock ordering between them.
> other info that might help us debug this:
> Possible interrupt unsafe locking scenario:
> 
> CPU0				CPU1
> ----				----
> lock(prepare_lock);
> 				local_irq_disable()
> 				lock(&(&fep->hw_lock)->rlock);
> 				lock(prepare_lock);
> <Interrupt>
> lock(&(&fep->hw_lock)->rlock);
> 
> *** DEADLOCK ***
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

Applied.

  reply	other threads:[~2013-02-08  4:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07  0:59 [PATCH v3 1/2 net-next] net: fec: correct fix method about miss init spinlock Frank Li
2013-02-07  0:59 ` Frank Li
2013-02-07  0:59 ` [PATCH v3 2/2 net-next] net: fec: fix spin_lock dead lock Frank Li
2013-02-07  0:59   ` Frank Li
2013-02-08  4:37   ` David Miller [this message]
2013-02-08  4:37     ` David Miller
2013-02-08  4:36 ` [PATCH v3 1/2 net-next] net: fec: correct fix method about miss init spinlock David Miller
2013-02-08  4:36   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130207.233708.2170335376726433338.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=B38611@freescale.com \
    --cc=Frank.Li@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lznuaa@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.