All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] bgmac: fix unaligned accesses to network headers
@ 2013-02-16 21:10 Hauke Mehrtens
  2013-02-18 17:45 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2013-02-16 21:10 UTC (permalink / raw)
  To: davem; +Cc: zajec5, netdev, stephen, Hauke Mehrtens

Without this patch I get many unaligned access warnings per packet,
this patches fixes them all. This should improve performance on some
systems like mips.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/ethernet/broadcom/bgmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index d341090..3fd3288 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -301,7 +301,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
 			bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
 				  ring->start);
 		} else {
-			new_skb = netdev_alloc_skb(bgmac->net_dev, len);
+			new_skb = netdev_alloc_skb_ip_align(bgmac->net_dev, len);
 			if (new_skb) {
 				skb_put(new_skb, len);
 				skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] bgmac: fix unaligned accesses to network headers
  2013-02-16 21:10 [PATCH v2] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
@ 2013-02-18 17:45 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-18 17:45 UTC (permalink / raw)
  To: hauke; +Cc: zajec5, netdev, stephen

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat, 16 Feb 2013 22:10:38 +0100

> Without this patch I get many unaligned access warnings per packet,
> this patches fixes them all. This should improve performance on some
> systems like mips.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-18 17:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-16 21:10 [PATCH v2] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
2013-02-18 17:45 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.