From: Felipe Balbi <balbi@ti.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: Felipe Balbi <balbi@ti.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@redhat.com>, <JBottomley@parallels.com>, <linux-scsi@vger.kernel.org>, <davem@davemloft.net>, <netdev@vger.kernel.org>, Doug Thompson <dougthompson@xmission.com>, <linux-edac@vger.kernel.org>, <rjw@sisk.pl>, <linux-pm@vger.kernel.org> Subject: Re: SYSFS "errors" Date: Mon, 18 Feb 2013 20:46:33 +0200 [thread overview] Message-ID: <20130218184633.GC10755@arwen.pp.htv.fi> (raw) In-Reply-To: <20130218174916.GA2070@kroah.com> [-- Attachment #1: Type: text/plain, Size: 3705 bytes --] Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: > > Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms > > The issue with this file is, if the power.use_autosuspend flag is not > set for the device, then it can't be read or written to. This flag > changes dynamically with the system state > (__pm_runtime_use_autosuspend() can change it), so we can't just not > show the file if the flag is not set properly, sorry. > > So the "error" is correct here, as is the 0644 file value. hmm... we could create the file at pm_runtime_enable() time and remove it on pm_runtime_disable() time, no ? Addin Rafael to Cc > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/pid > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/end_lba > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/enable > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/act_mask > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/start_lba > > Invalid argument - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/scsi_host/host1/em_buffer > > Invalid argument - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/target1:0:0/1:0:0:0/sw_activity > > Operation not supported - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/target1:0:0/1:0:0:0/unload_heads > > SCSI fun, go poke the SCSI developers about these files, I know nothing > about them, nor do I really want to :) > > > No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate > > Odd, go ask the edac developers will do ;-) > > Input/output error - /sys/devices/system/memory/soft_offline_page > > Input/output error - /sys/devices/system/memory/hard_offline_page > > These both should be mode 0400, not 0644, they have no 'show' attribute, > that's a bug, care to make up a patch that I can take? Or I can, let me > know. sure, will send in a bit. > > Invalid argument - /sys/devices/virtual/net/lo/speed > > Invalid argument - /sys/devices/virtual/net/lo/duplex > > Ask the network developers, odds are, the loopback device doesn't really > have a speed :) right ;-) > > No such device or address - /sys/devices/virtual/block/loop0/trace/pid > > No such device or address - /sys/devices/virtual/block/loop0/trace/end_lba > > No such device or address - /sys/devices/virtual/block/loop0/trace/enable > > No such device or address - /sys/devices/virtual/block/loop0/trace/act_mask > > No such device or address - /sys/devices/virtual/block/loop0/trace/start_lba > > Hm, these show up for virtual block devices as well, maybe they aren't > scsi specific, but rather block specific, go poke the block developers > then. yeah, I was looking into these a while ago. They're created by blk_trace_init_sysfs() which is called by blk_register_queue() but I wonder if we couldn't defer the creation of those so that: sysfs_blk_trace_attr_show(): 1639 bdev = bdget(part_devt(p)); 1640 if (bdev == NULL) 1641 goto out; 1642 1643 q = blk_trace_get_queue(bdev); 1644 if (q == NULL) 1645 goto out_bdput; never fail (meaning they could be removed), adding some block folks to the loop. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: Felipe Balbi <balbi@ti.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@redhat.com>, JBottomley@parallels.com, linux-scsi@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, Doug Thompson <dougthompson@xmission.com>, linux-edac@vger.kernel.org, rjw@sisk.pl, linux-pm@vger.kernel.org Subject: Re: SYSFS "errors" Date: Mon, 18 Feb 2013 20:46:33 +0200 [thread overview] Message-ID: <20130218184633.GC10755@arwen.pp.htv.fi> (raw) In-Reply-To: <20130218174916.GA2070@kroah.com> [-- Attachment #1: Type: text/plain, Size: 3705 bytes --] Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: > > Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms > > The issue with this file is, if the power.use_autosuspend flag is not > set for the device, then it can't be read or written to. This flag > changes dynamically with the system state > (__pm_runtime_use_autosuspend() can change it), so we can't just not > show the file if the flag is not set properly, sorry. > > So the "error" is correct here, as is the 0644 file value. hmm... we could create the file at pm_runtime_enable() time and remove it on pm_runtime_disable() time, no ? Addin Rafael to Cc > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/pid > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/end_lba > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/enable > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/act_mask > > No such device or address - /sys/devices/pci0000:00/0000:00:1d.7/usb2/2-5/2-5.1/2-5.1.1/2-5.1.1:1.0/host100/target100:0:0/100:0:0:0/block/sdc/trace/start_lba > > Invalid argument - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/scsi_host/host1/em_buffer > > Invalid argument - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/target1:0:0/1:0:0:0/sw_activity > > Operation not supported - /sys/devices/pci0000:00/0000:00:1f.2/ata2/host1/target1:0:0/1:0:0:0/unload_heads > > SCSI fun, go poke the SCSI developers about these files, I know nothing > about them, nor do I really want to :) > > > No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate > > Odd, go ask the edac developers will do ;-) > > Input/output error - /sys/devices/system/memory/soft_offline_page > > Input/output error - /sys/devices/system/memory/hard_offline_page > > These both should be mode 0400, not 0644, they have no 'show' attribute, > that's a bug, care to make up a patch that I can take? Or I can, let me > know. sure, will send in a bit. > > Invalid argument - /sys/devices/virtual/net/lo/speed > > Invalid argument - /sys/devices/virtual/net/lo/duplex > > Ask the network developers, odds are, the loopback device doesn't really > have a speed :) right ;-) > > No such device or address - /sys/devices/virtual/block/loop0/trace/pid > > No such device or address - /sys/devices/virtual/block/loop0/trace/end_lba > > No such device or address - /sys/devices/virtual/block/loop0/trace/enable > > No such device or address - /sys/devices/virtual/block/loop0/trace/act_mask > > No such device or address - /sys/devices/virtual/block/loop0/trace/start_lba > > Hm, these show up for virtual block devices as well, maybe they aren't > scsi specific, but rather block specific, go poke the block developers > then. yeah, I was looking into these a while ago. They're created by blk_trace_init_sysfs() which is called by blk_register_queue() but I wonder if we couldn't defer the creation of those so that: sysfs_blk_trace_attr_show(): 1639 bdev = bdget(part_devt(p)); 1640 if (bdev == NULL) 1641 goto out; 1642 1643 q = blk_trace_get_queue(bdev); 1644 if (q == NULL) 1645 goto out_bdput; never fail (meaning they could be removed), adding some block folks to the loop. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-18 18:47 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-18 15:33 SYSFS "errors" Felipe Balbi 2013-02-18 15:50 ` Greg KH 2013-02-18 15:52 ` Felipe Balbi 2013-02-18 17:13 ` Greg KH 2013-02-18 17:27 ` Felipe Balbi 2013-02-18 17:45 ` Borislav Petkov 2013-02-18 18:47 ` Felipe Balbi 2013-02-18 19:40 ` Borislav Petkov 2013-02-18 20:04 ` Felipe Balbi 2013-02-18 17:49 ` Greg KH 2013-02-18 18:46 ` Felipe Balbi [this message] 2013-02-18 18:46 ` Felipe Balbi 2013-02-18 19:46 ` Mauro Carvalho Chehab 2013-02-18 19:46 ` Mauro Carvalho Chehab 2013-02-18 20:05 ` Felipe Balbi 2013-02-18 20:05 ` Felipe Balbi 2013-02-18 21:47 ` Mauro Carvalho Chehab 2013-02-18 21:47 ` Mauro Carvalho Chehab 2013-02-18 21:54 ` Greg KH 2013-02-18 22:13 ` Borislav Petkov 2013-02-18 22:26 ` Greg KH 2013-02-18 22:44 ` Borislav Petkov 2013-02-19 10:03 ` Mauro Carvalho Chehab 2013-02-19 10:11 ` Felipe Balbi 2013-02-19 10:11 ` Felipe Balbi 2013-02-19 11:11 ` Mauro Carvalho Chehab 2013-02-19 11:11 ` Mauro Carvalho Chehab 2013-02-19 11:43 ` Borislav Petkov 2013-02-19 12:16 ` Mauro Carvalho Chehab 2013-02-19 12:35 ` Borislav Petkov 2013-02-19 12:46 ` Mauro Carvalho Chehab 2013-02-19 13:06 ` Borislav Petkov 2013-02-19 13:15 ` Felipe Balbi 2013-02-19 13:15 ` Felipe Balbi 2013-02-19 13:28 ` Borislav Petkov 2013-02-19 13:38 ` Felipe Balbi 2013-02-19 13:38 ` Felipe Balbi 2013-02-19 13:50 ` Mauro Carvalho Chehab 2013-02-19 13:50 ` Mauro Carvalho Chehab 2013-02-19 13:55 ` Borislav Petkov 2013-02-19 13:50 ` Borislav Petkov 2013-02-19 13:58 ` Hannes Reinecke 2013-02-19 14:10 ` Borislav Petkov 2013-02-19 14:14 ` Mauro Carvalho Chehab 2013-02-19 14:19 ` Felipe Balbi 2013-02-19 14:19 ` Felipe Balbi 2013-02-19 14:35 ` Mauro Carvalho Chehab 2013-02-19 14:50 ` Borislav Petkov 2013-02-19 14:53 ` Felipe Balbi 2013-02-19 14:53 ` Felipe Balbi 2013-02-19 13:42 ` Mauro Carvalho Chehab 2013-02-18 21:48 ` Alan Stern 2013-02-18 21:48 ` Alan Stern 2013-02-18 21:57 ` Felipe Balbi 2013-02-18 21:57 ` Felipe Balbi 2013-02-19 7:41 ` Alexander Stein 2013-02-19 10:12 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130218184633.GC10755@arwen.pp.htv.fi \ --to=balbi@ti.com \ --cc=JBottomley@parallels.com \ --cc=davem@davemloft.net \ --cc=dougthompson@xmission.com \ --cc=fweisbec@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=rjw@sisk.pl \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.