From: David Miller <davem@davemloft.net>
To: or.gerlitz@gmail.com
Cc: eilong@broadcom.com, eliezer.tamir@linux.intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, donald.c.skidmore@intel.com,
e1000-devel@lists.sourceforge.net, willemb@google.com,
andi@firstfloor.org, hpa@zytor.com, eliezer@tamir.org.il
Subject: Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll
Date: Tue, 21 May 2013 01:39:12 -0700 (PDT) [thread overview]
Message-ID: <20130521.013912.96249995742935192.davem@davemloft.net> (raw)
In-Reply-To: <CAJZOPZJTA9A8T4R8MtRCeqcYj3XJWFCXF+ojmEqza5TMj-6G+w@mail.gmail.com>
From: Or Gerlitz <or.gerlitz@gmail.com>
Date: Tue, 21 May 2013 11:24:41 +0300
> On Tue, May 21, 2013 at 10:14 AM, David Miller <davem@davemloft.net> wrote:
>> From: "Eilon Greenstein" <eilong@broadcom.com>
>> Date: Tue, 21 May 2013 10:06:43 +0300
>>
>>> Hopefully this series will be accepted so we can send follow up support
>>> for the bnx2x as well.
>>
>> I think in two or three more iterations it will be merged.
>>
>> There are no objections on the fundamentals, it's just implementation
>> details and coding style at this point.
>
> Dave, sorry, I might be a bit behind the rest of the reviewers, but I
> just fail to understand nor find any reference that explains the
> module param of ixgbe nor it makes sense to me to merge that piece of
> the code upstream (its not for staging, correct?), as I wrote here
> http://marc.info/?l=linux-netdev&m=136908123432072&w=2 basically, I
> know you're not a great fun of module params (to say the least) and
> surely not something named "allow_unsafe_removal", thoughts?
It's one of those "implementation details", I hate it too.
next prev parent reply other threads:[~2013-05-21 8:39 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 10:15 [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-20 10:15 ` Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 15:29 ` Eric Dumazet
2013-05-20 19:40 ` David Miller
2013-05-21 7:28 ` Eliezer Tamir
2013-05-21 13:28 ` Eric Dumazet
2013-05-21 17:02 ` Pekka Riikonen
2013-05-21 17:48 ` Eric Dumazet
2013-05-21 17:51 ` Eric Dumazet
2013-05-21 17:51 ` Eric Dumazet
2013-05-21 19:25 ` Eliezer Tamir
2013-05-21 19:25 ` Eliezer Tamir
2013-05-21 19:29 ` Eric Dumazet
2013-05-21 19:29 ` Eric Dumazet
2013-05-21 18:49 ` David Miller
2013-05-21 19:31 ` Pekka Riikonen
2013-05-21 19:31 ` Pekka Riikonen
2013-05-20 10:16 ` [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 13:49 ` Eric Dumazet
2013-05-20 14:59 ` Eliezer Tamir
2013-05-20 14:59 ` Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 20:20 ` Or Gerlitz
2013-05-20 20:20 ` Or Gerlitz
2013-05-20 20:33 ` Andi Kleen
2013-05-20 20:42 ` Or Gerlitz
2013-05-20 21:01 ` Andi Kleen
2013-05-21 6:23 ` Or Gerlitz
2013-05-21 6:23 ` Or Gerlitz
2013-05-21 6:54 ` Eliezer Tamir
2013-05-21 6:54 ` Eliezer Tamir
2013-05-21 7:06 ` Eilon Greenstein
2013-05-21 7:06 ` Eilon Greenstein
2013-05-21 7:14 ` David Miller
2013-05-21 8:24 ` Or Gerlitz
2013-05-21 8:24 ` Or Gerlitz
2013-05-21 8:31 ` Eliezer Tamir
2013-05-21 8:31 ` Eliezer Tamir
2013-05-21 8:39 ` David Miller [this message]
2013-05-21 8:42 ` Eliezer Tamir
2013-05-21 8:42 ` Eliezer Tamir
2013-05-21 8:43 ` Or Gerlitz
2013-05-21 8:43 ` Or Gerlitz
2013-05-21 10:27 ` Eliezer Tamir
2013-05-21 10:41 ` Or Gerlitz
2013-05-21 8:21 ` Or Gerlitz
2013-05-21 8:21 ` Or Gerlitz
2013-05-21 8:28 ` Eilon Greenstein
2013-05-21 8:28 ` Eilon Greenstein
2013-05-21 14:19 ` Willem de Bruijn
2013-05-21 14:19 ` Willem de Bruijn
2013-05-20 10:16 ` [PATCH v3 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-21 12:06 ` [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Alex Rosenbaum
2013-05-21 12:29 ` Eliezer Tamir
2013-05-21 13:15 ` Alex Rosenbaum
2013-05-21 13:15 ` Alex Rosenbaum
2013-05-21 13:31 ` Eric Dumazet
2013-05-23 11:06 ` Eliezer Tamir
2013-05-23 11:45 ` Alex Rosenbaum
2013-05-21 14:30 ` Willem de Bruijn
2013-05-21 14:30 ` Willem de Bruijn
2013-05-21 18:15 ` Ben Hutchings
2013-05-21 18:15 ` Ben Hutchings
2013-05-22 9:35 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521.013912.96249995742935192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.