From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pekka Riikonen <priikone@iki.fi>,
Dave Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net,
Willem de Bruijn <willemb@google.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling
Date: Tue, 21 May 2013 22:25:43 +0300 [thread overview]
Message-ID: <519BCA37.4020707@linux.intel.com> (raw)
In-Reply-To: <1369158686.3301.237.camel@edumazet-glaptop>
On 21/05/2013 20:51, Eric Dumazet wrote:
> On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote:
>
>> We do not keep skb->dev information once a packet leaves the rcu
>> protected region.
>>
>> Once packet is queued to tcp input queues, skb->dev is NULL.
>
> This is done in tcp_v4_rcv() & tcp_v6_rcv()
So if we move calling sk_mark_ll() into the rcu protected region,
We would not need the gen id in the skb.
We could save skb->dev and skb->queue_mapping along with the generation
id in the socket.
then we don't need to change the skb struct at all.
skb_mark_ll() can go away.
we also call sk_mark_ll in one central place in net_protocol->handler
instead of all over the place.
or am I missing something?
WARNING: multiple messages have this Message-ID (diff)
From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Willem de Bruijn <willemb@google.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
HPA <hpa@zytor.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Eliezer Tamir <eliezer@tamir.org.il>,
Dave Miller <davem@davemloft.net>,
Pekka Riikonen <priikone@iki.fi>
Subject: Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling
Date: Tue, 21 May 2013 22:25:43 +0300 [thread overview]
Message-ID: <519BCA37.4020707@linux.intel.com> (raw)
In-Reply-To: <1369158686.3301.237.camel@edumazet-glaptop>
On 21/05/2013 20:51, Eric Dumazet wrote:
> On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote:
>
>> We do not keep skb->dev information once a packet leaves the rcu
>> protected region.
>>
>> Once packet is queued to tcp input queues, skb->dev is NULL.
>
> This is done in tcp_v4_rcv() & tcp_v6_rcv()
So if we move calling sk_mark_ll() into the rcu protected region,
We would not need the gen id in the skb.
We could save skb->dev and skb->queue_mapping along with the generation
id in the socket.
then we don't need to change the skb struct at all.
skb_mark_ll() can go away.
we also call sk_mark_ll in one central place in net_protocol->handler
instead of all over the place.
or am I missing something?
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-05-21 19:26 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 10:15 [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-20 10:15 ` Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 15:29 ` Eric Dumazet
2013-05-20 19:40 ` David Miller
2013-05-21 7:28 ` Eliezer Tamir
2013-05-21 13:28 ` Eric Dumazet
2013-05-21 17:02 ` Pekka Riikonen
2013-05-21 17:48 ` Eric Dumazet
2013-05-21 17:51 ` Eric Dumazet
2013-05-21 17:51 ` Eric Dumazet
2013-05-21 19:25 ` Eliezer Tamir [this message]
2013-05-21 19:25 ` Eliezer Tamir
2013-05-21 19:29 ` Eric Dumazet
2013-05-21 19:29 ` Eric Dumazet
2013-05-21 18:49 ` David Miller
2013-05-21 19:31 ` Pekka Riikonen
2013-05-21 19:31 ` Pekka Riikonen
2013-05-20 10:16 ` [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 13:49 ` Eric Dumazet
2013-05-20 14:59 ` Eliezer Tamir
2013-05-20 14:59 ` Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-20 20:20 ` Or Gerlitz
2013-05-20 20:20 ` Or Gerlitz
2013-05-20 20:33 ` Andi Kleen
2013-05-20 20:42 ` Or Gerlitz
2013-05-20 21:01 ` Andi Kleen
2013-05-21 6:23 ` Or Gerlitz
2013-05-21 6:23 ` Or Gerlitz
2013-05-21 6:54 ` Eliezer Tamir
2013-05-21 6:54 ` Eliezer Tamir
2013-05-21 7:06 ` Eilon Greenstein
2013-05-21 7:06 ` Eilon Greenstein
2013-05-21 7:14 ` David Miller
2013-05-21 8:24 ` Or Gerlitz
2013-05-21 8:24 ` Or Gerlitz
2013-05-21 8:31 ` Eliezer Tamir
2013-05-21 8:31 ` Eliezer Tamir
2013-05-21 8:39 ` David Miller
2013-05-21 8:42 ` Eliezer Tamir
2013-05-21 8:42 ` Eliezer Tamir
2013-05-21 8:43 ` Or Gerlitz
2013-05-21 8:43 ` Or Gerlitz
2013-05-21 10:27 ` Eliezer Tamir
2013-05-21 10:41 ` Or Gerlitz
2013-05-21 8:21 ` Or Gerlitz
2013-05-21 8:21 ` Or Gerlitz
2013-05-21 8:28 ` Eilon Greenstein
2013-05-21 8:28 ` Eilon Greenstein
2013-05-21 14:19 ` Willem de Bruijn
2013-05-21 14:19 ` Willem de Bruijn
2013-05-20 10:16 ` [PATCH v3 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-20 10:16 ` Eliezer Tamir
2013-05-21 12:06 ` [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Alex Rosenbaum
2013-05-21 12:29 ` Eliezer Tamir
2013-05-21 13:15 ` Alex Rosenbaum
2013-05-21 13:15 ` Alex Rosenbaum
2013-05-21 13:31 ` Eric Dumazet
2013-05-23 11:06 ` Eliezer Tamir
2013-05-23 11:45 ` Alex Rosenbaum
2013-05-21 14:30 ` Willem de Bruijn
2013-05-21 14:30 ` Willem de Bruijn
2013-05-21 18:15 ` Ben Hutchings
2013-05-21 18:15 ` Ben Hutchings
2013-05-22 9:35 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519BCA37.4020707@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eliezer@tamir.org.il \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=priikone@iki.fi \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.