All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Rob Herring <rob.herring@calxeda.com>,
	Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] of: Export of_irq_count for using in modules
Date: Thu, 30 May 2013 22:17:14 +0200	[thread overview]
Message-ID: <20130530201714.GE19834@game.jcrosoft.org> (raw)
In-Reply-To: <6aa29b1d109a46278a7f37b598defe07d6edfe60.1369921774.git.michal.simek@xilinx.com>

On 15:49 Thu 30 May     , Michal Simek wrote:
> Export of_irq_count for modules.

can you explain why do you need to call of_irq_count

Best Regards,
J.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> We are using this function in remoteproc module drivers.
> There is also drivers/gpio/gpio-mvebu.c in the tree
> which use this function but this driver can't be compiled
> as module. This could be also the reason why is not this driver as module.
> ---
>  drivers/of/irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a3c1c5a..c918dde 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -374,6 +374,7 @@ int of_irq_count(struct device_node *dev)
> 
>  	return nr;
>  }
> +EXPORT_SYMBOL_GPL(of_irq_count);
> 
>  /**
>   * of_irq_to_resource_table - Fill in resource table with node's IRQ info
> --
> 1.8.2.3
> 



> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss


WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
To: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] of: Export of_irq_count for using in modules
Date: Thu, 30 May 2013 22:17:14 +0200	[thread overview]
Message-ID: <20130530201714.GE19834@game.jcrosoft.org> (raw)
In-Reply-To: <6aa29b1d109a46278a7f37b598defe07d6edfe60.1369921774.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

On 15:49 Thu 30 May     , Michal Simek wrote:
> Export of_irq_count for modules.

can you explain why do you need to call of_irq_count

Best Regards,
J.
> 
> Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
> We are using this function in remoteproc module drivers.
> There is also drivers/gpio/gpio-mvebu.c in the tree
> which use this function but this driver can't be compiled
> as module. This could be also the reason why is not this driver as module.
> ---
>  drivers/of/irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a3c1c5a..c918dde 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -374,6 +374,7 @@ int of_irq_count(struct device_node *dev)
> 
>  	return nr;
>  }
> +EXPORT_SYMBOL_GPL(of_irq_count);
> 
>  /**
>   * of_irq_to_resource_table - Fill in resource table with node's IRQ info
> --
> 1.8.2.3
> 



> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

  reply	other threads:[~2013-05-30 20:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 13:49 [PATCH] of: Export of_irq_count for using in modules Michal Simek
2013-05-30 13:49 ` Michal Simek
2013-05-30 20:17 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-05-30 20:17   ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31  8:14   ` Michal Simek
2013-05-31  8:14     ` Michal Simek
2013-05-31 11:00     ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 11:00       ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 13:57       ` Michal Simek
2013-05-31 13:57         ` Michal Simek
2013-05-31 15:16         ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 15:16           ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 16:45           ` Michal Simek
2013-06-06  8:29             ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-06  8:39               ` Michal Simek
2013-06-06 11:55                 ` Grant Likely
2013-06-06 13:26                   ` Michal Simek
2013-06-06 14:49                 ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]                   ` <20130606144929.GI19834-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2013-06-06 17:16                     ` Michal Simek
2013-07-18  7:02                   ` Michal Simek
2013-07-18  7:02                     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530201714.GE19834@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.