From: Mark Brown <broonie@kernel.org> To: Josh Cartwright <joshc@codeaurora.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Grant Likely <grant.likely@linaro.org>, Rob Herring <rob.herring@calxeda.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Sagar Dharia <sdharia@codeaurora.org>, Gilad Avidov <gavidov@codeaurora.org>, Michael Bohan <mbohan@codeaurora.org> Subject: Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI Date: Mon, 9 Sep 2013 16:52:24 +0100 [thread overview] Message-ID: <20130909155224.GQ29403@sirena.org.uk> (raw) In-Reply-To: <20130823160625.GP4035@joshc.qualcomm.com> [-- Attachment #1: Type: text/plain, Size: 1394 bytes --] On Fri, Aug 23, 2013 at 11:06:25AM -0500, Josh Cartwright wrote: > On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > > + "Example: Read 4 bytes starting at register address 0x1234 for SID 2\n" > > > + "\n" > > > + "echo 0x21234 > address\n" > > > + "echo 4 > count\n" > > > + "cat data\n" > > > + "\n" > > > + "Example: Write 3 bytes starting at register address 0x1008 for SID 1\n" > > > + "\n" > > > + "echo 0x11008 > address\n" > > > + "echo 0x01 0x02 0x03 > data\n" > > > + "\n" > > > + "Note that the count file is not used for writes. Since 3 bytes are\n" > > > + "written to the 'data' file, then 3 bytes will be written across the\n" > > > + "SPMI bus.\n\n"; > > The help file within the kernel is a nice touch :) > > Or is this only for "debugging"? If so, please document it as such. > It's there because it provides a useful interface for debugging of the > controller code, and for simple peek/poke of the slave registers without > having a full driver in place. Will document this. This looks awfully like a version of the debugfs interfaces that regmap provides, and indeed the entire bus sounds like something that could idiomatically be supported via regmap. Have you considered doing that? This would give access to standard tracepoints as well, plus the cache infrastructure. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI Date: Mon, 9 Sep 2013 16:52:24 +0100 [thread overview] Message-ID: <20130909155224.GQ29403@sirena.org.uk> (raw) In-Reply-To: <20130823160625.GP4035@joshc.qualcomm.com> On Fri, Aug 23, 2013 at 11:06:25AM -0500, Josh Cartwright wrote: > On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: > > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: > > > + "Example: Read 4 bytes starting at register address 0x1234 for SID 2\n" > > > + "\n" > > > + "echo 0x21234 > address\n" > > > + "echo 4 > count\n" > > > + "cat data\n" > > > + "\n" > > > + "Example: Write 3 bytes starting at register address 0x1008 for SID 1\n" > > > + "\n" > > > + "echo 0x11008 > address\n" > > > + "echo 0x01 0x02 0x03 > data\n" > > > + "\n" > > > + "Note that the count file is not used for writes. Since 3 bytes are\n" > > > + "written to the 'data' file, then 3 bytes will be written across the\n" > > > + "SPMI bus.\n\n"; > > The help file within the kernel is a nice touch :) > > Or is this only for "debugging"? If so, please document it as such. > It's there because it provides a useful interface for debugging of the > controller code, and for simple peek/poke of the slave registers without > having a full driver in place. Will document this. This looks awfully like a version of the debugfs interfaces that regmap provides, and indeed the entire bus sounds like something that could idiomatically be supported via regmap. Have you considered doing that? This would give access to standard tracepoints as well, plus the cache infrastructure. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130909/f9e563f8/attachment-0001.sig>
next prev parent reply other threads:[~2013-09-09 15:52 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-22 20:18 [PATCH RFC v2 0/3] Add support for the System Power Management Interface (SPMI) Josh Cartwright 2013-08-22 20:18 ` Josh Cartwright 2012-12-10 19:41 ` [PATCH RFC v2 1/5] of: Add empty for_each_available_child_of_node() macro definition Josh Cartwright 2013-08-22 22:57 ` Josh Cartwright 2013-08-09 20:37 ` [PATCH RFC v2 4/5] spmi: Add MSM PMIC Arbiter SPMI controller Josh Cartwright 2013-08-09 20:37 ` Josh Cartwright 2013-08-09 20:37 ` [PATCH RFC v2 5/5] spmi: document the PMIC arbiter SPMI bindings Josh Cartwright 2013-08-09 20:37 ` Josh Cartwright 2013-08-23 21:55 ` Stephen Warren 2013-08-23 21:55 ` Stephen Warren 2013-08-09 20:37 ` [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI Josh Cartwright 2013-08-09 20:37 ` Josh Cartwright 2013-08-22 23:10 ` Greg Kroah-Hartman 2013-08-22 23:10 ` Greg Kroah-Hartman 2013-08-23 16:06 ` Josh Cartwright 2013-08-23 16:06 ` Josh Cartwright 2013-09-09 15:52 ` Mark Brown [this message] 2013-09-09 15:52 ` Mark Brown 2013-09-09 16:56 ` Josh Cartwright 2013-09-09 16:56 ` Josh Cartwright 2013-08-22 19:59 ` [PATCH RFC v2 3/5] spmi: add generic SPMI controller binding documentation Josh Cartwright 2013-08-22 19:59 ` Josh Cartwright 2013-08-23 21:58 ` Stephen Warren 2013-08-23 21:58 ` Stephen Warren 2013-08-27 17:01 ` Josh Cartwright 2013-08-27 17:01 ` Josh Cartwright 2013-08-27 21:55 ` Stephen Warren 2013-08-27 21:55 ` Stephen Warren 2013-08-28 18:00 ` Josh Cartwright 2013-08-28 18:00 ` Josh Cartwright 2013-08-28 18:32 ` Stephen Warren 2013-08-28 18:32 ` Stephen Warren 2013-10-06 6:11 ` Bjorn Andersson 2013-10-06 6:11 ` Bjorn Andersson [not found] ` <CAJAp7Oi-bPytsLtsppdanOi_p0Y5vfBriGB-B5by7w5Z7SGU-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-10-07 21:17 ` Josh Cartwright 2013-10-07 21:17 ` Josh Cartwright 2013-10-07 21:17 ` Josh Cartwright
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130909155224.GQ29403@sirena.org.uk \ --to=broonie@kernel.org \ --cc=gavidov@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=joshc@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mbohan@codeaurora.org \ --cc=rob.herring@calxeda.com \ --cc=sdharia@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.