Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v4)

[Marcelo Tosatti <mtosatti@redhat.com>]

On Wed, Nov 06, 2013 at 11:40:34PM +0200, Michael S. Tsirkin wrote:
> On Wed, Nov 06, 2013 at 07:31:19PM -0200, Marcelo Tosatti wrote:
> > 
> > v2: condition enablement of new mapping to new machine types (Paolo)
> > v3: fix changelog
> > v4: rebase
> > 
> > -----
> > 
> > 
> > Align guest physical address and host physical address
> > beyond guest 4GB on a 1GB boundary.
> > 
> > Otherwise 1GB TLBs cannot be cached for the range.
> > 
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Um. This will conflict with:
>     pc: map PCI address space as catchall region for not mapped addresses
> 
> I think we really should stop using the hacked hole thing
> and just use priorities like that patch does.

Sorry hacked in what way?

This patch is necessary to enable 1GB hugepages beyond 4GB of RAM on the
current machine types.

> Do you agree? If yes I'm afraid your patch will have to be
> rebased on top of that yet again, sorry to give you a
> run-around like that :(

I don't see what exactly is the suggestion (or why the proposed 
patch should conflict with "pc: map PCI address space as catchall region
for not mapped addresses").

> Also - do you think this is 1.7 material?

No. Paolo mentioned you have a tree with 1.8 material, correct?