From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: aarcange@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com
Subject: Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa<->hpa on 1GB boundary
Date: Fri, 25 Oct 2013 09:52:34 +0100 [thread overview]
Message-ID: <526A3152.2020603@redhat.com> (raw)
In-Reply-To: <20131025045805.GA18280@amt.cnet>
Il 25/10/2013 05:58, Marcelo Tosatti ha scritto:
> On Fri, Oct 25, 2013 at 12:55:36AM +0100, Paolo Bonzini wrote:
>>> + if (hpagesize == (1<<30)) {
>>> + unsigned long holesize = 0x100000000ULL - below_4g_mem_size;
>>> +
>>> + memory_region_init_alias(ram_above_4g, NULL, "ram-above-4g", ram,
>>> + 0x100000000ULL,
>>> + above_4g_mem_size - holesize);
>>> + memory_region_add_subregion(system_memory, 0x100000000ULL,
>>> + ram_above_4g);
>>> +
>>> + ram_above_4g_piecetwo = g_malloc(sizeof(*ram_above_4g_piecetwo));
>>> + memory_region_init_alias(ram_above_4g_piecetwo, NULL,
>>> + "ram-above-4g-piecetwo", ram,
>>> + 0x100000000ULL - holesize, holesize);
>>> + memory_region_add_subregion(system_memory,
>>> + 0x100000000ULL +
>>> + above_4g_mem_size - holesize,
>>> + ram_above_4g_piecetwo);
>>
>> Why break it in two? You can just allocate extra holesize bytes in the
>> "ram" MemoryRegion, and not map the part that corresponds to
>> [0x100000000ULL - holesize, 0x100000000ULL).
>
> - If the "ram" MemoryRegion is backed with 1GB hugepages, you might not
> want to allocate extra holesize bytes (which might require an entire
> 1GB page).
>
> - 1GB backed RAM can be mapped with 2MB pages.
>
>> Also, as Peter said this cannot depend on host considerations. Just do
>> it unconditionally, but only for new machine types (pc-1.8 and q35-1.8,
>> since unfortunately we're too close to hard freeze).
>
> Why the description of memory subregions and aliases are part of machine
> types?
It affects the migration stream, which stores RAM offsets instead of
physical addresses.
Let's say you have an 8 GB guest and the hole size is 0.25 GB.
If the huge page size is 2MB, you have:
Physical address Length RAM offsets
0 3.75 GB pc.ram @ 0
4 GB 4.25 GB pc.ram @ 3.75 GB
If the huge page size is 1GB, you have:
Physical address Length RAM offsets
0 3.75 GB pc.ram @ 0
4 GB 4 GB pc.ram @ 4 GB
8 GB 0.25 GB pc.ram @ 3.75 GB
So your memory "rotates" around the 3.75 GB boundary when you migrate
from a non-gbpages host to a gbpages host or vice versa.
If we're doing it only for new machine types, it's even simpler to just
have two RAM regions:
Physical address Length RAM offsets
0 3.75 GB pc.ram-below-4g @ 0
4 GB 4.25 GB pc.ram-above-4g @ 0
Because offsets are zero, and lengths match the RAM block lengths, you
do not need any complication with aliasing. This still has to be done
only for new machine types.
Paolo
next prev parent reply other threads:[~2013-10-25 8:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:11 [Qemu-devel] [patch 0/2] align >4GB guest RAM to a 1GB boundary, in case of 1GB-sized hugetlbfs Marcelo Tosatti
2013-10-24 21:11 ` [Qemu-devel] [patch 1/2] exec: add qemu_get_ram_hpagesize Marcelo Tosatti
2013-10-24 21:12 ` [Qemu-devel] [patch 2/2] i386: pc: align gpa<->hpa on 1GB boundary Marcelo Tosatti
2013-10-24 21:55 ` Peter Maydell
2013-10-24 22:48 ` Marcelo Tosatti
2013-10-24 23:55 ` Paolo Bonzini
2013-10-25 4:58 ` Marcelo Tosatti
2013-10-25 8:52 ` Paolo Bonzini [this message]
2013-10-25 19:50 ` Marcelo Tosatti
2013-10-25 22:53 ` Paolo Bonzini
2013-10-30 11:07 ` Gerd Hoffmann
2013-10-30 11:47 ` Paolo Bonzini
2013-10-25 9:57 ` igor Mammedov
2013-10-25 13:34 ` Marcelo Tosatti
2013-10-27 15:20 ` igor Mammedov
2013-10-28 14:04 ` Marcelo Tosatti
2013-10-28 14:20 ` Marcelo Tosatti
2013-10-29 18:00 ` Igor Mammedov
2013-10-29 21:21 ` Marcelo Tosatti
2013-10-30 8:48 ` Gleb Natapov
2013-10-30 18:30 ` Marcelo Tosatti
2013-10-29 18:18 ` [Qemu-devel] [RFC PATCH] pc: align gpa<->hpa on 1GB boundary by splitting RAM on several regions Igor Mammedov
2013-10-29 21:38 ` Marcelo Tosatti
2013-10-30 16:49 ` Igor Mammedov
2013-10-30 18:51 ` Marcelo Tosatti
2013-10-30 19:03 ` Marcelo Tosatti
2013-10-30 19:56 ` Igor Mammedov
2013-10-30 23:44 ` Marcelo Tosatti
2013-11-07 15:25 ` Igor Mammedov
2013-10-30 19:31 ` Marcelo Tosatti
2013-10-30 20:28 ` Paolo Bonzini
2013-11-06 1:49 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v2) Marcelo Tosatti
2013-11-06 1:55 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v3) Marcelo Tosatti
2013-11-06 11:59 ` Igor Mammedov
2013-11-06 12:07 ` Paolo Bonzini
2013-11-06 12:22 ` Igor Mammedov
2013-11-06 12:24 ` Paolo Bonzini
2013-11-06 21:31 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v4) Marcelo Tosatti
2013-11-06 21:40 ` Michael S. Tsirkin
2013-11-06 21:53 ` Marcelo Tosatti
2013-11-06 22:15 ` Michael S. Tsirkin
2013-11-06 22:24 ` Marcelo Tosatti
2013-11-07 15:24 ` Igor Mammedov
2013-11-07 21:53 ` Marcelo Tosatti
2013-11-10 20:47 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v5) Marcelo Tosatti
2013-11-12 12:45 ` Igor Mammedov
2013-11-12 20:32 ` Marcelo Tosatti
2013-11-12 21:16 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6) Marcelo Tosatti
2013-11-13 13:59 ` Igor Mammedov
2013-11-13 17:13 ` Paolo Bonzini
[not found] ` <20131113195832.GA29433@amt.cnet>
2013-11-13 20:39 ` Marcelo Tosatti
2013-11-13 21:49 ` Paolo Bonzini
2013-11-13 19:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A3152.2020603@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=gleb@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.