All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message
Date: Fri, 14 Feb 2014 15:06:40 +0000	[thread overview]
Message-ID: <20140214150640.GE4451@sirena.org.uk> (raw)
In-Reply-To: <1392302806-17267-1-git-send-email-iivanov@mm-sol.com>

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

On Thu, Feb 13, 2014 at 04:46:46PM +0200, Ivan T. Ivanov wrote:

> +		/* No partial transfers accepted */
> +		if (!n_words || xfer->len & (w_size - 1))
> +			return -EINVAL;

Please write this using % rather than the & - it's a lot clearer what
it's checking for, I had to think what the above meant.  Hopefully the
compiler will make it equally fast either way.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2014-02-14 18:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 14:46 [PATCH] spi: core: Validate lenght of the transfers in message Ivan T. Ivanov
2014-02-13 14:46 ` Ivan T. Ivanov
2014-02-13 21:27 ` Gerhard Sittig
2014-02-13 21:27   ` Gerhard Sittig
2014-02-14  0:26   ` Mark Brown
2014-02-14  0:26     ` Mark Brown
2014-02-14  8:16     ` Ivan T. Ivanov
2014-02-14  8:16       ` Ivan T. Ivanov
2014-02-14 15:05       ` Mark Brown
2014-02-14 15:05         ` Mark Brown
2014-02-14 15:06 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214150640.GE4451@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=iivanov@mm-sol.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.