From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Mark Brown <broonie@kernel.org>
Cc: Gerhard Sittig <gsi@denx.de>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message
Date: Fri, 14 Feb 2014 10:16:05 +0200 [thread overview]
Message-ID: <1392365765.12787.89.camel@iivanov-dev> (raw)
In-Reply-To: <20140214002627.GG28112@sirena.org.uk>
On Fri, 2014-02-14 at 00:26 +0000, Mark Brown wrote:
> On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote:
> > On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote:
>
> > > SPI transfer lenght should be a power-of-two multiple
> > > of eight bits.
>
> > Are you suggesting that an SPI transfer cannot consist of e.g.
> > three bytes? This would be surprising, and certainly would be
> > rather wrong an assumption. Am I missing/misunderstanding
> > something?
>
> The check is supposed to be verifying that the transfer is a whole
> number of the current SPI word size as I understand it (not actually
> looked at the change yet but that's where it came from, factored out of
> a driver).
Yes. Comment is not correct. Is this better?
"SPI transfer length should be multiple of SPI word size, where SPI
word size should be power-of-two multiple"
Regards,
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message
Date: Fri, 14 Feb 2014 10:16:05 +0200 [thread overview]
Message-ID: <1392365765.12787.89.camel@iivanov-dev> (raw)
In-Reply-To: <20140214002627.GG28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Fri, 2014-02-14 at 00:26 +0000, Mark Brown wrote:
> On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote:
> > On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote:
>
> > > SPI transfer lenght should be a power-of-two multiple
> > > of eight bits.
>
> > Are you suggesting that an SPI transfer cannot consist of e.g.
> > three bytes? This would be surprising, and certainly would be
> > rather wrong an assumption. Am I missing/misunderstanding
> > something?
>
> The check is supposed to be verifying that the transfer is a whole
> number of the current SPI word size as I understand it (not actually
> looked at the change yet but that's where it came from, factored out of
> a driver).
Yes. Comment is not correct. Is this better?
"SPI transfer length should be multiple of SPI word size, where SPI
word size should be power-of-two multiple"
Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-14 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 14:46 [PATCH] spi: core: Validate lenght of the transfers in message Ivan T. Ivanov
2014-02-13 14:46 ` Ivan T. Ivanov
2014-02-13 21:27 ` Gerhard Sittig
2014-02-13 21:27 ` Gerhard Sittig
2014-02-14 0:26 ` Mark Brown
2014-02-14 0:26 ` Mark Brown
2014-02-14 8:16 ` Ivan T. Ivanov [this message]
2014-02-14 8:16 ` Ivan T. Ivanov
2014-02-14 15:05 ` Mark Brown
2014-02-14 15:05 ` Mark Brown
2014-02-14 15:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392365765.12787.89.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=broonie@kernel.org \
--cc=gsi@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.